Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] mpv: va-api requires egl-drm, wayland and/or x11
Date: Thu, 28 Apr 2016 16:42:16 +0200	[thread overview]
Message-ID: <20160428164216.0e28690d@free-electrons.com> (raw)
In-Reply-To: <1461853987-5313-1-git-send-email-gustavo@zacarias.com.ar>

Hello,

On Thu, 28 Apr 2016 11:33:07 -0300, Gustavo Zacarias wrote:

>  # va-api support
> +# This requires one or more of the egl-drm, wayland, x11 backends
> +# For now we support wayland and x11
>  ifeq ($(BR2_PACKAGE_LIBVA),y)
> +ifeq ($(BR2_PACKAGE_WAYLAND)$(BR2_PACKAGE_XLIB_LIBX11),)
> +MPV_CONF_OPTS += --disable-vaapi
> +else
>  MPV_CONF_OPTS += --enable-vaapi
>  MPV_DEPENDENCIES += libva
> -else

Can we make that positive logic ?

ifeq ($(BR2_PACKAGE_WAYLAND)$(BR2_PACKAGE_XLIB_LIBX11),y)
enable vaapi
else
disable vaapi
endif

or you have cases where wayland on X is used, so you have both options
set to 'y' and still want the vaapi support ?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-04-28 14:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28 14:33 [Buildroot] [PATCH] mpv: va-api requires egl-drm, wayland and/or x11 Gustavo Zacarias
2016-04-28 14:42 ` Thomas Petazzoni [this message]
2016-04-28 14:51   ` Gustavo Zacarias
2016-04-28 18:34 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160428164216.0e28690d@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox