Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] mpv: va-api requires egl-drm, wayland and/or x11
Date: Thu, 28 Apr 2016 20:34:39 +0200	[thread overview]
Message-ID: <87vb31wpj4.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1461853987-5313-1-git-send-email-gustavo@zacarias.com.ar> (Gustavo Zacarias's message of "Thu, 28 Apr 2016 11:33:07 -0300")

>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 > The VA-API acceleration requires one or more of the egl-drm, wayland
 > and/or x11 backends.
 > Since the egl-drm backend means LIBGL (X11) + EGL + DRM we'll handle it
 > later once the mesa3d libgl hidden knob is applied.
 > So for now we'll support wayland and x11 until that happens. Fixes:
 > http://autobuild.buildroot.net/results/4b9/4b98d0c2c0617715e77fb47b3d97037c6b7562ec/

 > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
 > ---
 >  package/mpv/mpv.mk | 8 ++++++--
 >  1 file changed, 6 insertions(+), 2 deletions(-)

 > diff --git a/package/mpv/mpv.mk b/package/mpv/mpv.mk
 > index 0a13aee..fb45aef 100644
 > --- a/package/mpv/mpv.mk
 > +++ b/package/mpv/mpv.mk
 > @@ -179,11 +179,15 @@ MPV_CONF_OPTS += --disable-sdl1 --disable-sdl2
 >  endif
 
 >  # va-api support
 > +# This requires one or more of the egl-drm, wayland, x11 backends
 > +# For now we support wayland and x11
 >  ifeq ($(BR2_PACKAGE_LIBVA),y)
 > +ifeq ($(BR2_PACKAGE_WAYLAND)$(BR2_PACKAGE_XLIB_LIBX11),)
 > +MPV_CONF_OPTS += --disable-vaapi
 > +else
 >  MPV_CONF_OPTS += --enable-vaapi
 >  MPV_DEPENDENCIES += libva
 > -else
 > -MPV_CONF_OPTS += --disable-vaapi
 > +endif
 >  endif

With this we no longer pass --disable-vaapi if libva isn't enabled. I've
changed it to do that as well and inverted the wayland/libx11 test like
Thomas suggested:

ifneq ($(BR2_PACKAGE_WAYLAND)$(BR2_PACKAGE_XLIB_LIBX11),)
MPV_CONF_OPTS += --enable-vaapi
..

Committed with those changes, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2016-04-28 18:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28 14:33 [Buildroot] [PATCH] mpv: va-api requires egl-drm, wayland and/or x11 Gustavo Zacarias
2016-04-28 14:42 ` Thomas Petazzoni
2016-04-28 14:51   ` Gustavo Zacarias
2016-04-28 18:34 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vb31wpj4.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox