[Buildroot] [PATCH] boot/uboot: fix missing host-openssl for i.MX28 target

[Buildroot] [PATCH] boot/uboot: fix missing host-openssl for i.MX28 target

[Jörg Krause]

From: J?rg Krause <jk@lintech.de>

Building an U-Boot image for the i.MX23 or i.MX28 target requires to run the
bootloaders 'mxsimage' tool on the host. As mxsimage needs unconditionally
OpenSSL, building U-Boot for those targets fails if it is not available on
the host:

tools/mxsimage.c:18:25: fatal error: openssl/evp.h: No such file or directory
  #include <openssl/evp.h>

Add the required dependency 'host-openssl' to all the different U-Boot image
types used to build a bootloader image for an i.MX23/i.MX28 target.

Fetch from:
https://sourceforge.net/p/armadeus/mailman/message/33595402/

Signed-off-by: Julien Boibessot <julien.boibessot@armadeus.com>
[J?rg: port to recent Buildroot version]
Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
---
 boot/uboot/uboot.mk | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
index e071303..e739638 100644
--- a/boot/uboot/uboot.mk
+++ b/boot/uboot/uboot.mk
@@ -58,16 +58,17 @@ UBOOT_BIN = u-boot.imx
 else ifeq ($(BR2_TARGET_UBOOT_FORMAT_SB),y)
 UBOOT_BIN = u-boot.sb
 UBOOT_MAKE_TARGET = $(UBOOT_BIN)
-UBOOT_DEPENDENCIES += host-elftosb
+# mxsimage needs OpenSSL
+UBOOT_DEPENDENCIES += host-elftosb host-openssl
 else ifeq ($(BR2_TARGET_UBOOT_FORMAT_SD),y)
 # BootStream (.sb) is generated by U-Boot, we convert it to SD format
 UBOOT_BIN = u-boot.sd
 UBOOT_MAKE_TARGET = u-boot.sb
-UBOOT_DEPENDENCIES += host-elftosb
+UBOOT_DEPENDENCIES += host-elftosb host-openssl
 else ifeq ($(BR2_TARGET_UBOOT_FORMAT_NAND),y)
 UBOOT_BIN = u-boot.nand
 UBOOT_MAKE_TARGET = u-boot.sb
-UBOOT_DEPENDENCIES += host-elftosb
+UBOOT_DEPENDENCIES += host-elftosb host-openssl
 else ifeq ($(BR2_TARGET_UBOOT_FORMAT_CUSTOM),y)
 UBOOT_BIN = $(call qstrip,$(BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME))
 else
@@ -87,7 +88,9 @@ endif
 
 UBOOT_MAKE_OPTS += \
 	CROSS_COMPILE="$(TARGET_CROSS)" \
-	ARCH=$(UBOOT_ARCH)
+	ARCH=$(UBOOT_ARCH) \
+	HOSTCFLAGS="$(HOST_CFLAGS)" \
+	HOSTLDFLAGS="$(HOST_LDFLAGS)"
 
 ifeq ($(BR2_TARGET_UBOOT_NEEDS_DTC),y)
 UBOOT_DEPENDENCIES += host-dtc
-- 
2.8.2

[Buildroot] [PATCH] boot/uboot: fix missing host-openssl for i.MX28 target

[Baruch Siach]

Hi J?rg,

On Thu, May 19, 2016 at 02:05:40PM +0200, J?rg Krause wrote:
> From: J?rg Krause <jk@lintech.de>

I think you should keep Julien's authorship of this patch.

> Building an U-Boot image for the i.MX23 or i.MX28 target requires to run the
> bootloaders 'mxsimage' tool on the host. As mxsimage needs unconditionally
> OpenSSL, building U-Boot for those targets fails if it is not available on
> the host:
> 
> tools/mxsimage.c:18:25: fatal error: openssl/evp.h: No such file or directory
>   #include <openssl/evp.h>
> 
> Add the required dependency 'host-openssl' to all the different U-Boot image
> types used to build a bootloader image for an i.MX23/i.MX28 target.
> 
> Fetch from:
> https://sourceforge.net/p/armadeus/mailman/message/33595402/
> 
> Signed-off-by: Julien Boibessot <julien.boibessot@armadeus.com>
> [J?rg: port to recent Buildroot version]
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> ---
>  boot/uboot/uboot.mk | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index e071303..e739638 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -58,16 +58,17 @@ UBOOT_BIN = u-boot.imx
>  else ifeq ($(BR2_TARGET_UBOOT_FORMAT_SB),y)
>  UBOOT_BIN = u-boot.sb
>  UBOOT_MAKE_TARGET = $(UBOOT_BIN)
> -UBOOT_DEPENDENCIES += host-elftosb
> +# mxsimage needs OpenSSL
> +UBOOT_DEPENDENCIES += host-elftosb host-openssl
>  else ifeq ($(BR2_TARGET_UBOOT_FORMAT_SD),y)
>  # BootStream (.sb) is generated by U-Boot, we convert it to SD format
>  UBOOT_BIN = u-boot.sd
>  UBOOT_MAKE_TARGET = u-boot.sb
> -UBOOT_DEPENDENCIES += host-elftosb
> +UBOOT_DEPENDENCIES += host-elftosb host-openssl
>  else ifeq ($(BR2_TARGET_UBOOT_FORMAT_NAND),y)
>  UBOOT_BIN = u-boot.nand
>  UBOOT_MAKE_TARGET = u-boot.sb
> -UBOOT_DEPENDENCIES += host-elftosb
> +UBOOT_DEPENDENCIES += host-elftosb host-openssl
>  else ifeq ($(BR2_TARGET_UBOOT_FORMAT_CUSTOM),y)
>  UBOOT_BIN = $(call qstrip,$(BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME))
>  else
> @@ -87,7 +88,9 @@ endif
>  
>  UBOOT_MAKE_OPTS += \
>  	CROSS_COMPILE="$(TARGET_CROSS)" \
> -	ARCH=$(UBOOT_ARCH)
> +	ARCH=$(UBOOT_ARCH) \
> +	HOSTCFLAGS="$(HOST_CFLAGS)" \
> +	HOSTLDFLAGS="$(HOST_LDFLAGS)"

Is this hunk necessary to make mxsimage.c build? If so, please explain how in 
the commit log.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH] boot/uboot: fix missing host-openssl for i.MX28 target

[Thomas Petazzoni]

Hello,

On Thu, 19 May 2016 16:02:03 +0300, Baruch Siach wrote:

> >  UBOOT_MAKE_OPTS += \
> >  	CROSS_COMPILE="$(TARGET_CROSS)" \
> > -	ARCH=$(UBOOT_ARCH)
> > +	ARCH=$(UBOOT_ARCH) \
> > +	HOSTCFLAGS="$(HOST_CFLAGS)" \
> > +	HOSTLDFLAGS="$(HOST_LDFLAGS)"  
> 
> Is this hunk necessary to make mxsimage.c build? If so, please explain how in 
> the commit log.

I guess it is, to allow the U-Boot build process to find OpenSSL in
$(HOST_DIR): thanks to $(HOST_CFLAGS) and $(HOST_LDFLAGS), the right
-I/-L options will be passed to allow U-Boot to find OpenSSL.

But indeed, it's nice when such things are explicitly said in the
commit log.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] boot/uboot: fix missing host-openssl for i.MX28 target

[Jörg Krause]

Hi Baruch,

On Do, 2016-05-19 at 16:02 +0300, Baruch Siach wrote:
> Hi J?rg,
> 
> On Thu, May 19, 2016 at 02:05:40PM +0200, J?rg Krause wrote:
> > From: J?rg Krause <jk@lintech.de>
> 
> I think you should keep Julien's authorship of this patch.

Yes! Honestly, I was suprised by this. In fact I didn't applied the
patch with git, but by copy & paste and then did a git commit & git
format-patch at work and git commit at home...

> > Building an U-Boot image for the i.MX23 or i.MX28 target requires
> > to run the
> > bootloaders 'mxsimage' tool on the host. As mxsimage needs
> > unconditionally
> > OpenSSL, building U-Boot for those targets fails if it is not
> > available on
> > the host:
> > 
> > tools/mxsimage.c:18:25: fatal error: openssl/evp.h: No such file or
> > directory
> > ? #include <openssl/evp.h>
> > 
> > Add the required dependency 'host-openssl' to all the different U-
> > Boot image
> > types used to build a bootloader image for an i.MX23/i.MX28 target.
> > 
> > Fetch from:
> > https://sourceforge.net/p/armadeus/mailman/message/33595402/
> > 
> > Signed-off-by: Julien Boibessot <julien.boibessot@armadeus.com>
> > [J?rg: port to recent Buildroot version]
> > Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> > ---
> > ?boot/uboot/uboot.mk | 11 +++++++----
> > ?1 file changed, 7 insertions(+), 4 deletions(-)
> > 
> > diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> > index e071303..e739638 100644
> > --- a/boot/uboot/uboot.mk
> > +++ b/boot/uboot/uboot.mk
> > @@ -58,16 +58,17 @@ UBOOT_BIN = u-boot.imx
> > ?else ifeq ($(BR2_TARGET_UBOOT_FORMAT_SB),y)
> > ?UBOOT_BIN = u-boot.sb
> > ?UBOOT_MAKE_TARGET = $(UBOOT_BIN)
> > -UBOOT_DEPENDENCIES += host-elftosb
> > +# mxsimage needs OpenSSL
> > +UBOOT_DEPENDENCIES += host-elftosb host-openssl
> > ?else ifeq ($(BR2_TARGET_UBOOT_FORMAT_SD),y)
> > ?# BootStream (.sb) is generated by U-Boot, we convert it to SD
> > format
> > ?UBOOT_BIN = u-boot.sd
> > ?UBOOT_MAKE_TARGET = u-boot.sb
> > -UBOOT_DEPENDENCIES += host-elftosb
> > +UBOOT_DEPENDENCIES += host-elftosb host-openssl
> > ?else ifeq ($(BR2_TARGET_UBOOT_FORMAT_NAND),y)
> > ?UBOOT_BIN = u-boot.nand
> > ?UBOOT_MAKE_TARGET = u-boot.sb
> > -UBOOT_DEPENDENCIES += host-elftosb
> > +UBOOT_DEPENDENCIES += host-elftosb host-openssl
> > ?else ifeq ($(BR2_TARGET_UBOOT_FORMAT_CUSTOM),y)
> > ?UBOOT_BIN = $(call qstrip,$(BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME))
> > ?else
> > @@ -87,7 +88,9 @@ endif
> > ?
> > ?UBOOT_MAKE_OPTS += \
> > ?	CROSS_COMPILE="$(TARGET_CROSS)" \
> > -	ARCH=$(UBOOT_ARCH)
> > +	ARCH=$(UBOOT_ARCH) \
> > +	HOSTCFLAGS="$(HOST_CFLAGS)" \
> > +	HOSTLDFLAGS="$(HOST_LDFLAGS)"
> 
> Is this hunk necessary to make mxsimage.c build? If so, please
> explain how in?
> the commit log.

You're right. Fortunatly, Thomas gave a quite good explanation, which I
would use in an updated version.

J?rg

[Buildroot] [PATCH] boot/uboot: fix missing host-openssl for i.MX28 target

[Baruch Siach]

Hi J?rg,

On Thu, May 19, 2016 at 08:27:21PM +0200, J?rg Krause wrote:
> On Do, 2016-05-19 at 16:02 +0300, Baruch Siach wrote:
> > On Thu, May 19, 2016 at 02:05:40PM +0200, J?rg Krause wrote:
> > > From: J?rg Krause <jk@lintech.de>
> > 
> > I think you should keep Julien's authorship of this patch.
> 
> Yes! Honestly, I was suprised by this. In fact I didn't applied the
> patch with git, but by copy & paste and then did a git commit & git
> format-patch at work and git commit at home...

You can set the authorship of your latest commit with

  git --amend --author=[author]

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -