[Buildroot] [PATCH] system: add comment about busybox-show-others

[Buildroot] [PATCH] system: add comment about busybox-show-others

[Yann E. MORIN]

When the chosen init system is sysvinit, BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
is forcibly enabled.

This option looks like it is an option of the Busybox package, and thus
that it would not be available if Busybox is disabled (which can happen
when Busybox is not the init system).

Add a comment that explicitly states that BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
is also available when Busybox is not enabled.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Peter Korsgaard <peter@korsgaard.com>

---
Hopefully, this will avoid people to go hunting like I did, and loose a
few precious minutes of hair-pulling... ;-]
---
 system/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/system/Config.in b/system/Config.in
index 2e14971..1820029 100644
--- a/system/Config.in
+++ b/system/Config.in
@@ -74,6 +74,7 @@ config BR2_INIT_BUSYBOX
 
 config BR2_INIT_SYSV
 	bool "systemV"
+	# BR2_PACKAGE_BUSYBOX_SHOW_OTHERS exists even when Busybox is not enabled
 	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # sysvinit
 	select BR2_PACKAGE_INITSCRIPTS
 	select BR2_PACKAGE_SYSVINIT
-- 
2.7.4

[Buildroot] [PATCH] system: add comment about busybox-show-others

[Thomas Petazzoni]

Hello,

On Fri, 27 May 2016 22:34:51 +0200, Yann E. MORIN wrote:

>  config BR2_INIT_SYSV
>  	bool "systemV"
> +	# BR2_PACKAGE_BUSYBOX_SHOW_OTHERS exists even when Busybox is not enabled
>  	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # sysvinit

Well, I don't really see the point. You can perfectly well have Busybox
enabled *and* systemV as your init system.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] system: add comment about busybox-show-others

[Yann E. MORIN]

Thomas, All,

On 2016-05-27 22:50 +0200, Thomas Petazzoni spake thusly:
> On Fri, 27 May 2016 22:34:51 +0200, Yann E. MORIN wrote:
> 
> >  config BR2_INIT_SYSV
> >  	bool "systemV"
> > +	# BR2_PACKAGE_BUSYBOX_SHOW_OTHERS exists even when Busybox is not enabled
> >  	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # sysvinit
> 
> Well, I don't really see the point. You can perfectly well have Busybox
> enabled *and* systemV as your init system.

I'm not arguing that.

What was puzzling me is that BR2_PACKAGE_BUSYBOX_SHOW_OTHERS *appears*
to be a Busybox option.

Package options should not be selected before ensurign that the package
itself is enabled, so we have wither:

    select BR2_PACKAGE_FOO
    select BR2_PACKAGE_FOO_OPTION

or:

    depends on BR2_PACKAGE_FOO
    select BR2_PACKAGE_FOO_OPTION

or:

    select BR2_PACKAGE_FOO_OPTION if BR2_PACKAGE_FOO

However, for this specific option, it is *also* available when Busybox
is *not* enabled: it is not a package option.

So it is perfectly legit to select it without checking that Busybix
itself is enabled.

(Yes, I lost almost 10 minutes hunting that down...)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] system: add comment about busybox-show-others

[Thomas Petazzoni]

Hello,

On Fri, 27 May 2016 22:59:24 +0200, Yann E. MORIN wrote:

> What was puzzling me is that BR2_PACKAGE_BUSYBOX_SHOW_OTHERS *appears*
> to be a Busybox option.
> 
> Package options should not be selected before ensurign that the package
> itself is enabled, so we have wither:
> 
>     select BR2_PACKAGE_FOO
>     select BR2_PACKAGE_FOO_OPTION
> 
> or:
> 
>     depends on BR2_PACKAGE_FOO
>     select BR2_PACKAGE_FOO_OPTION
> 
> or:
> 
>     select BR2_PACKAGE_FOO_OPTION if BR2_PACKAGE_FOO
> 
> However, for this specific option, it is *also* available when Busybox
> is *not* enabled: it is not a package option.
> 
> So it is perfectly legit to select it without checking that Busybix
> itself is enabled.

Then change the code to:

	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS if BR2_PACKAGE_BUSYBOX

Indeed, when BR2_PACKAGE_BUSYBOX is disabled,
BR2_PACKAGE_BUSYBOX_SHOW_OTHERS is *always* set to 'y'.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] system: add comment about busybox-show-others

[Yann E. MORIN]

Thomas, All,

On 2016-05-27 23:10 +0200, Thomas Petazzoni spake thusly:
> On Fri, 27 May 2016 22:59:24 +0200, Yann E. MORIN wrote:
> > What was puzzling me is that BR2_PACKAGE_BUSYBOX_SHOW_OTHERS *appears*
> > to be a Busybox option.
[--SNIP--]
> > However, for this specific option, it is *also* available when Busybox
> > is *not* enabled: it is not a package option.
> > 
> > So it is perfectly legit to select it without checking that Busybix
> > itself is enabled.
> 
> Then change the code to:
> 
> 	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS if BR2_PACKAGE_BUSYBOX

That's what I initially did, but it looked weird to me.

But I'm fine with it if you prefer.

> Indeed, when BR2_PACKAGE_BUSYBOX is disabled,
> BR2_PACKAGE_BUSYBOX_SHOW_OTHERS is *always* set to 'y'.

Yes, and thus there is no need to select it...

Thanks!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'