Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/iptraf-ng: really add _GNU_SOURCE in CFLAGS
@ 2016-05-28 13:15 Romain Naour
  2016-05-28 13:52 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Romain Naour @ 2016-05-28 13:15 UTC (permalink / raw)
  To: buildroot

When iptraf-ng is build with musl, it needs _GNU_SOURCE in CFLAGS to define
the content of "struct tcphdr".

iptraf-ng.mk try to add _GNU_SOURCE in CFLAGS but it's not taken into account.

Add it using IPTRAF_NG_CONF_ENV instead of IPTRAF_NG_MAKE_ENV.

Fixes:
http://autobuild.buildroot.net/results/a1b/a1b18f2e3d075d349c19536a7c5553f24b75a323

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 package/iptraf-ng/iptraf-ng.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/iptraf-ng/iptraf-ng.mk b/package/iptraf-ng/iptraf-ng.mk
index ea64e1d..a36c708 100644
--- a/package/iptraf-ng/iptraf-ng.mk
+++ b/package/iptraf-ng/iptraf-ng.mk
@@ -11,7 +11,9 @@ IPTRAF_NG_LICENSE_FILES = LICENSE
 IPTRAF_NG_DEPENDENCIES = ncurses
 
 IPTRAF_NG_MAKE_ENV = \
-	NCURSES_LDFLAGS="-lpanel -lncurses" \
+	NCURSES_LDFLAGS="-lpanel -lncurses"
+
+IPTRAF_NG_CONF_ENV = \
 	CFLAGS="$(TARGET_CFLAGS) -D_GNU_SOURCE"
 
 $(eval $(autotools-package))
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] package/iptraf-ng: really add _GNU_SOURCE in CFLAGS
  2016-05-28 13:15 [Buildroot] [PATCH] package/iptraf-ng: really add _GNU_SOURCE in CFLAGS Romain Naour
@ 2016-05-28 13:52 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2016-05-28 13:52 UTC (permalink / raw)
  To: buildroot

Hello,

On Sat, 28 May 2016 15:15:52 +0200, Romain Naour wrote:
> When iptraf-ng is build with musl, it needs _GNU_SOURCE in CFLAGS to define
> the content of "struct tcphdr".
> 
> iptraf-ng.mk try to add _GNU_SOURCE in CFLAGS but it's not taken into account.
> 
> Add it using IPTRAF_NG_CONF_ENV instead of IPTRAF_NG_MAKE_ENV.
> 
> Fixes:
> http://autobuild.buildroot.net/results/a1b/a1b18f2e3d075d349c19536a7c5553f24b75a323
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
>  package/iptraf-ng/iptraf-ng.mk | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-05-28 13:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-28 13:15 [Buildroot] [PATCH] package/iptraf-ng: really add _GNU_SOURCE in CFLAGS Romain Naour
2016-05-28 13:52 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox