Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/ipsec-tools: disable for musl toolchains
Date: Sat, 28 May 2016 15:53:09 +0200	[thread overview]
Message-ID: <20160528155309.1f6ca34c@free-electrons.com> (raw)
In-Reply-To: <1464439649-27918-1-git-send-email-romain.naour@gmail.com>

Hello,

On Sat, 28 May 2016 14:47:29 +0200, Romain Naour wrote:
> __P() is used for compatibility with old K&R C compilers. With
> ANSI C this macro has no effect.
> 
> Unlike for util-linux and ipkg packages where it was easy to remove
> each __P() macro, ipsec-tools use it all over the tree and require a
> "big" patch to enable musl support.

Well, instead of removing the __P usage, we could also add a patch that
adds a dummy definition of __P.

But OK, ipsec-tools has been broken on musl for a while and nobody
proposed a proper fix, so let's mark it as not available on musl for
now. If someone cares in the future, it will also be time to re-enable
it on musl.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2016-05-28 13:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-28 12:47 [Buildroot] [PATCH] package/ipsec-tools: disable for musl toolchains Romain Naour
2016-05-28 13:53 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160528155309.1f6ca34c@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox