[Buildroot] [PATCH] package/ipsec-tools: disable for musl toolchains

[Buildroot] [PATCH] package/ipsec-tools: disable for musl toolchains

[Romain Naour]

__P() is used for compatibility with old K&R C compilers. With
ANSI C this macro has no effect.

Unlike for util-linux and ipkg packages where it was easy to remove
each __P() macro, ipsec-tools use it all over the tree and require a
"big" patch to enable musl support.

Since upstream seems not verry active (last release 2014-02-27)

So, disable ipsec-tools with musl based toolchains.

This fixes a compilation error with musl libc because of undeclared
__P.

Fixes:
http://autobuild.buildroot.net/results/42242e3f4485b9e77a916e6fe480c83f70e024e4

While at it, reorder "depends on" and "select" lines in Config.in

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 package/ipsec-tools/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/ipsec-tools/Config.in b/package/ipsec-tools/Config.in
index 4af4095..36c5a65 100644
--- a/package/ipsec-tools/Config.in
+++ b/package/ipsec-tools/Config.in
@@ -1,8 +1,9 @@
 config BR2_PACKAGE_IPSEC_TOOLS
 	bool "ipsec-tools"
+	depends on BR2_USE_MMU # fork()
+	depends on !BR2_TOOLCHAIN_USES_MUSL # Use __P() macro all over the tree
 	select BR2_PACKAGE_OPENSSL
 	select BR2_PACKAGE_FLEX
-	depends on BR2_USE_MMU # fork()
 	help
 	  This package is required to support IPSec for Linux 2.6+
 
-- 
2.5.5

[Buildroot] [PATCH] package/ipsec-tools: disable for musl toolchains

[Thomas Petazzoni]

Hello,

On Sat, 28 May 2016 14:47:29 +0200, Romain Naour wrote:
> __P() is used for compatibility with old K&R C compilers. With
> ANSI C this macro has no effect.
> 
> Unlike for util-linux and ipkg packages where it was easy to remove
> each __P() macro, ipsec-tools use it all over the tree and require a
> "big" patch to enable musl support.

Well, instead of removing the __P usage, we could also add a patch that
adds a dummy definition of __P.

But OK, ipsec-tools has been broken on musl for a while and nobody
proposed a proper fix, so let's mark it as not available on musl for
now. If someone cares in the future, it will also be time to re-enable
it on musl.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com