Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] build: fix umask test
Date: Tue, 31 May 2016 11:35:37 +0200	[thread overview]
Message-ID: <20160531093537.GD26685@airbook> (raw)
In-Reply-To: <87wpmazn0i.fsf@dell.be.48ers.dk>

> >>>>> "Kurt" == Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be> writes:
> 
>  >> > 
>  >> > I see, but how would that help when bash is not on the system?
>  >> > Is bash a prerequisite?
>  >> 
>  >> Yes, bash is a prerequisite. Some of our own scripts are bash scripts.
>  >> Moreover, quite a few packages just assume that the shell is bash. Requiring
>  >> bash and setting is as SHELL is the simplest way to handle that.
> 
>  > The Makefile only recommends /bin/bash, it falls back to 'sh' when bash
>  > is not present.
> 
> Yes, but support/dependencies/dependencies.sh checks for bash and bails
> out if not available.

I wasn't aware of this :-)

I already sent out a v2 of the patch which makes it shell-independant.

Kurt

  reply	other threads:[~2016-05-31  9:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-30  7:06 [Buildroot] [PATCH] build: fix umask test Kurt Van Dijck
2016-05-30  7:55 ` Peter Korsgaard
2016-05-30  8:05   ` Peter Korsgaard
2016-05-30  9:17     ` Thomas Petazzoni
2016-05-30  9:53       ` Kurt Van Dijck
2016-05-30  9:59         ` Peter Korsgaard
2016-05-30 21:09           ` Kurt Van Dijck
2016-05-30 21:31             ` Arnout Vandecappelle
2016-05-31  7:43               ` Kurt Van Dijck
2016-05-31  7:48                 ` Peter Korsgaard
2016-05-31  9:35                   ` Kurt Van Dijck [this message]
2016-05-30  9:56       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160531093537.GD26685@airbook \
    --to=dev.kurt@vandijck-laurijssen.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox