From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5] remmina: new package
Date: Tue, 31 May 2016 16:06:07 +0200 [thread overview]
Message-ID: <20160531160607.07fdfa74@free-electrons.com> (raw)
In-Reply-To: <1451750166-10049-1-git-send-email-fancp2007@gmail.com>
Hello Scott,
It's been a very long time since you posted this patch. It generally
looks good, but there's one thing that I don't really like.
On Sat, 2 Jan 2016 23:56:06 +0800, Scott Fan wrote:
> diff --git a/package/remmina/remmina.mk b/package/remmina/remmina.mk
> new file mode 100644
> index 0000000..8f333ae
> --- /dev/null
> +++ b/package/remmina/remmina.mk
> @@ -0,0 +1,36 @@
> +################################################################################
> +#
> +# remmina
> +#
> +################################################################################
> +
> +REMMINA_VERSION = e7f665f2634939aaa9bed114569cbd13eac10b82
> +REMMINA_SITE = $(call github,FreeRDP,Remmina,$(REMMINA_VERSION))
There has been new upstream releases since then, could you try to use a
more recent version? Also, we now add hash files for packages sourced
from Github, so it would be good to add one.
> +REMMINA_LICENSE = GPLv2+ with OpenSSL exception
> +REMMINA_LICENSE_FILES = COPYING LICENSE LICENSE.OpenSSL
> +
> +REMMINA_CONF_OPTS = \
> + -DWITH_AVAHI=OFF \
> + -DWITH_APPINDICATOR=OFF \
> + -DWITH_GNOMEKEYRING=OFF \
> + -DWITH_TELEPATHY=OFF \
> + -DWITH_GCRYPT=OFF \
> + -DWITH_LIBSSH=OFF \
> + -DWITH_VTE=OFF
> +
> +REMMINA_DEPENDENCIES = \
> + libgtk3 libvncserver freerdp \
> + xlib_libX11 xlib_libXext xlib_libxkbfile
> +
> +ifeq ($(BR2_NEEDS_GETTEXT),y)
> +REMMINA_DEPENDENCIES += gettext
> +
> +define REMMINA_POST_PATCH_FIXINTL
> + $(SED) 's/$${GTK_LIBRARIES}/$${GTK_LIBRARIES} -lintl/' \
> + $(@D)/remmina/CMakeLists.txt
> +endef
The thing I dislike is this hook. Could you instead work on changing
the CMakeLists.txt so that it links with -lintl when needed? This way,
it would be a solution that we can contribute upstream to the Remmina
developers.
I've added in Cc: to this e-mail Samuel Martin, who is our CMake expert
in the Buildroot community. Hopefully he can help you achieve this.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-05-31 14:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 14:36 [Buildroot] [PATCH v4] remmina: new package Scott Fan
2015-12-29 22:23 ` Thomas Petazzoni
2016-01-02 15:52 ` [Buildroot] [PATCH v5] Remmina is a remote desktop client written in GTK+. Currently RDP, VNC, NX, XDMCP and SSH are supported Scott Fan
2016-01-02 15:55 ` [Buildroot] [PATCH v5] remmina: new package Scott Fan
2016-01-02 15:56 ` Scott Fan
2016-05-31 14:06 ` Thomas Petazzoni [this message]
2016-06-03 1:05 ` Scott Fan
2016-06-06 21:38 ` Samuel Martin
2016-06-09 12:28 ` Scott Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531160607.07fdfa74@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox