* [Buildroot] [PATCH v4] remmina: new package
2015-09-01 14:36 [Buildroot] [PATCH v4] remmina: new package Scott Fan
@ 2015-12-29 22:23 ` Thomas Petazzoni
2016-01-02 15:52 ` [Buildroot] [PATCH v5] Remmina is a remote desktop client written in GTK+. Currently RDP, VNC, NX, XDMCP and SSH are supported Scott Fan
2016-01-02 15:56 ` Scott Fan
2 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2015-12-29 22:23 UTC (permalink / raw)
To: buildroot
Dear Scott Fan,
On Tue, 1 Sep 2015 22:36:14 +0800, Scott Fan wrote:
> Remmina is a remote desktop client written in GTK+.
> Currently RDP, VNC, NX, XDMCP and SSH are supported.
>
> http://remmina.sourceforge.net/
>
> Signed-off-by: Scott Fan <fancp2007@gmail.com>
It's been a long while, so I wanted to get back to your patch.
Unfortunately, it doesn't build properly:
-- Checking for module 'freerdp>=1.0'
-- Found freerdp, version 1.2.5-dev
CMake Error at /home/test/buildroot/output/host/usr/share/cmake-3.4/Modules/FindPackageHandleStandardArgs.cmake:148 (message):
Could NOT find FREERDP (missing: FREERDP_LIBRARY)
Call Stack (most recent call first):
/home/test/buildroot/output/host/usr/share/cmake-3.4/Modules/FindPackageHandleStandardArgs.cmake:388 (_FPHSA_FAILURE_MESSAGE)
cmake/FindFREERDP.cmake:47 (find_package_handle_standard_args)
cmake/FindOptionalPackage.cmake:37 (find_package)
remmina-plugins/CMakeLists.txt:59 (find_suggested_package)
It might be due to the fact that we updated freerdp in the mean time,
I'm not sure. You can reproduce this failure by building the following
configuration:
BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2015.11-rc1-71-g90d1299.tar.bz2"
BR2_TOOLCHAIN_EXTERNAL_GCC_4_7=y
BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_10=y
BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
BR2_TOOLCHAIN_EXTERNAL_INET_RPC=y
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_REMMINA=y
BR2_PACKAGE_XORG7=y
BR2_PACKAGE_LIBGTK3=y
# BR2_TARGET_ROOTFS_TAR is not set
> diff --git a/package/remmina/Config.in b/package/remmina/Config.in
> new file mode 100644
> index 0000000..e82f31b
> --- /dev/null
> +++ b/package/remmina/Config.in
> @@ -0,0 +1,28 @@
> +config BR2_PACKAGE_REMMINA
> + bool "remmina"
> + depends on BR2_PACKAGE_XORG7
> + depends on BR2_PACKAGE_LIBGTK3
Since you also select some X11 library, I guess this package will only
work with the X11 backend of GTK3, so presumably, you need:
depends on BR2_PACKAGE_LIBGTK3_X11
> + depends on BR2_USE_MMU # libvncserver depends on BR2_USE_MMU
> + depends on BR2_USE_WCHAR # freerdp
> + depends on !BR2_STATIC_LIBS # freerdp
> + depends on BR2_TOOLCHAIN_HAS_THREADS # freerdp
> + select BR2_PACKAGE_XLIB_LIBX11
> + select BR2_PACKAGE_XLIB_LIBXEXT
> + select BR2_PACKAGE_XLIB_LIBXKBFILE
> + select BR2_PACKAGE_LIBGCRYPT
> + select BR2_PACKAGE_LIBSSH
Is LIBSSH really mandatory? CMake says:
-- Finding suggested package LIBSSH.
-- Disable this using "-DWITH_LIBSSH=OFF".
> + select BR2_PACKAGE_LIBVNCSERVER
> + select BR2_PACKAGE_FREERDP
> + select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
Is gettext really mandatory ? CMake says:
-- Finding suggested package Gettext.
-- Disable this using "-DWITH_GETTEXT=OFF".
-- Found Gettext: /home/test/buildroot/output/host/usr/bin/msgmerge (found version "0.19.7")
> diff --git a/package/remmina/remmina.mk b/package/remmina/remmina.mk
> new file mode 100644
> index 0000000..0ac5fd0
> --- /dev/null
> +++ b/package/remmina/remmina.mk
> @@ -0,0 +1,34 @@
> +################################################################################
> +#
> +# remmina
> +#
> +################################################################################
> +
> +REMMINA_VERSION = v1.1.2
> +REMMINA_SITE = $(call github,FreeRDP,Remmina,$(REMMINA_VERSION))
We now would like to have hash files even for github sourced packages.
So if you could add a hash file, it would be good.
> +REMMINA_LICENSE = GPLv2+ with OpenSSL exception
> +REMMINA_LICENSE_FILES = COPYING LICENSE LICENSE.OpenSSL
> +
> +REMMINA_CONF_OPTS = \
> + -DWITH_AVAHI=OFF \
> + -DWITH_APPINDICATOR=OFF \
> + -DWITH_GNOMEKEYRING=OFF \
> + -DWITH_TELEPATHY=OFF \
> + -DWITH_VTE=OFF
> +
> +REMMINA_DEPENDENCIES = \
> + libgtk3 libgcrypt libssh libvncserver freerdp \
> + xlib_libX11 xlib_libXext xlib_libxkbfile
> +
> +ifeq ($(BR2_NEEDS_GETTEXT),y)
> +REMMINA_DEPENDENCIES += gettext
> +
> +define REMMINA_POST_PATCH_FIXINTL
> + $(SED) 's/$${GTK_LIBRARIES}/$${GTK_LIBRARIES} -lintl/' \
> + $(@D)/remmina/CMakeLists.txt
I think the package should rather use the FindIntl() function provided
by CMake, see https://cmake.org/cmake/help/v3.3/module/FindIntl.html,
by doing:
find_package(Intl)
This is probably something you can bring upstream to the Remmina
developers. In the mean time, we can live with the $(SED) hack you
proposed.
Could you rework the patch to address the various comments, and send an
updated version?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread* [Buildroot] [PATCH v5] Remmina is a remote desktop client written in GTK+. Currently RDP, VNC, NX, XDMCP and SSH are supported.
2015-09-01 14:36 [Buildroot] [PATCH v4] remmina: new package Scott Fan
2015-12-29 22:23 ` Thomas Petazzoni
@ 2016-01-02 15:52 ` Scott Fan
2016-01-02 15:55 ` [Buildroot] [PATCH v5] remmina: new package Scott Fan
2016-01-02 15:56 ` Scott Fan
2 siblings, 1 reply; 9+ messages in thread
From: Scott Fan @ 2016-01-02 15:52 UTC (permalink / raw)
To: buildroot
http://remmina.sourceforge.net/
Signed-off-by: Scott Fan <fancp2007@gmail.com>
---
Changes v4 -> v5:
1) rebase to master, select the latest 1.2.0 rcgit.7 release.
2) remove libssh dependency.
Changes v3 -> v4:
1) rebase to master
2) remove libssh patch which had merged to master
Changes v2 -> v3:
1) pick the first patch 'libssh' from the 'next' tree.
2) fix the dependencies of package remmina.
Changes v1 -> v2:
1) fix the dependencies of package remmina.
2) fix the license of package remmina.
3) wrap lines at 72 characters.
Signed-off-by: Scott Fan <fancp2007@gmail.com>
---
package/Config.in | 1 +
package/remmina/Config.in | 26 ++++++++++++++++++++++++++
package/remmina/remmina.mk | 36 ++++++++++++++++++++++++++++++++++++
3 files changed, 63 insertions(+)
create mode 100644 package/remmina/Config.in
create mode 100644 package/remmina/remmina.mk
diff --git a/package/Config.in b/package/Config.in
index f58f2be..ce3f75c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -256,6 +256,7 @@ endif
source "package/fbterm/Config.in"
source "package/fbv/Config.in"
source "package/freerdp/Config.in"
+ source "package/remmina/Config.in"
source "package/imagemagick/Config.in"
source "package/linux-fusion/Config.in"
source "package/lite/Config.in"
diff --git a/package/remmina/Config.in b/package/remmina/Config.in
new file mode 100644
index 0000000..78e9435
--- /dev/null
+++ b/package/remmina/Config.in
@@ -0,0 +1,26 @@
+config BR2_PACKAGE_REMMINA
+ bool "remmina"
+ depends on BR2_PACKAGE_XORG7
+ depends on BR2_PACKAGE_LIBGTK3
+ depends on BR2_USE_MMU # libvncserver depends on BR2_USE_MMU
+ depends on BR2_USE_WCHAR # freerdp
+ depends on !BR2_STATIC_LIBS # freerdp
+ depends on BR2_TOOLCHAIN_HAS_THREADS # freerdp
+ select BR2_PACKAGE_XLIB_LIBX11
+ select BR2_PACKAGE_XLIB_LIBXEXT
+ select BR2_PACKAGE_XLIB_LIBXKBFILE
+ select BR2_PACKAGE_LIBVNCSERVER
+ select BR2_PACKAGE_FREERDP
+ select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
+ help
+ Remmina is a remote desktop client written in GTK+, aiming to be
+ useful for system administrators and travellers, who need to work
+ with lots of remote computers in front of either large monitors
+ or tiny netbooks.
+
+ Remmina supports multiple network protocols in an integrated and
+ consistent user interface.
+
+ Currently RDP, VNC, NX, XDMCP and SSH are supported.
+
+ http://remmina.sourceforge.net/
diff --git a/package/remmina/remmina.mk b/package/remmina/remmina.mk
new file mode 100644
index 0000000..8f333ae
--- /dev/null
+++ b/package/remmina/remmina.mk
@@ -0,0 +1,36 @@
+################################################################################
+#
+# remmina
+#
+################################################################################
+
+REMMINA_VERSION = e7f665f2634939aaa9bed114569cbd13eac10b82
+REMMINA_SITE = $(call github,FreeRDP,Remmina,$(REMMINA_VERSION))
+REMMINA_LICENSE = GPLv2+ with OpenSSL exception
+REMMINA_LICENSE_FILES = COPYING LICENSE LICENSE.OpenSSL
+
+REMMINA_CONF_OPTS = \
+ -DWITH_AVAHI=OFF \
+ -DWITH_APPINDICATOR=OFF \
+ -DWITH_GNOMEKEYRING=OFF \
+ -DWITH_TELEPATHY=OFF \
+ -DWITH_GCRYPT=OFF \
+ -DWITH_LIBSSH=OFF \
+ -DWITH_VTE=OFF
+
+REMMINA_DEPENDENCIES = \
+ libgtk3 libvncserver freerdp \
+ xlib_libX11 xlib_libXext xlib_libxkbfile
+
+ifeq ($(BR2_NEEDS_GETTEXT),y)
+REMMINA_DEPENDENCIES += gettext
+
+define REMMINA_POST_PATCH_FIXINTL
+ $(SED) 's/$${GTK_LIBRARIES}/$${GTK_LIBRARIES} -lintl/' \
+ $(@D)/remmina/CMakeLists.txt
+endef
+
+REMMINA_POST_PATCH_HOOKS += REMMINA_POST_PATCH_FIXINTL
+endif
+
+$(eval $(cmake-package))
--
2.6.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Buildroot] [PATCH v5] remmina: new package
2016-01-02 15:52 ` [Buildroot] [PATCH v5] Remmina is a remote desktop client written in GTK+. Currently RDP, VNC, NX, XDMCP and SSH are supported Scott Fan
@ 2016-01-02 15:55 ` Scott Fan
0 siblings, 0 replies; 9+ messages in thread
From: Scott Fan @ 2016-01-02 15:55 UTC (permalink / raw)
To: buildroot
Remmina is a remote desktop client written in GTK+.
Currently RDP, VNC, NX, XDMCP and SSH are supported.
http://remmina.sourceforge.net/
Signed-off-by: Scott Fan <fancp2007@gmail.com>
---
Changes v4 -> v5:
1) rebase to master, select the latest 1.2.0 rcgit.7 release.
2) remove libssh dependency.
Changes v3 -> v4:
1) rebase to master
2) remove libssh patch which had merged to master
Changes v2 -> v3:
1) pick the first patch 'libssh' from the 'next' tree.
2) fix the dependencies of package remmina.
Changes v1 -> v2:
1) fix the dependencies of package remmina.
2) fix the license of package remmina.
3) wrap lines at 72 characters.
Signed-off-by: Scott Fan <fancp2007@gmail.com>
---
package/Config.in | 1 +
package/remmina/Config.in | 26 ++++++++++++++++++++++++++
package/remmina/remmina.mk | 36 ++++++++++++++++++++++++++++++++++++
3 files changed, 63 insertions(+)
create mode 100644 package/remmina/Config.in
create mode 100644 package/remmina/remmina.mk
diff --git a/package/Config.in b/package/Config.in
index f58f2be..ce3f75c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -256,6 +256,7 @@ endif
source "package/fbterm/Config.in"
source "package/fbv/Config.in"
source "package/freerdp/Config.in"
+ source "package/remmina/Config.in"
source "package/imagemagick/Config.in"
source "package/linux-fusion/Config.in"
source "package/lite/Config.in"
diff --git a/package/remmina/Config.in b/package/remmina/Config.in
new file mode 100644
index 0000000..78e9435
--- /dev/null
+++ b/package/remmina/Config.in
@@ -0,0 +1,26 @@
+config BR2_PACKAGE_REMMINA
+ bool "remmina"
+ depends on BR2_PACKAGE_XORG7
+ depends on BR2_PACKAGE_LIBGTK3
+ depends on BR2_USE_MMU # libvncserver depends on BR2_USE_MMU
+ depends on BR2_USE_WCHAR # freerdp
+ depends on !BR2_STATIC_LIBS # freerdp
+ depends on BR2_TOOLCHAIN_HAS_THREADS # freerdp
+ select BR2_PACKAGE_XLIB_LIBX11
+ select BR2_PACKAGE_XLIB_LIBXEXT
+ select BR2_PACKAGE_XLIB_LIBXKBFILE
+ select BR2_PACKAGE_LIBVNCSERVER
+ select BR2_PACKAGE_FREERDP
+ select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
+ help
+ Remmina is a remote desktop client written in GTK+, aiming to be
+ useful for system administrators and travellers, who need to work
+ with lots of remote computers in front of either large monitors
+ or tiny netbooks.
+
+ Remmina supports multiple network protocols in an integrated and
+ consistent user interface.
+
+ Currently RDP, VNC, NX, XDMCP and SSH are supported.
+
+ http://remmina.sourceforge.net/
diff --git a/package/remmina/remmina.mk b/package/remmina/remmina.mk
new file mode 100644
index 0000000..8f333ae
--- /dev/null
+++ b/package/remmina/remmina.mk
@@ -0,0 +1,36 @@
+################################################################################
+#
+# remmina
+#
+################################################################################
+
+REMMINA_VERSION = e7f665f2634939aaa9bed114569cbd13eac10b82
+REMMINA_SITE = $(call github,FreeRDP,Remmina,$(REMMINA_VERSION))
+REMMINA_LICENSE = GPLv2+ with OpenSSL exception
+REMMINA_LICENSE_FILES = COPYING LICENSE LICENSE.OpenSSL
+
+REMMINA_CONF_OPTS = \
+ -DWITH_AVAHI=OFF \
+ -DWITH_APPINDICATOR=OFF \
+ -DWITH_GNOMEKEYRING=OFF \
+ -DWITH_TELEPATHY=OFF \
+ -DWITH_GCRYPT=OFF \
+ -DWITH_LIBSSH=OFF \
+ -DWITH_VTE=OFF
+
+REMMINA_DEPENDENCIES = \
+ libgtk3 libvncserver freerdp \
+ xlib_libX11 xlib_libXext xlib_libxkbfile
+
+ifeq ($(BR2_NEEDS_GETTEXT),y)
+REMMINA_DEPENDENCIES += gettext
+
+define REMMINA_POST_PATCH_FIXINTL
+ $(SED) 's/$${GTK_LIBRARIES}/$${GTK_LIBRARIES} -lintl/' \
+ $(@D)/remmina/CMakeLists.txt
+endef
+
+REMMINA_POST_PATCH_HOOKS += REMMINA_POST_PATCH_FIXINTL
+endif
+
+$(eval $(cmake-package))
--
2.6.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v5] remmina: new package
2015-09-01 14:36 [Buildroot] [PATCH v4] remmina: new package Scott Fan
2015-12-29 22:23 ` Thomas Petazzoni
2016-01-02 15:52 ` [Buildroot] [PATCH v5] Remmina is a remote desktop client written in GTK+. Currently RDP, VNC, NX, XDMCP and SSH are supported Scott Fan
@ 2016-01-02 15:56 ` Scott Fan
2016-05-31 14:06 ` Thomas Petazzoni
2 siblings, 1 reply; 9+ messages in thread
From: Scott Fan @ 2016-01-02 15:56 UTC (permalink / raw)
To: buildroot
Remmina is a remote desktop client written in GTK+.
Currently RDP, VNC, NX, XDMCP and SSH are supported.
http://remmina.sourceforge.net/
Signed-off-by: Scott Fan <fancp2007@gmail.com>
---
Changes v4 -> v5:
1) rebase to master, select the latest 1.2.0 rcgit.7 release.
2) remove libssh dependency.
Changes v3 -> v4:
1) rebase to master
2) remove libssh patch which had merged to master
Changes v2 -> v3:
1) pick the first patch 'libssh' from the 'next' tree.
2) fix the dependencies of package remmina.
Changes v1 -> v2:
1) fix the dependencies of package remmina.
2) fix the license of package remmina.
3) wrap lines at 72 characters.
Signed-off-by: Scott Fan <fancp2007@gmail.com>
---
package/Config.in | 1 +
package/remmina/Config.in | 26 ++++++++++++++++++++++++++
package/remmina/remmina.mk | 36 ++++++++++++++++++++++++++++++++++++
3 files changed, 63 insertions(+)
create mode 100644 package/remmina/Config.in
create mode 100644 package/remmina/remmina.mk
diff --git a/package/Config.in b/package/Config.in
index f58f2be..ce3f75c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -256,6 +256,7 @@ endif
source "package/fbterm/Config.in"
source "package/fbv/Config.in"
source "package/freerdp/Config.in"
+ source "package/remmina/Config.in"
source "package/imagemagick/Config.in"
source "package/linux-fusion/Config.in"
source "package/lite/Config.in"
diff --git a/package/remmina/Config.in b/package/remmina/Config.in
new file mode 100644
index 0000000..78e9435
--- /dev/null
+++ b/package/remmina/Config.in
@@ -0,0 +1,26 @@
+config BR2_PACKAGE_REMMINA
+ bool "remmina"
+ depends on BR2_PACKAGE_XORG7
+ depends on BR2_PACKAGE_LIBGTK3
+ depends on BR2_USE_MMU # libvncserver depends on BR2_USE_MMU
+ depends on BR2_USE_WCHAR # freerdp
+ depends on !BR2_STATIC_LIBS # freerdp
+ depends on BR2_TOOLCHAIN_HAS_THREADS # freerdp
+ select BR2_PACKAGE_XLIB_LIBX11
+ select BR2_PACKAGE_XLIB_LIBXEXT
+ select BR2_PACKAGE_XLIB_LIBXKBFILE
+ select BR2_PACKAGE_LIBVNCSERVER
+ select BR2_PACKAGE_FREERDP
+ select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
+ help
+ Remmina is a remote desktop client written in GTK+, aiming to be
+ useful for system administrators and travellers, who need to work
+ with lots of remote computers in front of either large monitors
+ or tiny netbooks.
+
+ Remmina supports multiple network protocols in an integrated and
+ consistent user interface.
+
+ Currently RDP, VNC, NX, XDMCP and SSH are supported.
+
+ http://remmina.sourceforge.net/
diff --git a/package/remmina/remmina.mk b/package/remmina/remmina.mk
new file mode 100644
index 0000000..8f333ae
--- /dev/null
+++ b/package/remmina/remmina.mk
@@ -0,0 +1,36 @@
+################################################################################
+#
+# remmina
+#
+################################################################################
+
+REMMINA_VERSION = e7f665f2634939aaa9bed114569cbd13eac10b82
+REMMINA_SITE = $(call github,FreeRDP,Remmina,$(REMMINA_VERSION))
+REMMINA_LICENSE = GPLv2+ with OpenSSL exception
+REMMINA_LICENSE_FILES = COPYING LICENSE LICENSE.OpenSSL
+
+REMMINA_CONF_OPTS = \
+ -DWITH_AVAHI=OFF \
+ -DWITH_APPINDICATOR=OFF \
+ -DWITH_GNOMEKEYRING=OFF \
+ -DWITH_TELEPATHY=OFF \
+ -DWITH_GCRYPT=OFF \
+ -DWITH_LIBSSH=OFF \
+ -DWITH_VTE=OFF
+
+REMMINA_DEPENDENCIES = \
+ libgtk3 libvncserver freerdp \
+ xlib_libX11 xlib_libXext xlib_libxkbfile
+
+ifeq ($(BR2_NEEDS_GETTEXT),y)
+REMMINA_DEPENDENCIES += gettext
+
+define REMMINA_POST_PATCH_FIXINTL
+ $(SED) 's/$${GTK_LIBRARIES}/$${GTK_LIBRARIES} -lintl/' \
+ $(@D)/remmina/CMakeLists.txt
+endef
+
+REMMINA_POST_PATCH_HOOKS += REMMINA_POST_PATCH_FIXINTL
+endif
+
+$(eval $(cmake-package))
--
2.6.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Buildroot] [PATCH v5] remmina: new package
2016-01-02 15:56 ` Scott Fan
@ 2016-05-31 14:06 ` Thomas Petazzoni
2016-06-03 1:05 ` Scott Fan
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2016-05-31 14:06 UTC (permalink / raw)
To: buildroot
Hello Scott,
It's been a very long time since you posted this patch. It generally
looks good, but there's one thing that I don't really like.
On Sat, 2 Jan 2016 23:56:06 +0800, Scott Fan wrote:
> diff --git a/package/remmina/remmina.mk b/package/remmina/remmina.mk
> new file mode 100644
> index 0000000..8f333ae
> --- /dev/null
> +++ b/package/remmina/remmina.mk
> @@ -0,0 +1,36 @@
> +################################################################################
> +#
> +# remmina
> +#
> +################################################################################
> +
> +REMMINA_VERSION = e7f665f2634939aaa9bed114569cbd13eac10b82
> +REMMINA_SITE = $(call github,FreeRDP,Remmina,$(REMMINA_VERSION))
There has been new upstream releases since then, could you try to use a
more recent version? Also, we now add hash files for packages sourced
from Github, so it would be good to add one.
> +REMMINA_LICENSE = GPLv2+ with OpenSSL exception
> +REMMINA_LICENSE_FILES = COPYING LICENSE LICENSE.OpenSSL
> +
> +REMMINA_CONF_OPTS = \
> + -DWITH_AVAHI=OFF \
> + -DWITH_APPINDICATOR=OFF \
> + -DWITH_GNOMEKEYRING=OFF \
> + -DWITH_TELEPATHY=OFF \
> + -DWITH_GCRYPT=OFF \
> + -DWITH_LIBSSH=OFF \
> + -DWITH_VTE=OFF
> +
> +REMMINA_DEPENDENCIES = \
> + libgtk3 libvncserver freerdp \
> + xlib_libX11 xlib_libXext xlib_libxkbfile
> +
> +ifeq ($(BR2_NEEDS_GETTEXT),y)
> +REMMINA_DEPENDENCIES += gettext
> +
> +define REMMINA_POST_PATCH_FIXINTL
> + $(SED) 's/$${GTK_LIBRARIES}/$${GTK_LIBRARIES} -lintl/' \
> + $(@D)/remmina/CMakeLists.txt
> +endef
The thing I dislike is this hook. Could you instead work on changing
the CMakeLists.txt so that it links with -lintl when needed? This way,
it would be a solution that we can contribute upstream to the Remmina
developers.
I've added in Cc: to this e-mail Samuel Martin, who is our CMake expert
in the Buildroot community. Hopefully he can help you achieve this.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread* [Buildroot] [PATCH v5] remmina: new package
2016-05-31 14:06 ` Thomas Petazzoni
@ 2016-06-03 1:05 ` Scott Fan
2016-06-06 21:38 ` Samuel Martin
0 siblings, 1 reply; 9+ messages in thread
From: Scott Fan @ 2016-06-03 1:05 UTC (permalink / raw)
To: buildroot
Hello Thomas,
Thanks for your attention to this patch again.
I will follow up on it later.
Scott Fan
On Tue, May 31, 2016 at 10:06 PM, Thomas Petazzoni <
thomas.petazzoni@free-electrons.com> wrote:
> Hello Scott,
>
> It's been a very long time since you posted this patch. It generally
> looks good, but there's one thing that I don't really like.
>
> On Sat, 2 Jan 2016 23:56:06 +0800, Scott Fan wrote:
>
> > diff --git a/package/remmina/remmina.mk b/package/remmina/remmina.mk
> > new file mode 100644
> > index 0000000..8f333ae
> > --- /dev/null
> > +++ b/package/remmina/remmina.mk
> > @@ -0,0 +1,36 @@
> >
> +################################################################################
> > +#
> > +# remmina
> > +#
> >
> +################################################################################
> > +
> > +REMMINA_VERSION = e7f665f2634939aaa9bed114569cbd13eac10b82
> > +REMMINA_SITE = $(call github,FreeRDP,Remmina,$(REMMINA_VERSION))
>
> There has been new upstream releases since then, could you try to use a
> more recent version? Also, we now add hash files for packages sourced
> from Github, so it would be good to add one.
>
> > +REMMINA_LICENSE = GPLv2+ with OpenSSL exception
> > +REMMINA_LICENSE_FILES = COPYING LICENSE LICENSE.OpenSSL
> > +
> > +REMMINA_CONF_OPTS = \
> > + -DWITH_AVAHI=OFF \
> > + -DWITH_APPINDICATOR=OFF \
> > + -DWITH_GNOMEKEYRING=OFF \
> > + -DWITH_TELEPATHY=OFF \
> > + -DWITH_GCRYPT=OFF \
> > + -DWITH_LIBSSH=OFF \
> > + -DWITH_VTE=OFF
> > +
> > +REMMINA_DEPENDENCIES = \
> > + libgtk3 libvncserver freerdp \
> > + xlib_libX11 xlib_libXext xlib_libxkbfile
> > +
> > +ifeq ($(BR2_NEEDS_GETTEXT),y)
> > +REMMINA_DEPENDENCIES += gettext
> > +
> > +define REMMINA_POST_PATCH_FIXINTL
> > + $(SED) 's/$${GTK_LIBRARIES}/$${GTK_LIBRARIES} -lintl/' \
> > + $(@D)/remmina/CMakeLists.txt
> > +endef
>
> The thing I dislike is this hook. Could you instead work on changing
> the CMakeLists.txt so that it links with -lintl when needed? This way,
> it would be a solution that we can contribute upstream to the Remmina
> developers.
>
> I've added in Cc: to this e-mail Samuel Martin, who is our CMake expert
> in the Buildroot community. Hopefully he can help you achieve this.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160603/35c640e0/attachment.html>
^ permalink raw reply [flat|nested] 9+ messages in thread* [Buildroot] [PATCH v5] remmina: new package
2016-06-03 1:05 ` Scott Fan
@ 2016-06-06 21:38 ` Samuel Martin
2016-06-09 12:28 ` Scott Fan
0 siblings, 1 reply; 9+ messages in thread
From: Samuel Martin @ 2016-06-06 21:38 UTC (permalink / raw)
To: buildroot
Hi Scott, Thomas, all,
Sorry for the delayed answer.
On Fri, Jun 3, 2016 at 3:05 AM, Scott Fan <fancp2007@gmail.com> wrote:
> Hello Thomas,
>
> Thanks for your attention to this patch again.
> I will follow up on it later.
>
> Scott Fan
>
> On Tue, May 31, 2016 at 10:06 PM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
>>
>> Hello Scott,
>>
>> It's been a very long time since you posted this patch. It generally
>> looks good, but there's one thing that I don't really like.
>>
>> On Sat, 2 Jan 2016 23:56:06 +0800, Scott Fan wrote:
>>
>> > diff --git a/package/remmina/remmina.mk b/package/remmina/remmina.mk
>> > new file mode 100644
>> > index 0000000..8f333ae
>> > --- /dev/null
>> > +++ b/package/remmina/remmina.mk
>> > @@ -0,0 +1,36 @@
>> >
>> > +################################################################################
>> > +#
>> > +# remmina
>> > +#
>> >
>> > +################################################################################
>> > +
>> > +REMMINA_VERSION = e7f665f2634939aaa9bed114569cbd13eac10b82
>> > +REMMINA_SITE = $(call github,FreeRDP,Remmina,$(REMMINA_VERSION))
>>
>> There has been new upstream releases since then, could you try to use a
>> more recent version? Also, we now add hash files for packages sourced
>> from Github, so it would be good to add one.
Also, this particular revision seems not exist any more on this remote
(i cannot checkout it :-[)
>>
>> > +REMMINA_LICENSE = GPLv2+ with OpenSSL exception
>> > +REMMINA_LICENSE_FILES = COPYING LICENSE LICENSE.OpenSSL
>> > +
>> > +REMMINA_CONF_OPTS = \
>> > + -DWITH_AVAHI=OFF \
>> > + -DWITH_APPINDICATOR=OFF \
>> > + -DWITH_GNOMEKEYRING=OFF \
>> > + -DWITH_TELEPATHY=OFF \
>> > + -DWITH_GCRYPT=OFF \
>> > + -DWITH_LIBSSH=OFF \
>> > + -DWITH_VTE=OFF
>> > +
>> > +REMMINA_DEPENDENCIES = \
>> > + libgtk3 libvncserver freerdp \
>> > + xlib_libX11 xlib_libXext xlib_libxkbfile
>> > +
>> > +ifeq ($(BR2_NEEDS_GETTEXT),y)
>> > +REMMINA_DEPENDENCIES += gettext
>> > +
>> > +define REMMINA_POST_PATCH_FIXINTL
>> > + $(SED) 's/$${GTK_LIBRARIES}/$${GTK_LIBRARIES} -lintl/' \
>> > + $(@D)/remmina/CMakeLists.txt
>> > +endef
>>
>> The thing I dislike is this hook. Could you instead work on changing
>> the CMakeLists.txt so that it links with -lintl when needed? This way,
>> it would be a solution that we can contribute upstream to the Remmina
>> developers.
There is certainly a few things that could be done in the CMakeLists.txt:
- cmake provides a FindIntl.cmake module;
- the FindGTK*.cmake modules from Remmina use pkg_check_module
function, so if the corresponding *.pc already are correct, there may
be nothing to do ;)
- etc
Scott, if you have a more up-to-date patch, and possibly a defconfig
which triggers some issues because of the missing -lintl flag, it
would be nice to share them.
Thanks,
--
Samuel
^ permalink raw reply [flat|nested] 9+ messages in thread* [Buildroot] [PATCH v5] remmina: new package
2016-06-06 21:38 ` Samuel Martin
@ 2016-06-09 12:28 ` Scott Fan
0 siblings, 0 replies; 9+ messages in thread
From: Scott Fan @ 2016-06-09 12:28 UTC (permalink / raw)
To: buildroot
Hi Samuel, Thomas, all,
Scott Fan
On Tue, Jun 7, 2016 at 5:38 AM, Samuel Martin <s.martin49@gmail.com> wrote:
> Hi Scott, Thomas, all,
>
> Sorry for the delayed answer.
>
> On Fri, Jun 3, 2016 at 3:05 AM, Scott Fan <fancp2007@gmail.com> wrote:
> > Hello Thomas,
> >
> > Thanks for your attention to this patch again.
> > I will follow up on it later.
> >
> > Scott Fan
> >
> > On Tue, May 31, 2016 at 10:06 PM, Thomas Petazzoni
> > <thomas.petazzoni@free-electrons.com> wrote:
> >>
> >> Hello Scott,
> >>
> >> It's been a very long time since you posted this patch. It generally
> >> looks good, but there's one thing that I don't really like.
> >>
> >> On Sat, 2 Jan 2016 23:56:06 +0800, Scott Fan wrote:
> >>
> >> > diff --git a/package/remmina/remmina.mk b/package/remmina/remmina.mk
> >> > new file mode 100644
> >> > index 0000000..8f333ae
> >> > --- /dev/null
> >> > +++ b/package/remmina/remmina.mk
> >> > @@ -0,0 +1,36 @@
> >> >
> >> >
> +################################################################################
> >> > +#
> >> > +# remmina
> >> > +#
> >> >
> >> >
> +################################################################################
> >> > +
> >> > +REMMINA_VERSION = e7f665f2634939aaa9bed114569cbd13eac10b82
> >> > +REMMINA_SITE = $(call github,FreeRDP,Remmina,$(REMMINA_VERSION))
> >>
> >> There has been new upstream releases since then, could you try to use a
> >> more recent version? Also, we now add hash files for packages sourced
> >> from Github, so it would be good to add one.
>
> Also, this particular revision seems not exist any more on this remote
> (i cannot checkout it :-[)
>
> I've checked the commit e7f665f2634939aaa9bed114569cbd13eac10b82 again, it
even been the tag 1.2.0.rcgit.7, but it had been moved to another. Here is
the origin:
https://github.com/FreeRDP/Remmina/commit/e7f665f2634939aaa9bed114569cbd13eac10b82
I am trying to move the latest tag 1.2.0.rcgit.13
> >>
> >> > +REMMINA_LICENSE = GPLv2+ with OpenSSL exception
> >> > +REMMINA_LICENSE_FILES = COPYING LICENSE LICENSE.OpenSSL
> >> > +
> >> > +REMMINA_CONF_OPTS = \
> >> > + -DWITH_AVAHI=OFF \
> >> > + -DWITH_APPINDICATOR=OFF \
> >> > + -DWITH_GNOMEKEYRING=OFF \
> >> > + -DWITH_TELEPATHY=OFF \
> >> > + -DWITH_GCRYPT=OFF \
> >> > + -DWITH_LIBSSH=OFF \
> >> > + -DWITH_VTE=OFF
> >> > +
> >> > +REMMINA_DEPENDENCIES = \
> >> > + libgtk3 libvncserver freerdp \
> >> > + xlib_libX11 xlib_libXext xlib_libxkbfile
> >> > +
> >> > +ifeq ($(BR2_NEEDS_GETTEXT),y)
> >> > +REMMINA_DEPENDENCIES += gettext
> >> > +
> >> > +define REMMINA_POST_PATCH_FIXINTL
> >> > + $(SED) 's/$${GTK_LIBRARIES}/$${GTK_LIBRARIES} -lintl/' \
> >> > + $(@D)/remmina/CMakeLists.txt
> >> > +endef
> >>
> >> The thing I dislike is this hook. Could you instead work on changing
> >> the CMakeLists.txt so that it links with -lintl when needed? This way,
> >> it would be a solution that we can contribute upstream to the Remmina
> >> developers.
>
> There is certainly a few things that could be done in the CMakeLists.txt:
> - cmake provides a FindIntl.cmake module;
> - the FindGTK*.cmake modules from Remmina use pkg_check_module
> function, so if the corresponding *.pc already are correct, there may
> be nothing to do ;)
> - etc
>
> Scott, if you have a more up-to-date patch, and possibly a defconfig
> which triggers some issues because of the missing -lintl flag, it
> would be nice to share them.
>
> Thanks,
>
>
> --
> Samuel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160609/8dace1ed/attachment.html>
^ permalink raw reply [flat|nested] 9+ messages in thread