From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] fmlib: add powerpc e6500 support
Date: Sun, 12 Jun 2016 22:21:36 +0200 [thread overview]
Message-ID: <20160612222136.4403ea28@free-electrons.com> (raw)
In-Reply-To: <1463578886-43470-2-git-send-email-matthew.weber@rockwellcollins.com>
Hello,
On Wed, 18 May 2016 08:41:26 -0500, Matt Weber wrote:
> Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
> Signed-off-by: Ronak Desai <ronak.desai@rockwellcollins.com>
Why is this patch 2/2, when it is in fact a dependency of patch 1/2 ?
Patch 1/2 uses FMLIB_PLATFORM, which doesn't exist until patch 2/2 is
merged.
> +if BR2_PACKAGE_FMLIB
> +choice
> + prompt "QORIQ Target Family"
The correct spelling is QorIQ according to Freescale's website.
> diff --git a/package/fmlib/fmlib.mk b/package/fmlib/fmlib.mk
> index 978810b..5655608 100644
> --- a/package/fmlib/fmlib.mk
> +++ b/package/fmlib/fmlib.mk
> @@ -25,11 +25,17 @@ ifeq ($(BR2_powerpc_e500mc),y)
> FMLIB_ARCHTYPE = ppce500mc
So you're keeping the old definition of FMLIB_ARCHTYPE...
> endif
>
> +FMLIB_ARCHTYPE = $(call qstrip,$(BR2_PACKAGE_FMLIB_ARCHTYPE))
... and defining it again.
I've merged, after fixing those issues.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-06-12 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 13:41 [Buildroot] [PATCH v2 1/2] fmc: added powerpc e6500 support Matt Weber
2016-05-18 13:41 ` [Buildroot] [PATCH v2 2/2] fmlib: add " Matt Weber
2016-06-12 20:21 ` Thomas Petazzoni [this message]
2016-06-12 20:25 ` [Buildroot] [PATCH v2 1/2] fmc: added " Thomas Petazzoni
2016-06-13 14:37 ` Matthew Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160612222136.4403ea28@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox