Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] fmc: added powerpc e6500 support
Date: Sun, 12 Jun 2016 22:25:38 +0200	[thread overview]
Message-ID: <20160612222538.762fd49b@free-electrons.com> (raw)
In-Reply-To: <1463578886-43470-1-git-send-email-matthew.weber@rockwellcollins.com>

Hello,

On Wed, 18 May 2016 08:41:25 -0500, Matt Weber wrote:

> @@ -18,7 +19,12 @@ FMC_MAKE_OPTS = \
>  	LIBXML2_HEADER_PATH="$(STAGING_DIR)/usr/include/libxml2" \
>  	TCLAP_HEADER_PATH="$(STAGING_DIR)/usr/include"
>  
> +ifeq ($(BR2_powerpc64),y)
> +	FMC_MAKE_OPTS += M64BIT=1

We don't indent such definitions, so I've removed the tab here.

> +endif
> +
>  define FMC_BUILD_CMDS
> +	$(SED) "s:P4080:$(FMLIB_PLATFORM):g" $(@D)/source/Makefile

I don't like when accessing variables defined by other packages, so
I've instead defined FMC_PLATFORM, which re-calculates the value from
BR2_PACKAGE_FMLIB_PLATFORM.

Applied with those two minor things changed.

Don't hesitate to make a build test again to make sure everything is
still working fine.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2016-06-12 20:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-18 13:41 [Buildroot] [PATCH v2 1/2] fmc: added powerpc e6500 support Matt Weber
2016-05-18 13:41 ` [Buildroot] [PATCH v2 2/2] fmlib: add " Matt Weber
2016-06-12 20:21   ` Thomas Petazzoni
2016-06-12 20:25 ` Thomas Petazzoni [this message]
2016-06-13 14:37   ` [Buildroot] [PATCH v2 1/2] fmc: added " Matthew Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160612222538.762fd49b@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox