From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] efivar: new package
Date: Tue, 21 Jun 2016 17:51:28 +0200 [thread overview]
Message-ID: <20160621175128.2db7e559@free-electrons.com> (raw)
In-Reply-To: <57696022.2060308@imgtec.com>
Hello,
On Tue, 21 Jun 2016 16:41:22 +0100, Vicente Olivert Riera wrote:
> > +comment "efivar requires an (e)glibc toolchain w/ headers >= 3.12"
> > + depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 || \
> > + !BR2_TOOLCHAIN_USES_GLIBC
>
> shouldn't be
>
> comment "efivar requires an (e)glibc toolchain w/ headers >= 3.12"
> depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 || \
> BR2_TOOLCHAIN_USES_GLIBC
>
> ...?
>
> The package is only compatible with glibc, so it depends on it. The
> comment should depend on it as well.
No, we precisely want to display the comment when the user is *NOT*
using glibc, to inform him that the package is not available because he
is not using glibc.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-06-21 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-12 13:59 [Buildroot] [git commit] efivar: new package Thomas Petazzoni
2016-06-21 15:41 ` Vicente Olivert Riera
2016-06-21 15:51 ` Thomas Petazzoni [this message]
2016-06-21 16:02 ` Vicente Olivert Riera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621175128.2db7e559@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox