From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] efivar: new package
Date: Tue, 21 Jun 2016 17:02:19 +0100 [thread overview]
Message-ID: <5769650B.6080604@imgtec.com> (raw)
In-Reply-To: <20160621175128.2db7e559@free-electrons.com>
On 21/06/16 16:51, Thomas Petazzoni wrote:
> Hello,
>
> On Tue, 21 Jun 2016 16:41:22 +0100, Vicente Olivert Riera wrote:
>
>>> +comment "efivar requires an (e)glibc toolchain w/ headers >= 3.12"
>>> + depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 || \
>>> + !BR2_TOOLCHAIN_USES_GLIBC
>>
>> shouldn't be
>>
>> comment "efivar requires an (e)glibc toolchain w/ headers >= 3.12"
>> depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 || \
>> BR2_TOOLCHAIN_USES_GLIBC
>>
>> ...?
>>
>> The package is only compatible with glibc, so it depends on it. The
>> comment should depend on it as well.
>
> No, we precisely want to display the comment when the user is *NOT*
> using glibc, to inform him that the package is not available because he
> is not using glibc.
<facepalm>
of course, sorry for the noise.
Regards,
Vincent.
> Thomas
>
prev parent reply other threads:[~2016-06-21 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-12 13:59 [Buildroot] [git commit] efivar: new package Thomas Petazzoni
2016-06-21 15:41 ` Vicente Olivert Riera
2016-06-21 15:51 ` Thomas Petazzoni
2016-06-21 16:02 ` Vicente Olivert Riera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5769650B.6080604@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox