Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/6] libsepol: bump to version 2.5
Date: Fri, 24 Jun 2016 09:36:01 +0200	[thread overview]
Message-ID: <20160624093601.1b6a9b3e@free-electrons.com> (raw)
In-Reply-To: <1466736201-17310-4-git-send-email-Aduskett@gmail.com>

Hello,

Glad to see that there are some people interested by SELinux support!
We still have lots of pending patches about SELinux, especially the
one adding the refpolicy package. See
http://patchwork.ozlabs.org/project/buildroot/list/?submitter=&state=&q=selinux&archive=&delegate=.

Some comments below though.

On Thu, 23 Jun 2016 22:43:19 -0400, Adam Duskett wrote:
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
>  package/libsepol/0001-support-static-only.patch    | 17 +++++++++--------
>  .../libsepol/0002-workaround-blackfin-issue.patch  | 22 ++++++----------------

It would be good if you could indicate in the commit log what is
changed in the patches. Indeed, there are some strange changes that
you're doing.

>  package/libsepol/libsepol.hash                     |  2 +-
>  package/libsepol/libsepol.mk                       |  4 ++--
>  4 files changed, 18 insertions(+), 27 deletions(-)
> 
> diff --git a/package/libsepol/0001-support-static-only.patch b/package/libsepol/0001-support-static-only.patch
> index b974680..6d30454 100644
> --- a/package/libsepol/0001-support-static-only.patch
> +++ b/package/libsepol/0001-support-static-only.patch
> @@ -6,15 +6,16 @@ when defined to some non-empty value, will disable the build of shared
>  libraries. It allows to support cases where the target architecture
>  does not have support for shared libraries.
>  
> -Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> -

Why are you removing this?

> diff --git a/package/libsepol/0002-workaround-blackfin-issue.patch b/package/libsepol/0002-workaround-blackfin-issue.patch
> index 5d00c69..237c06a 100644
> --- a/package/libsepol/0002-workaround-blackfin-issue.patch
> +++ b/package/libsepol/0002-workaround-blackfin-issue.patch
> @@ -1,24 +1,14 @@
> -Do not make symbols hidden on Blackfin
> -
> -The libselinux logic to hide internal symbols from the DSO doesn't
> -work properly on Blackfin due to the USER_LABEL_PREFIX not being
> -handled properly. A real fix is not that simple, so this patch simply
> -disables the internal symbol hiding mechanism. This means that those
> -symbols are visible in the final DSO, which is not a problem for
> -proper execution, it just isn't as clean.
> -
> -Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> -

And why are you removing this ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-06-24  7:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24  2:43 [Buildroot] [PATCH 1/1] Add libselinux and libsepol dependency for SELinux support Adam Duskett
2016-06-24  2:43 ` [Buildroot] [PATCH 2/6] Audit: bump to version 2.5.2 Adam Duskett
2016-06-24  2:43 ` [Buildroot] [PATCH 3/6] checkpolicy: bump to version 2.5 Adam Duskett
2016-06-24  2:43 ` [Buildroot] [PATCH 4/6] libsepol: " Adam Duskett
2016-06-24  7:36   ` Thomas Petazzoni [this message]
2016-06-24  2:43 ` [Buildroot] [PATCH 5/6] libselinux: " Adam Duskett
2016-06-24  7:38   ` Thomas Petazzoni
2016-06-24  2:43 ` [Buildroot] [PATCH 6/6] libsemanage: " Adam Duskett
2016-06-24  8:02   ` Thomas Petazzoni
2016-06-24  7:46 ` [Buildroot] [PATCH 1/1] Add libselinux and libsepol dependency for SELinux support Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160624093601.1b6a9b3e@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox