From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Add libselinux and libsepol dependency for SELinux support.
Date: Fri, 24 Jun 2016 09:46:24 +0200 [thread overview]
Message-ID: <20160624094624.3fcf1575@free-electrons.com> (raw)
In-Reply-To: <1466736201-17310-1-git-send-email-Aduskett@gmail.com>
Hello,
The title should always contain the package being affected by the
change. I.e, it should be of the form:
<package>: <description>
In your case:
busybox: ...
On Thu, 23 Jun 2016 22:43:16 -0400, Adam Duskett wrote:
> config BR2_PACKAGE_BUSYBOX_SELINUX
> - select BR2_PACKAGE_LIBSELINUX
> + depends on BR2_PACKAGE_LIBSELINUX
Why are you doing this? A select is what's appropriate.
> + depends on BR2_PACKAGE_LIBSEPOL
Why are you adding this? libselinux already selects libsepol, so when
you have libselinux, you have libsepol.
Therefore, this patch looks bogus :-/
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-06-24 7:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 2:43 [Buildroot] [PATCH 1/1] Add libselinux and libsepol dependency for SELinux support Adam Duskett
2016-06-24 2:43 ` [Buildroot] [PATCH 2/6] Audit: bump to version 2.5.2 Adam Duskett
2016-06-24 2:43 ` [Buildroot] [PATCH 3/6] checkpolicy: bump to version 2.5 Adam Duskett
2016-06-24 2:43 ` [Buildroot] [PATCH 4/6] libsepol: " Adam Duskett
2016-06-24 7:36 ` Thomas Petazzoni
2016-06-24 2:43 ` [Buildroot] [PATCH 5/6] libselinux: " Adam Duskett
2016-06-24 7:38 ` Thomas Petazzoni
2016-06-24 2:43 ` [Buildroot] [PATCH 6/6] libsemanage: " Adam Duskett
2016-06-24 8:02 ` Thomas Petazzoni
2016-06-24 7:46 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624094624.3fcf1575@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox