Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] fs/tar: support passing long options to tar
@ 2016-06-24 15:57 Frank Hunleth
  2016-06-25 13:42 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Frank Hunleth @ 2016-06-24 15:57 UTC (permalink / raw)
  To: buildroot

Move TAR_OPTS so that long options (or any option with an initial '-')
may be passed to tar. Since TAR_OPTS is at the front of the list, single
letter options still work.

Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com>
---
Changes v1 -> v2:
  - Move TAR_OPTS to front to preserve backward compatibility
    (suggested by Arnout)
  - Removed additional help text since no backward compatibility issues
    were introduced.

 fs/tar/tar.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/tar/tar.mk b/fs/tar/tar.mk
index 28219cf..11c69c5 100644
--- a/fs/tar/tar.mk
+++ b/fs/tar/tar.mk
@@ -7,7 +7,7 @@
 TAR_OPTS := $(call qstrip,$(BR2_TARGET_ROOTFS_TAR_OPTIONS))

 define ROOTFS_TAR_CMD
-	tar -c$(TAR_OPTS)f $@ --numeric-owner -C $(TARGET_DIR) .
+	tar $(TAR_OPTS) -cf $@ --numeric-owner -C $(TARGET_DIR) .
 endef

 $(eval $(call ROOTFS_TARGET,tar))
--
2.5.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH v2] fs/tar: support passing long options to tar
  2016-06-24 15:57 [Buildroot] [PATCH v2] fs/tar: support passing long options to tar Frank Hunleth
@ 2016-06-25 13:42 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2016-06-25 13:42 UTC (permalink / raw)
  To: buildroot

Hello,

On Fri, 24 Jun 2016 11:57:56 -0400, Frank Hunleth wrote:
> Move TAR_OPTS so that long options (or any option with an initial '-')
> may be passed to tar. Since TAR_OPTS is at the front of the list, single
> letter options still work.
> 
> Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com>
> ---
> Changes v1 -> v2:
>   - Move TAR_OPTS to front to preserve backward compatibility
>     (suggested by Arnout)
>   - Removed additional help text since no backward compatibility issues
>     were introduced.

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-25 13:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-24 15:57 [Buildroot] [PATCH v2] fs/tar: support passing long options to tar Frank Hunleth
2016-06-25 13:42 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox