* [Buildroot] 3 patches to buildroot via git send-email
@ 2016-06-26 3:20 Peter Thompson
2016-06-26 3:36 ` Baruch Siach
2016-06-26 12:48 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Peter Thompson @ 2016-06-26 3:20 UTC (permalink / raw)
To: buildroot
I submitted 3 patches to buildroot via git send-email got sdl2_ttf,
sdl2_image, sdl2_gfx. I hope they arrived properly. If not, please
let me know. Below are my personal notes I used to make the submission.
Peter
------------------- submit patch to Buildroot --------------
see https://buildroot.org/downloads/manual/manual.html#submitting-patches
see http://free-electrons.com/~thomas/buildroot/manual/html/ch02.html
Step 1 - Git buildroot from github
----------------------------------
mkdir ~/Documents/git/buildroot/
cd ~/Documents/git/buildroot/
git clone git://git.buildroot.net/buildroot
cd ~/Documents/git/buildroot/buildroot/
git status
git branch -a
git remote -v
git remote show origin
Step 2 - create 3 branches (1 per patch)
-----------------------------------------
git checkout master # recheck original
git branch sdl2_gfx
git branch sdl2_image
git branch sdl2_ttf
git branch -a #
Step 3 - create patch, test, submit
-----------------------------------------
git checkout sdl2_image #make changes see 09xpeterBuildrootPatchREADME
git add package/sdl2_image/Config.in # p17-19 git pro book
git add package/sdl2_image/sdl2_image.mk
git add package/Config.in
git add -A # adds all files - don't use here...
git status # make sure you know what you are commiting
git commit -as # -as=all modified files with signoff
rm *~ # get rid of junk
submit via
https://buildroot.org/downloads/manual/manual.html#submitting-patches
$ git fetch --all --tags # update with latest buildroot version
$ git rebase origin/master # redo my commits on latest buildroot version
$ git format-patch -M -n -s -o outgoing origin/master #format and send it
$ git send-email --to buildroot at buildroot.org outgoing/*
repeat Step 3 for all sdl2-gfx, sdl2_image, sdl2_ttf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160625/1c0f14dc/attachment.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] 3 patches to buildroot via git send-email
2016-06-26 3:20 [Buildroot] 3 patches to buildroot via git send-email Peter Thompson
@ 2016-06-26 3:36 ` Baruch Siach
2016-06-26 12:47 ` Thomas Petazzoni
2016-06-26 12:48 ` Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2016-06-26 3:36 UTC (permalink / raw)
To: buildroot
Hi Peter,
On Sat, Jun 25, 2016 at 09:20:04PM -0600, Peter Thompson wrote:
> I submitted 3 patches to buildroot via git send-email got sdl2_ttf,
> sdl2_image, sdl2_gfx. I hope they arrived properly. If not, please
> let me know. Below are my personal notes I used to make the submission.
They all arrived. You can see them in the list archive at:
http://lists.busybox.net/pipermail/buildroot/2016-June/165082.html
http://lists.busybox.net/pipermail/buildroot/2016-June/165083.html
http://lists.busybox.net/pipermail/buildroot/2016-June/165084.html
The subject line for all these patches is wrong, though. It should be e.g.:
sdl2_ttf: new package
The first line of your git commit log becomes the subject line when you
generate an email with 'git format-patch'.
Hope this helps,
baruch
> ------------------- submit patch to Buildroot --------------
> see https://buildroot.org/downloads/manual/manual.html#submitting-patches
> see http://free-electrons.com/~thomas/buildroot/manual/html/ch02.html
>
> Step 1 - Git buildroot from github
> ----------------------------------
> mkdir ~/Documents/git/buildroot/
> cd ~/Documents/git/buildroot/
> git clone git://git.buildroot.net/buildroot
>
> cd ~/Documents/git/buildroot/buildroot/
> git status
> git branch -a
> git remote -v
> git remote show origin
>
>
> Step 2 - create 3 branches (1 per patch)
> -----------------------------------------
> git checkout master # recheck original
> git branch sdl2_gfx
> git branch sdl2_image
> git branch sdl2_ttf
> git branch -a #
>
>
> Step 3 - create patch, test, submit
> -----------------------------------------
> git checkout sdl2_image #make changes see 09xpeterBuildrootPatchREADME
> git add package/sdl2_image/Config.in # p17-19 git pro book
> git add package/sdl2_image/sdl2_image.mk
> git add package/Config.in
> git add -A # adds all files - don't use here...
> git status # make sure you know what you are commiting
> git commit -as # -as=all modified files with signoff
> rm *~ # get rid of junk
>
>
> submit via
> https://buildroot.org/downloads/manual/manual.html#submitting-patches
> $ git fetch --all --tags # update with latest buildroot version
> $ git rebase origin/master # redo my commits on latest buildroot version
> $ git format-patch -M -n -s -o outgoing origin/master #format and send it
> $ git send-email --to buildroot at buildroot.org outgoing/*
>
> repeat Step 3 for all sdl2-gfx, sdl2_image, sdl2_ttf
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] 3 patches to buildroot via git send-email
2016-06-26 3:36 ` Baruch Siach
@ 2016-06-26 12:47 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2016-06-26 12:47 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 26 Jun 2016 06:36:43 +0300, Baruch Siach wrote:
> On Sat, Jun 25, 2016 at 09:20:04PM -0600, Peter Thompson wrote:
> > I submitted 3 patches to buildroot via git send-email got sdl2_ttf,
> > sdl2_image, sdl2_gfx. I hope they arrived properly. If not, please
> > let me know. Below are my personal notes I used to make the submission.
>
> They all arrived. You can see them in the list archive at:
>
> http://lists.busybox.net/pipermail/buildroot/2016-June/165082.html
> http://lists.busybox.net/pipermail/buildroot/2016-June/165083.html
> http://lists.busybox.net/pipermail/buildroot/2016-June/165084.html
Well, they did not really arrive properly, since we received three
times patches for sdl2_ttf, and not patches for sdl2_image and sdl2_gfx.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] 3 patches to buildroot via git send-email
2016-06-26 3:20 [Buildroot] 3 patches to buildroot via git send-email Peter Thompson
2016-06-26 3:36 ` Baruch Siach
@ 2016-06-26 12:48 ` Thomas Petazzoni
2016-06-26 20:22 ` Arnout Vandecappelle
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2016-06-26 12:48 UTC (permalink / raw)
To: buildroot
Hello,
As I mentioned, we received 3 times the same patch, for sdl2_ttf. And
as Baruch noted, the commit title was wrong.
On Sat, 25 Jun 2016 21:20:04 -0600, Peter Thompson wrote:
> Step 2 - create 3 branches (1 per patch)
Don't do this. Create one branch only, with one commit per package.
> submit via
> https://buildroot.org/downloads/manual/manual.html#submitting-patches
> $ git fetch --all --tags # update with latest buildroot version
> $ git rebase origin/master # redo my commits on latest buildroot version
> $ git format-patch -M -n -s -o outgoing origin/master #format and send it
> $ git send-email --to buildroot at buildroot.org outgoing/*
Please send the patches to you first, in order to check that they look
good.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] 3 patches to buildroot via git send-email
2016-06-26 12:48 ` Thomas Petazzoni
@ 2016-06-26 20:22 ` Arnout Vandecappelle
2016-06-27 4:42 ` Peter Thompson
0 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2016-06-26 20:22 UTC (permalink / raw)
To: buildroot
On 26-06-16 14:48, Thomas Petazzoni wrote:
> Hello,
>
> As I mentioned, we received 3 times the same patch, for sdl2_ttf. And
> as Baruch noted, the commit title was wrong.
>
> On Sat, 25 Jun 2016 21:20:04 -0600, Peter Thompson wrote:
>
>> > Step 2 - create 3 branches (1 per patch)
> Don't do this. Create one branch only, with one commit per package.
>
>> > submit via
>> > https://buildroot.org/downloads/manual/manual.html#submitting-patches
>> > $ git fetch --all --tags # update with latest buildroot version
>> > $ git rebase origin/master # redo my commits on latest buildroot version
>> > $ git format-patch -M -n -s -o outgoing origin/master #format and send it
>> > $ git send-email --to buildroot at buildroot.org outgoing/*
> Please send the patches to you first, in order to check that they look
> good.
The sending is clearly no problem. It is a good idea however to review the
patches in outgoing/* before sending out.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] 3 patches to buildroot via git send-email
2016-06-26 20:22 ` Arnout Vandecappelle
@ 2016-06-27 4:42 ` Peter Thompson
0 siblings, 0 replies; 6+ messages in thread
From: Peter Thompson @ 2016-06-27 4:42 UTC (permalink / raw)
To: buildroot
Thanks to all of you for all your help and feedback. It is appreciated.
I will fix them and re-submit. My apologies for submitting
prematurely.
Peter
On Sun, Jun 26, 2016 at 2:22 PM, Arnout Vandecappelle <arnout@mind.be>
wrote:
> On 26-06-16 14:48, Thomas Petazzoni wrote:
> > Hello,
> >
> > As I mentioned, we received 3 times the same patch, for sdl2_ttf. And
> > as Baruch noted, the commit title was wrong.
> >
> > On Sat, 25 Jun 2016 21:20:04 -0600, Peter Thompson wrote:
> >
> >> > Step 2 - create 3 branches (1 per patch)
> > Don't do this. Create one branch only, with one commit per package.
> >
> >> > submit via
> >> > https://buildroot.org/downloads/manual/manual.html#submitting-patches
> >> > $ git fetch --all --tags # update with latest buildroot version
> >> > $ git rebase origin/master # redo my commits on latest buildroot
> version
> >> > $ git format-patch -M -n -s -o outgoing origin/master #format and
> send it
> >> > $ git send-email --to buildroot at buildroot.org outgoing/*
> > Please send the patches to you first, in order to check that they look
> > good.
>
> The sending is clearly no problem. It is a good idea however to review the
> patches in outgoing/* before sending out.
>
> Regards,
> Arnout
>
> --
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286500
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160626/5abd7b1e/attachment.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-27 4:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-26 3:20 [Buildroot] 3 patches to buildroot via git send-email Peter Thompson
2016-06-26 3:36 ` Baruch Siach
2016-06-26 12:47 ` Thomas Petazzoni
2016-06-26 12:48 ` Thomas Petazzoni
2016-06-26 20:22 ` Arnout Vandecappelle
2016-06-27 4:42 ` Peter Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox