Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Reiserfsprogs
Date: Wed, 29 Jun 2016 12:04:22 +0200	[thread overview]
Message-ID: <20160629120422.5d17355b@free-electrons.com> (raw)
In-Reply-To: <F9C551623D2CBB4C9488801D14F864C6EE831CFF@ex-mb1.corp.adtran.com>

Hello,

On Tue, 28 Jun 2016 19:49:22 +0000, ANDY KENNEDY wrote:

> What was the formatting problem?  I'm not using git to do the formatting,
> but a side-by-side diff of the directories.  Also, doesn't git send-email
> require direct access to SMTP from the workstation?  I don't have that.
> 
> And, if you want the absolute truth of the matter, I'm not a git user
> and struggle with using it (so, pointers for the "right way" would
> not be taken as patronizing -- I'm okay with spoon feeding).

It just didn't appear as a Git formatted patch. You should really spend
a little bit of time learning git format-patch / send-email, you'll
save a lot of time down the road if you use the proper workflow.

Yes, "git send-email" requires a SMTP server, but if you have a GMail
account, then you have a SMTP server available.

> > > +REISERFSPROGS_LICENSE_FILES = COPYING README
> > > +REISERFSPROGS_CONF_ENV = LIBS='-lcom_err -luuid -lpthread -lrt'  
> > 
> > This line is not needed.  
> 
> What is the preferred way to make those LDFLAGS go through?
> I have tried it multiple ways and could only make it work
> using the LIBS=... for the configure env.  Without this
> line, reiserfsprogs doesn't build.

It build fine for me without it, as far as I remember.

If it really doesn't build, then we would ideally prefer a patch (which
gets submitted upstream).

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-06-29 10:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27 18:46 [Buildroot] [PATCH] Reiserfsprogs ANDY KENNEDY
2016-06-27 19:03 ` ANDY KENNEDY
2016-06-28 16:18 ` Thomas Petazzoni
2016-06-28 19:49   ` ANDY KENNEDY
2016-06-29 10:04     ` Thomas Petazzoni [this message]
2016-06-29 18:20       ` ANDY KENNEDY
2016-06-29 21:05         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160629120422.5d17355b@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox