* [Buildroot] [PATCH 2/3] package/libuio: disable Werror
2016-07-02 9:00 [Buildroot] [PATCH 1/3] package/libuio: fix build with external intl library Romain Naour
@ 2016-07-02 9:00 ` Romain Naour
2016-07-02 11:03 ` Yann E. MORIN
2016-07-02 11:27 ` Peter Korsgaard
2016-07-02 9:00 ` [Buildroot] [PATCH 3/3] package/libuio: fix build with musl Romain Naour
` (2 subsequent siblings)
3 siblings, 2 replies; 10+ messages in thread
From: Romain Naour @ 2016-07-02 9:00 UTC (permalink / raw)
To: buildroot
Disable -Werror to avoid build issues caused by warnings.
Signed-off-by: Romain Naour <romain.naour@smile.fr>
Reported-by: Peter Korsgaard <peter@korsgaard.com>
---
package/libuio/libuio.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/libuio/libuio.mk b/package/libuio/libuio.mk
index 6a73d23..c254d0d 100644
--- a/package/libuio/libuio.mk
+++ b/package/libuio/libuio.mk
@@ -9,7 +9,7 @@ LIBUIO_VERSION = 940861de278cb794bf9d775b76a4d1d4f9108607
LIBUIO_SITE = $(call github,Linutronix,libuio,$(LIBUIO_VERSION))
LIBUIO_LICENSE = LGPLv2.1 (library), GPLv2 (programs)
LIBUIO_LICENSE_FILES = COPYING
-LIBUIO_CONF_OPTS = --with-glib=no
+LIBUIO_CONF_OPTS = --with-glib=no --without-werror
LIBUIO_INSTALL_STAGING = YES
# Fetched from github, no pre-generated configure script provided
--
2.5.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Buildroot] [PATCH 2/3] package/libuio: disable Werror
2016-07-02 9:00 ` [Buildroot] [PATCH 2/3] package/libuio: disable Werror Romain Naour
@ 2016-07-02 11:03 ` Yann E. MORIN
2016-07-02 11:27 ` Peter Korsgaard
1 sibling, 0 replies; 10+ messages in thread
From: Yann E. MORIN @ 2016-07-02 11:03 UTC (permalink / raw)
To: buildroot
Romain, All,
On 2016-07-02 11:00 +0200, Romain Naour spake thusly:
> Disable -Werror to avoid build issues caused by warnings.
>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> Reported-by: Peter Korsgaard <peter@korsgaard.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/libuio/libuio.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/libuio/libuio.mk b/package/libuio/libuio.mk
> index 6a73d23..c254d0d 100644
> --- a/package/libuio/libuio.mk
> +++ b/package/libuio/libuio.mk
> @@ -9,7 +9,7 @@ LIBUIO_VERSION = 940861de278cb794bf9d775b76a4d1d4f9108607
> LIBUIO_SITE = $(call github,Linutronix,libuio,$(LIBUIO_VERSION))
> LIBUIO_LICENSE = LGPLv2.1 (library), GPLv2 (programs)
> LIBUIO_LICENSE_FILES = COPYING
> -LIBUIO_CONF_OPTS = --with-glib=no
> +LIBUIO_CONF_OPTS = --with-glib=no --without-werror
> LIBUIO_INSTALL_STAGING = YES
>
> # Fetched from github, no pre-generated configure script provided
> --
> 2.5.5
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 2/3] package/libuio: disable Werror
2016-07-02 9:00 ` [Buildroot] [PATCH 2/3] package/libuio: disable Werror Romain Naour
2016-07-02 11:03 ` Yann E. MORIN
@ 2016-07-02 11:27 ` Peter Korsgaard
1 sibling, 0 replies; 10+ messages in thread
From: Peter Korsgaard @ 2016-07-02 11:27 UTC (permalink / raw)
To: buildroot
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:
> Disable -Werror to avoid build issues caused by warnings.
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> Reported-by: Peter Korsgaard <peter@korsgaard.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 3/3] package/libuio: fix build with musl
2016-07-02 9:00 [Buildroot] [PATCH 1/3] package/libuio: fix build with external intl library Romain Naour
2016-07-02 9:00 ` [Buildroot] [PATCH 2/3] package/libuio: disable Werror Romain Naour
@ 2016-07-02 9:00 ` Romain Naour
2016-07-02 11:02 ` Yann E. MORIN
2016-07-02 11:27 ` Peter Korsgaard
2016-07-02 11:04 ` [Buildroot] [PATCH 1/3] package/libuio: fix build with external intl library Yann E. MORIN
2016-07-02 11:26 ` Peter Korsgaard
3 siblings, 2 replies; 10+ messages in thread
From: Romain Naour @ 2016-07-02 9:00 UTC (permalink / raw)
To: buildroot
limits.h header is missing in attr.c, base.c and helper.c to provide
PATH_MAX.
Fixes:
http://autobuild.buildroot.net/results/702/7023104e6018ea46c54073ddbe5119d0f66ae5a3
Signed-off-by: Romain Naour <romain.naour@smile.fr>
---
package/libuio/0002-fix-build-with-musl.patch | 57 +++++++++++++++++++++++++++
1 file changed, 57 insertions(+)
create mode 100644 package/libuio/0002-fix-build-with-musl.patch
diff --git a/package/libuio/0002-fix-build-with-musl.patch b/package/libuio/0002-fix-build-with-musl.patch
new file mode 100644
index 0000000..6e5b168
--- /dev/null
+++ b/package/libuio/0002-fix-build-with-musl.patch
@@ -0,0 +1,57 @@
+From c378ee112857128002754c616acb6841ee32aaf6 Mon Sep 17 00:00:00 2001
+From: Romain Naour <romain.naour@smile.fr>
+Date: Sat, 2 Jul 2016 10:52:28 +0200
+Subject: [PATCH] fix build with musl
+
+limits.h header is missing in attr.c, base.c and helper.c to provide
+PATH_MAX.
+
+Fixes:
+http://autobuild.buildroot.net/results/702/7023104e6018ea46c54073ddbe5119d0f66ae5a3
+
+Signed-off-by: Romain Naour <romain.naour@smile.fr>
+---
+ attr.c | 1 +
+ base.c | 1 +
+ helper.c | 1 +
+ 3 files changed, 3 insertions(+)
+
+diff --git a/attr.c b/attr.c
+index 4245140..7512f4e 100644
+--- a/attr.c
++++ b/attr.c
+@@ -25,6 +25,7 @@
+ #include <dirent.h>
+ #include <errno.h>
+ #include <fcntl.h>
++#include <limits.h>
+ #include <stdio.h>
+ #include <stdlib.h>
+ #include <string.h>
+diff --git a/base.c b/base.c
+index 14ebcee..4ce7301 100644
+--- a/base.c
++++ b/base.c
+@@ -25,6 +25,7 @@
+ #include <dirent.h>
+ #include <errno.h>
+ #include <fcntl.h>
++#include <limits.h>
+ #include <stdio.h>
+ #include <stdlib.h>
+ #include <string.h>
+diff --git a/helper.c b/helper.c
+index 170f084..1fb0b4c 100644
+--- a/helper.c
++++ b/helper.c
+@@ -25,6 +25,7 @@
+ #include <dirent.h>
+ #include <errno.h>
+ #include <fcntl.h>
++#include <limits.h>
+ #include <regex.h>
+ #include <stdio.h>
+ #include <stdlib.h>
+--
+2.5.5
+
--
2.5.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 3/3] package/libuio: fix build with musl
2016-07-02 9:00 ` [Buildroot] [PATCH 3/3] package/libuio: fix build with musl Romain Naour
@ 2016-07-02 11:02 ` Yann E. MORIN
2016-07-02 11:27 ` Peter Korsgaard
1 sibling, 0 replies; 10+ messages in thread
From: Yann E. MORIN @ 2016-07-02 11:02 UTC (permalink / raw)
To: buildroot
Romain, All,
On 2016-07-02 11:00 +0200, Romain Naour spake thusly:
> limits.h header is missing in attr.c, base.c and helper.c to provide
> PATH_MAX.
>
> Fixes:
> http://autobuild.buildroot.net/results/702/7023104e6018ea46c54073ddbe5119d0f66ae5a3
>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Don't forget to send it upstream. ;-)
Regards,
Yann E. MORIN.
> ---
> package/libuio/0002-fix-build-with-musl.patch | 57 +++++++++++++++++++++++++++
> 1 file changed, 57 insertions(+)
> create mode 100644 package/libuio/0002-fix-build-with-musl.patch
>
> diff --git a/package/libuio/0002-fix-build-with-musl.patch b/package/libuio/0002-fix-build-with-musl.patch
> new file mode 100644
> index 0000000..6e5b168
> --- /dev/null
> +++ b/package/libuio/0002-fix-build-with-musl.patch
> @@ -0,0 +1,57 @@
> +From c378ee112857128002754c616acb6841ee32aaf6 Mon Sep 17 00:00:00 2001
> +From: Romain Naour <romain.naour@smile.fr>
> +Date: Sat, 2 Jul 2016 10:52:28 +0200
> +Subject: [PATCH] fix build with musl
> +
> +limits.h header is missing in attr.c, base.c and helper.c to provide
> +PATH_MAX.
> +
> +Fixes:
> +http://autobuild.buildroot.net/results/702/7023104e6018ea46c54073ddbe5119d0f66ae5a3
> +
> +Signed-off-by: Romain Naour <romain.naour@smile.fr>
> +---
> + attr.c | 1 +
> + base.c | 1 +
> + helper.c | 1 +
> + 3 files changed, 3 insertions(+)
> +
> +diff --git a/attr.c b/attr.c
> +index 4245140..7512f4e 100644
> +--- a/attr.c
> ++++ b/attr.c
> +@@ -25,6 +25,7 @@
> + #include <dirent.h>
> + #include <errno.h>
> + #include <fcntl.h>
> ++#include <limits.h>
> + #include <stdio.h>
> + #include <stdlib.h>
> + #include <string.h>
> +diff --git a/base.c b/base.c
> +index 14ebcee..4ce7301 100644
> +--- a/base.c
> ++++ b/base.c
> +@@ -25,6 +25,7 @@
> + #include <dirent.h>
> + #include <errno.h>
> + #include <fcntl.h>
> ++#include <limits.h>
> + #include <stdio.h>
> + #include <stdlib.h>
> + #include <string.h>
> +diff --git a/helper.c b/helper.c
> +index 170f084..1fb0b4c 100644
> +--- a/helper.c
> ++++ b/helper.c
> +@@ -25,6 +25,7 @@
> + #include <dirent.h>
> + #include <errno.h>
> + #include <fcntl.h>
> ++#include <limits.h>
> + #include <regex.h>
> + #include <stdio.h>
> + #include <stdlib.h>
> +--
> +2.5.5
> +
> --
> 2.5.5
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 3/3] package/libuio: fix build with musl
2016-07-02 9:00 ` [Buildroot] [PATCH 3/3] package/libuio: fix build with musl Romain Naour
2016-07-02 11:02 ` Yann E. MORIN
@ 2016-07-02 11:27 ` Peter Korsgaard
1 sibling, 0 replies; 10+ messages in thread
From: Peter Korsgaard @ 2016-07-02 11:27 UTC (permalink / raw)
To: buildroot
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:
> limits.h header is missing in attr.c, base.c and helper.c to provide
> PATH_MAX.
> Fixes:
> http://autobuild.buildroot.net/results/702/7023104e6018ea46c54073ddbe5119d0f66ae5a3
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/3] package/libuio: fix build with external intl library
2016-07-02 9:00 [Buildroot] [PATCH 1/3] package/libuio: fix build with external intl library Romain Naour
2016-07-02 9:00 ` [Buildroot] [PATCH 2/3] package/libuio: disable Werror Romain Naour
2016-07-02 9:00 ` [Buildroot] [PATCH 3/3] package/libuio: fix build with musl Romain Naour
@ 2016-07-02 11:04 ` Yann E. MORIN
2016-07-02 11:16 ` Romain Naour
2016-07-02 11:26 ` Peter Korsgaard
3 siblings, 1 reply; 10+ messages in thread
From: Yann E. MORIN @ 2016-07-02 11:04 UTC (permalink / raw)
To: buildroot
Romain, All,
On 2016-07-02 11:00 +0200, Romain Naour spake thusly:
> When intl library is not provided by the libc, libuio forget to link
> with -lintl.
>
> Fixes:
> http://autobuild.buildroot.net/results/8f7/8f715b4e9b826dac13f3d49da25576e6e1d79449
>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> ---
> package/libuio/libuio.mk | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/package/libuio/libuio.mk b/package/libuio/libuio.mk
> index e019fe9..6a73d23 100644
> --- a/package/libuio/libuio.mk
> +++ b/package/libuio/libuio.mk
> @@ -21,7 +21,16 @@ LIBUIO_CONF_ENV += MAKEINFO=true
>
> ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
> LIBUIO_DEPENDENCIES += argp-standalone
> -LIBUIO_CONF_ENV += LIBS="-largp"
> +LIBUIO_ARGP_LIBS += -largp
What about:
LIBUIO_LIBS = -largp
> endif
>
> +# libuio pulls in libintl if needed, so ensure we also
> +# link against it, otherwise static linking fails
> +ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
> +LIBUIO_DEPENDENCIES += gettext
> +LIBUIO_INTL_LIBS += -lintl
And:
LIBUIO_LIBS += -lintl
> +endif
> +
> +LIBUIO_CONF_ENV += LIBS="$(LIBUIO_ARGP_LIBS) $(LIBUIO_INTL_LIBS)"
With finally;
LIBUIO_CONF_ENV += LIBS="$(LIBUIO_LIBS)"
Regards,
Yann E. MORIN.
> $(eval $(autotools-package))
> --
> 2.5.5
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 10+ messages in thread* [Buildroot] [PATCH 1/3] package/libuio: fix build with external intl library
2016-07-02 11:04 ` [Buildroot] [PATCH 1/3] package/libuio: fix build with external intl library Yann E. MORIN
@ 2016-07-02 11:16 ` Romain Naour
0 siblings, 0 replies; 10+ messages in thread
From: Romain Naour @ 2016-07-02 11:16 UTC (permalink / raw)
To: buildroot
Le 02/07/2016 ? 13:04, Yann E. MORIN a ?crit :
> Romain, All,
>
> On 2016-07-02 11:00 +0200, Romain Naour spake thusly:
>> When intl library is not provided by the libc, libuio forget to link
>> with -lintl.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/8f7/8f715b4e9b826dac13f3d49da25576e6e1d79449
>>
>> Signed-off-by: Romain Naour <romain.naour@smile.fr>
>> ---
>> package/libuio/libuio.mk | 11 ++++++++++-
>> 1 file changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/libuio/libuio.mk b/package/libuio/libuio.mk
>> index e019fe9..6a73d23 100644
>> --- a/package/libuio/libuio.mk
>> +++ b/package/libuio/libuio.mk
>> @@ -21,7 +21,16 @@ LIBUIO_CONF_ENV += MAKEINFO=true
>>
>> ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
>> LIBUIO_DEPENDENCIES += argp-standalone
>> -LIBUIO_CONF_ENV += LIBS="-largp"
>> +LIBUIO_ARGP_LIBS += -largp
>
> What about:
>
> LIBUIO_LIBS = -largp
>
>> endif
>>
>> +# libuio pulls in libintl if needed, so ensure we also
>> +# link against it, otherwise static linking fails
>> +ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
>> +LIBUIO_DEPENDENCIES += gettext
>> +LIBUIO_INTL_LIBS += -lintl
>
> And:
>
> LIBUIO_LIBS += -lintl
>
>> +endif
>> +
>> +LIBUIO_CONF_ENV += LIBS="$(LIBUIO_ARGP_LIBS) $(LIBUIO_INTL_LIBS)"
>
> With finally;
>
> LIBUIO_CONF_ENV += LIBS="$(LIBUIO_LIBS)"
>
Right, tanks for the review :)
Best regards,
Romain
> Regards,
> Yann E. MORIN.
>
>> $(eval $(autotools-package))
>> --
>> 2.5.5
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/3] package/libuio: fix build with external intl library
2016-07-02 9:00 [Buildroot] [PATCH 1/3] package/libuio: fix build with external intl library Romain Naour
` (2 preceding siblings ...)
2016-07-02 11:04 ` [Buildroot] [PATCH 1/3] package/libuio: fix build with external intl library Yann E. MORIN
@ 2016-07-02 11:26 ` Peter Korsgaard
3 siblings, 0 replies; 10+ messages in thread
From: Peter Korsgaard @ 2016-07-02 11:26 UTC (permalink / raw)
To: buildroot
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:
> When intl library is not provided by the libc, libuio forget to link
> with -lintl.
> Fixes:
> http://autobuild.buildroot.net/results/8f7/8f715b4e9b826dac13f3d49da25576e6e1d79449
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
Committed after simplifying as suggested by Yann, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 10+ messages in thread