Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/kodi: add support for libudev
@ 2016-07-10 18:36 Bernd Kuhls
  2016-07-10 18:36 ` [Buildroot] [PATCH 2/2] package/kodi: if libudev is available, we don't need libusb Bernd Kuhls
  2016-07-11  8:22 ` [Buildroot] [PATCH 1/2] package/kodi: add support for libudev Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Bernd Kuhls @ 2016-07-10 18:36 UTC (permalink / raw)
  To: buildroot

Most of the times this is not needed because libdrm & mesa3d already
pull in the dependency to udev. Let's add it anyway to make sure that
udev is really used and to document that Kodi makes use of udev.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/kodi/kodi.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk
index 90c50c3..21a0d53 100644
--- a/package/kodi/kodi.mk
+++ b/package/kodi/kodi.mk
@@ -53,6 +53,13 @@ KODI_CONF_ENV += INCLUDES="-I$(STAGING_DIR)/usr/include/interface/vcos/pthreads
 	LIBS="-lvcos -lvchostif"
 endif
 
+ifeq ($(BR2_PACKAGE_HAS_LIBUDEV),y)
+KODI_DEPENDENCIES += udev
+KODI_CONF_OPTS += --enable-udev
+else
+KODI_CONF_OPTS += --disable-udev
+endif
+
 ifeq ($(BR2_PACKAGE_IMX_VPUWRAP),y)
 KODI_DEPENDENCIES += imx-vpuwrap
 KODI_CONF_OPTS += --enable-codec=imxvpu
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 2/2] package/kodi: if libudev is available, we don't need libusb
  2016-07-10 18:36 [Buildroot] [PATCH 1/2] package/kodi: add support for libudev Bernd Kuhls
@ 2016-07-10 18:36 ` Bernd Kuhls
  2016-07-11  8:22 ` [Buildroot] [PATCH 1/2] package/kodi: add support for libudev Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Bernd Kuhls @ 2016-07-10 18:36 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/kodi/Config.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/kodi/Config.in b/package/kodi/Config.in
index 3d3ecfd..6eff7c8 100644
--- a/package/kodi/Config.in
+++ b/package/kodi/Config.in
@@ -216,6 +216,9 @@ config BR2_PACKAGE_KODI_LIBTHEORA
 
 config BR2_PACKAGE_KODI_LIBUSB
 	bool "usb"
+	# https://github.com/xbmc/xbmc/blob/Jarvis/configure.ac#L1554
+	# "if libudev is available, we don't need libusb"
+	depends on !BR2_PACKAGE_HAS_UDEV
 	select BR2_PACKAGE_LIBUSB
 	select BR2_PACKAGE_LIBUSB_COMPAT
 	help
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/2] package/kodi: add support for libudev
  2016-07-10 18:36 [Buildroot] [PATCH 1/2] package/kodi: add support for libudev Bernd Kuhls
  2016-07-10 18:36 ` [Buildroot] [PATCH 2/2] package/kodi: if libudev is available, we don't need libusb Bernd Kuhls
@ 2016-07-11  8:22 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2016-07-11  8:22 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, 10 Jul 2016 20:36:19 +0200, Bernd Kuhls wrote:
> Most of the times this is not needed because libdrm & mesa3d already
> pull in the dependency to udev. Let's add it anyway to make sure that
> udev is really used and to document that Kodi makes use of udev.
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/kodi/kodi.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk
> index 90c50c3..21a0d53 100644
> --- a/package/kodi/kodi.mk
> +++ b/package/kodi/kodi.mk
> @@ -53,6 +53,13 @@ KODI_CONF_ENV += INCLUDES="-I$(STAGING_DIR)/usr/include/interface/vcos/pthreads
>  	LIBS="-lvcos -lvchostif"
>  endif
>  
> +ifeq ($(BR2_PACKAGE_HAS_LIBUDEV),y)

HAS_UDEV (same typo as mesa3d) :-)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-07-11  8:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-10 18:36 [Buildroot] [PATCH 1/2] package/kodi: add support for libudev Bernd Kuhls
2016-07-10 18:36 ` [Buildroot] [PATCH 2/2] package/kodi: if libudev is available, we don't need libusb Bernd Kuhls
2016-07-11  8:22 ` [Buildroot] [PATCH 1/2] package/kodi: add support for libudev Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox