* [Buildroot] [PATCH] cmake: bump version to 3.6.0
@ 2016-07-14 10:06 Vicente Olivert Riera
2016-07-14 10:32 ` Thomas Petazzoni
2016-07-14 13:59 ` Yann E. MORIN
0 siblings, 2 replies; 5+ messages in thread
From: Vicente Olivert Riera @ 2016-07-14 10:06 UTC (permalink / raw)
To: buildroot
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
package/cmake/0001-rename_cmake_rootfile.patch | 28 ++++++++++++++++----------
package/cmake/cmake.hash | 4 ++--
package/cmake/cmake.mk | 4 ++--
3 files changed, 21 insertions(+), 15 deletions(-)
diff --git a/package/cmake/0001-rename_cmake_rootfile.patch b/package/cmake/0001-rename_cmake_rootfile.patch
index 915b7e3..e76f9cd 100644
--- a/package/cmake/0001-rename_cmake_rootfile.patch
+++ b/package/cmake/0001-rename_cmake_rootfile.patch
@@ -5,19 +5,25 @@ files are removed at build time via the target-finalize rule.
This buildroot-specific patch makes sure ctest looks also for
"Modules/CMake.cmake.ctest" before complaining
+[Vincent: tweak patch for 3.6.0]
+
Signed-off-by: Davide Viti <zinosat@tiscali.it>
+Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---- cmake-3.0.2/Source/cmake.cxx~ 2014-09-11 15:24:01.000000000 +0200
-+++ cmake-3.0.2/Source/cmake.cxx 2014-11-25 15:48:04.461033690 +0100
-@@ -957,7 +957,10 @@
- "Path to cpack program executable.", cmCacheManager::INTERNAL);
+diff -rup a/Source/cmake.cxx b/Source/cmake.cxx
+--- a/Source/cmake.cxx 2016-07-07 15:47:27.000000000 +0100
++++ b/Source/cmake.cxx 2016-07-14 10:14:59.914265515 +0100
+@@ -771,7 +771,12 @@ int cmake::AddCMakePaths()
+ "Path to cpack program executable.", cmState::INTERNAL);
#endif
- if(!cmSystemTools::FileExists(
-- (cmSystemTools::GetCMakeRoot()+"/Modules/CMake.cmake").c_str()))
-+ (cmSystemTools::GetCMakeRoot()+"/Modules/CMake.cmake").c_str()) &&
-+ !cmSystemTools::FileExists(
-+ (cmSystemTools::GetCMakeRoot()+"/Modules/CMake.cmake.ctest").c_str())
+ if (!cmSystemTools::FileExists(
+- (cmSystemTools::GetCMakeRoot() + "/Modules/CMake.cmake").c_str())) {
++ (cmSystemTools::GetCMakeRoot() + "/Modules/CMake.cmake").c_str()) &&
++ !cmSystemTools::FileExists(
++ (cmSystemTools::GetCMakeRoot()+"/Modules/CMake.cmake.ctest").c_str()
++ )
+ )
- {
++ {
// couldn't find modules
- cmSystemTools::Error("Could not find CMAKE_ROOT !!!\n"
+ cmSystemTools::Error(
+ "Could not find CMAKE_ROOT !!!\n"
diff --git a/package/cmake/cmake.hash b/package/cmake/cmake.hash
index e40d4ea..7cd1133 100644
--- a/package/cmake/cmake.hash
+++ b/package/cmake/cmake.hash
@@ -1,2 +1,2 @@
-# From http://www.cmake.org/files/v3.5/cmake-3.5.2-SHA-256.txt
-sha256 92d8410d3d981bb881dfff2aed466da55a58d34c7390d50449aa59b32bb5e62a cmake-3.5.2.tar.gz
+# From http://www.cmake.org/files/v3.6/cmake-3.6.0-SHA-256.txt
+sha256 fd05ed40cc40ef9ef99fac7b0ece2e0b871858a82feade48546f5d2940147670 cmake-3.6.0.tar.gz
diff --git a/package/cmake/cmake.mk b/package/cmake/cmake.mk
index 7a80c1b..25eafe8 100644
--- a/package/cmake/cmake.mk
+++ b/package/cmake/cmake.mk
@@ -4,8 +4,8 @@
#
################################################################################
-CMAKE_VERSION_MAJOR = 3.5
-CMAKE_VERSION = $(CMAKE_VERSION_MAJOR).2
+CMAKE_VERSION_MAJOR = 3.6
+CMAKE_VERSION = $(CMAKE_VERSION_MAJOR).0
CMAKE_SITE = https://cmake.org/files/v$(CMAKE_VERSION_MAJOR)
CMAKE_LICENSE = BSD-3c
CMAKE_LICENSE_FILES = Copyright.txt
--
2.7.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] cmake: bump version to 3.6.0
2016-07-14 10:06 [Buildroot] [PATCH] cmake: bump version to 3.6.0 Vicente Olivert Riera
@ 2016-07-14 10:32 ` Thomas Petazzoni
2016-07-14 13:59 ` Yann E. MORIN
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2016-07-14 10:32 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 14 Jul 2016 11:06:50 +0100, Vicente Olivert Riera wrote:
> diff --git a/package/cmake/0001-rename_cmake_rootfile.patch b/package/cmake/0001-rename_cmake_rootfile.patch
> index 915b7e3..e76f9cd 100644
> --- a/package/cmake/0001-rename_cmake_rootfile.patch
> +++ b/package/cmake/0001-rename_cmake_rootfile.patch
> @@ -5,19 +5,25 @@ files are removed at build time via the target-finalize rule.
> This buildroot-specific patch makes sure ctest looks also for
> "Modules/CMake.cmake.ctest" before complaining
>
> +[Vincent: tweak patch for 3.6.0]
This normally goes...
> +
> Signed-off-by: Davide Viti <zinosat@tiscali.it>
.... here.
So I've changed that and applied.
> +Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] cmake: bump version to 3.6.0
2016-07-14 10:06 [Buildroot] [PATCH] cmake: bump version to 3.6.0 Vicente Olivert Riera
2016-07-14 10:32 ` Thomas Petazzoni
@ 2016-07-14 13:59 ` Yann E. MORIN
2016-07-14 17:19 ` Vicente Olivert Riera
1 sibling, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2016-07-14 13:59 UTC (permalink / raw)
To: buildroot
Vicente, All,
On 2016-07-14 11:06 +0100, Vicente Olivert Riera spake thusly:
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
[--SNIP--]
> diff --git a/package/cmake/cmake.mk b/package/cmake/cmake.mk
> index 7a80c1b..25eafe8 100644
> --- a/package/cmake/cmake.mk
> +++ b/package/cmake/cmake.mk
> @@ -4,8 +4,8 @@
> #
> ################################################################################
>
> -CMAKE_VERSION_MAJOR = 3.5
> -CMAKE_VERSION = $(CMAKE_VERSION_MAJOR).2
> +CMAKE_VERSION_MAJOR = 3.6
> +CMAKE_VERSION = $(CMAKE_VERSION_MAJOR).0
This is causing a lot of build failures:
http://autobuild.buildroot.org/?reason=host-cmake-3.6.0
There are various tyes of failures:
- incorrect openssl used:
http://autobuild.buildroot.org/results/193/193e88df98230554e304a8c550e5ded97e3a4177
-- Found OpenSSL: /home/buildroot/build/instance-1/output/host/usr/xtensa-buildroot-lin
ux-uclibc/sysroot/usr/lib/libssl.so;/home/buildroot/build/instance-1/output/host/usr/xt
ensa-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.so (found version "1.0.2h")
Clearly, this is finding the target openssl when we are building the
host-cmake. That's wrong.
- a weird error while configuring its bundled libcurl:
http://autobuild.buildroot.org/results/f8c/f8c335440e3132ee7e01fadd03c4d18e0de767ba
-- Check size of curl_off_t
-- Check size of curl_off_t - failed
-- Check size of socklen_t
-- Check size of socklen_t - failed
CMake Error at Utilities/cmcurl/CMakeLists.txt:1042 (message):
Check for sizeof socklen_t failed, see CMakeFiles/CMakerror.log
If cmake insists on having curl+ssl support (what for, for g*d's
sake?) we should add a host-libcurl and make host-cmake depend on it
and on host-openssl.
- another weird build issue:
http://autobuild.buildroot.org/results/89f/89fd8085da9cacf612a6aea585eb1ad6941f146b
/home/buildroot/build/instance-1/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/multi.c:
Assembler messages:
/home/buildroot/build/instance-1/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/multi.c:761: Error: incorrect register `%rdx' used with `l' suffix
/home/buildroot/build/instance-1/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/multi.c:765: Error: incorrect register `%rcx' used with `l' suffix
Utilities/cmcurl/lib/CMakeFiles/cmcurl.dir/build.make:950: recipe for target 'Utilities/cmcurl/lib/CMakeFiles/cmcurl.dir/multi.c.o' failed
This one looks like again like it is confusing host and target, and
using the wrong compiler and/or assembler.
- yet again another weird build issue:
http://autobuild.buildroot.org/results/85f/85f5e9329047c9d40f7fd35c645835d83a5fcef3/
/home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:
Assembler messages: /home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:1167: Error: junk at end of line, first unrecognized character is `%'
/home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:1167: Error: junk at end of line, first unrecognized character is `%'
/home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:1258: Error: junk at end of line, first unrecognized character is `%'
/home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:1258: Error: junk at end of line, first unrecognized character is `%'
/home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:1258: Error: junk at end of line, first unrecognized character is `%'
/home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:1258: Error: junk at end of line, first unrecognized character is `%'
make[4]: *** [Utilities/cmcurl/lib/CMakeFiles/cmcurl.dir/ftp.c.o] Error 1
make[4]: *** Waiting for unfinished jobs....
Regards,
Yann E. MORIN.
> CMAKE_SITE = https://cmake.org/files/v$(CMAKE_VERSION_MAJOR)
> CMAKE_LICENSE = BSD-3c
> CMAKE_LICENSE_FILES = Copyright.txt
> --
> 2.7.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] cmake: bump version to 3.6.0
2016-07-14 13:59 ` Yann E. MORIN
@ 2016-07-14 17:19 ` Vicente Olivert Riera
2016-07-23 19:33 ` Ben Boeckel
0 siblings, 1 reply; 5+ messages in thread
From: Vicente Olivert Riera @ 2016-07-14 17:19 UTC (permalink / raw)
To: buildroot
Hello Yann,
I would say revert this for now since there are many things to fix. This
way we avoid all the build failures.
Regards,
Vincent.
On 14/07/16 14:59, Yann E. MORIN wrote:
> Vicente, All,
>
> On 2016-07-14 11:06 +0100, Vicente Olivert Riera spake thusly:
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> ---
> [--SNIP--]
>> diff --git a/package/cmake/cmake.mk b/package/cmake/cmake.mk
>> index 7a80c1b..25eafe8 100644
>> --- a/package/cmake/cmake.mk
>> +++ b/package/cmake/cmake.mk
>> @@ -4,8 +4,8 @@
>> #
>> ################################################################################
>>
>> -CMAKE_VERSION_MAJOR = 3.5
>> -CMAKE_VERSION = $(CMAKE_VERSION_MAJOR).2
>> +CMAKE_VERSION_MAJOR = 3.6
>> +CMAKE_VERSION = $(CMAKE_VERSION_MAJOR).0
>
> This is causing a lot of build failures:
> http://autobuild.buildroot.org/?reason=host-cmake-3.6.0
>
> There are various tyes of failures:
>
> - incorrect openssl used:
>
> http://autobuild.buildroot.org/results/193/193e88df98230554e304a8c550e5ded97e3a4177
>
> -- Found OpenSSL: /home/buildroot/build/instance-1/output/host/usr/xtensa-buildroot-lin
> ux-uclibc/sysroot/usr/lib/libssl.so;/home/buildroot/build/instance-1/output/host/usr/xt
> ensa-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.so (found version "1.0.2h")
>
> Clearly, this is finding the target openssl when we are building the
> host-cmake. That's wrong.
>
> - a weird error while configuring its bundled libcurl:
>
> http://autobuild.buildroot.org/results/f8c/f8c335440e3132ee7e01fadd03c4d18e0de767ba
>
> -- Check size of curl_off_t
> -- Check size of curl_off_t - failed
> -- Check size of socklen_t
> -- Check size of socklen_t - failed
> CMake Error at Utilities/cmcurl/CMakeLists.txt:1042 (message):
> Check for sizeof socklen_t failed, see CMakeFiles/CMakerror.log
>
> If cmake insists on having curl+ssl support (what for, for g*d's
> sake?) we should add a host-libcurl and make host-cmake depend on it
> and on host-openssl.
>
> - another weird build issue:
>
> http://autobuild.buildroot.org/results/89f/89fd8085da9cacf612a6aea585eb1ad6941f146b
>
> /home/buildroot/build/instance-1/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/multi.c:
> Assembler messages:
> /home/buildroot/build/instance-1/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/multi.c:761: Error: incorrect register `%rdx' used with `l' suffix
> /home/buildroot/build/instance-1/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/multi.c:765: Error: incorrect register `%rcx' used with `l' suffix
> Utilities/cmcurl/lib/CMakeFiles/cmcurl.dir/build.make:950: recipe for target 'Utilities/cmcurl/lib/CMakeFiles/cmcurl.dir/multi.c.o' failed
>
> This one looks like again like it is confusing host and target, and
> using the wrong compiler and/or assembler.
>
> - yet again another weird build issue:
>
> http://autobuild.buildroot.org/results/85f/85f5e9329047c9d40f7fd35c645835d83a5fcef3/
>
> /home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:
> Assembler messages: /home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:1167: Error: junk at end of line, first unrecognized character is `%'
> /home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:1167: Error: junk at end of line, first unrecognized character is `%'
> /home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:1258: Error: junk at end of line, first unrecognized character is `%'
> /home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:1258: Error: junk at end of line, first unrecognized character is `%'
> /home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:1258: Error: junk at end of line, first unrecognized character is `%'
> /home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:1258: Error: junk at end of line, first unrecognized character is `%'
> make[4]: *** [Utilities/cmcurl/lib/CMakeFiles/cmcurl.dir/ftp.c.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
>
> Regards,
> Yann E. MORIN.
>
>> CMAKE_SITE = https://cmake.org/files/v$(CMAKE_VERSION_MAJOR)
>> CMAKE_LICENSE = BSD-3c
>> CMAKE_LICENSE_FILES = Copyright.txt
>> --
>> 2.7.3
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] cmake: bump version to 3.6.0
2016-07-14 17:19 ` Vicente Olivert Riera
@ 2016-07-23 19:33 ` Ben Boeckel
0 siblings, 0 replies; 5+ messages in thread
From: Ben Boeckel @ 2016-07-23 19:33 UTC (permalink / raw)
To: buildroot
On Thu, 14 Jul, 2016 at 17:19:11 GMT, Vicente Olivert Riera wrote:
>> This is causing a lot of build failures:
>> http://autobuild.buildroot.org/?reason=host-cmake-3.6.0
*Puts CMake developer hat on.*
When things like this happen, please file an issue. We just did 3.6.1
this week and it appears that we'll also need a 3.6.2 for some of these
issues; they could have been fixed in 3.6.1 if we had known about them
on the 14th.
>> There are various tyes of failures:
>>
>> - incorrect openssl used:
>>
>> http://autobuild.buildroot.org/results/193/193e88df98230554e304a8c550e5ded97e3a4177
>>
>> -- Found OpenSSL: /home/buildroot/build/instance-1/output/host/usr/xtensa-buildroot-lin
>> ux-uclibc/sysroot/usr/lib/libssl.so;/home/buildroot/build/instance-1/output/host/usr/xt
>> ensa-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.so (found version "1.0.2h")
>>
>> Clearly, this is finding the target openssl when we are building the
>> host-cmake. That's wrong.
Indeed. Please file an issue over here:
https://gitlab.kitware.com/cmake/cmake/issues
so that this can be tracked.
>> - a weird error while configuring its bundled libcurl:
>>
>> http://autobuild.buildroot.org/results/f8c/f8c335440e3132ee7e01fadd03c4d18e0de767ba
>>
>> -- Check size of curl_off_t
>> -- Check size of curl_off_t - failed
>> -- Check size of socklen_t
>> -- Check size of socklen_t - failed
>> CMake Error at Utilities/cmcurl/CMakeLists.txt:1042 (message):
>> Check for sizeof socklen_t failed, see CMakeFiles/CMakerror.log
>>
>> If cmake insists on having curl+ssl support (what for, for g*d's
>> sake?) we should add a host-libcurl and make host-cmake depend on it
>> and on host-openssl.
Because otherwise file(DOWNLOAD) cannot fetch files over HTTPS (a common
enough occurence these days). That said, I'm not sure why it's
*required* from a CMake standpoint (but it may cause "unknown protocol
https" during the build of other projects). This is probably due to
something related to the openssl issue above.
>> - another weird build issue:
>>
>> http://autobuild.buildroot.org/results/89f/89fd8085da9cacf612a6aea585eb1ad6941f146b
>>
>> /home/buildroot/build/instance-1/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/multi.c:
>> Assembler messages:
>> /home/buildroot/build/instance-1/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/multi.c:761: Error: incorrect register `%rdx' used with `l' suffix
>> /home/buildroot/build/instance-1/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/multi.c:765: Error: incorrect register `%rcx' used with `l' suffix
>> Utilities/cmcurl/lib/CMakeFiles/cmcurl.dir/build.make:950: recipe for target 'Utilities/cmcurl/lib/CMakeFiles/cmcurl.dir/multi.c.o' failed
>>
>> This one looks like again like it is confusing host and target, and
>> using the wrong compiler and/or assembler.
Please file an issue.
>> - yet again another weird build issue:
>>
>> http://autobuild.buildroot.org/results/85f/85f5e9329047c9d40f7fd35c645835d83a5fcef3/
>>
>> /home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:
>> Assembler messages: /home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:1167: Error: junk at end of line, first unrecognized character is `%'
>> /home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:1167: Error: junk at end of line, first unrecognized character is `%'
>> /home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:1258: Error: junk at end of line, first unrecognized character is `%'
>> /home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:1258: Error: junk at end of line, first unrecognized character is `%'
>> /home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:1258: Error: junk at end of line, first unrecognized character is `%'
>> /home/buildroot/autobuild/run/instance-2/output/build/host-cmake-3.6.0/Utilities/cmcurl/lib/ftp.c:1258: Error: junk at end of line, first unrecognized character is `%'
>> make[4]: *** [Utilities/cmcurl/lib/CMakeFiles/cmcurl.dir/ftp.c.o] Error 1
>> make[4]: *** Waiting for unfinished jobs....
Looks similar to the above one? We did update curl for 3.6 I believe.
Thanks,
--Ben
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-07-23 19:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-14 10:06 [Buildroot] [PATCH] cmake: bump version to 3.6.0 Vicente Olivert Riera
2016-07-14 10:32 ` Thomas Petazzoni
2016-07-14 13:59 ` Yann E. MORIN
2016-07-14 17:19 ` Vicente Olivert Riera
2016-07-23 19:33 ` Ben Boeckel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox