Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ntp: Adding support for SHM clocks
Date: Fri, 15 Jul 2016 13:18:02 +0200	[thread overview]
Message-ID: <20160715131802.3cd75547@free-electrons.com> (raw)
In-Reply-To: <1468530482-58311-1-git-send-email-matthew.weber@rockwellcollins.com>

Hello,

On Thu, 14 Jul 2016 16:08:02 -0500, Matt Weber wrote:
> From: ynadupur <yugendra.sai.babu.nadupuru@rockwellcollins.com>

This From: was obviously not properly formatted, as we want a full name.

> Description:

No need for "Description:" in the commit log.

> 
>     In order for gpsd to work with the new version of ntpd, an enable option
>     must be added to the configure step of ntp that allows for support of
>     SHM Clocks to be attached through shared memory.

The commit log shouldn't be indented.

> 
> Signed-off-by:[YUGENDRA SAI BABU NADUPURU]<yugendra.sai.babu.nadupuru@rockwellcollins.com>

This was also not properly formatted.

> +config BR2_PACKAGE_NTP_NTP_SHM_CLK
> +	bool "SHM clock support"
> +	help
> +	 Compile ntp with support for a SHM clock attached through shared
> +	 memory.

Indentation for the help text is one tab + two spaces, not one tab +
one space.

> +ifeq ($(BR2_PACKAGE_NTP_NTP_SHM_CLK),y)
> +	NTP_CONF_OPTS += --enable-SHM

We don't indent such lines.

Committed with all those minor issues fixed.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2016-07-15 11:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-14 21:08 [Buildroot] [PATCH] ntp: Adding support for SHM clocks Matt Weber
2016-07-15 11:18 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160715131802.3cd75547@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox