[Buildroot] [PATCH] ntp: Adding support for SHM clocks

[Buildroot] [PATCH] ntp: Adding support for SHM clocks

[Matt Weber]

From: ynadupur <yugendra.sai.babu.nadupuru@rockwellcollins.com>

Description:

    In order for gpsd to work with the new version of ntpd, an enable option
    must be added to the configure step of ntp that allows for support of
    SHM Clocks to be attached through shared memory.

Signed-off-by:[YUGENDRA SAI BABU NADUPURU]<yugendra.sai.babu.nadupuru@rockwellcollins.com>
Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
---
 package/ntp/Config.in | 6 ++++++
 package/ntp/ntp.mk    | 6 ++++++
 2 files changed, 12 insertions(+)

diff --git a/package/ntp/Config.in b/package/ntp/Config.in
index 1763225..ad5914e 100644
--- a/package/ntp/Config.in
+++ b/package/ntp/Config.in
@@ -42,6 +42,12 @@ config BR2_PACKAGE_NTP_NTPD_ATOM_PPS
 	help
 	  Compile ntpd with the ability to use an ATOM PPS source.
 
+config BR2_PACKAGE_NTP_NTP_SHM_CLK
+	bool "SHM clock support"
+	help
+	 Compile ntp with support for a SHM clock attached through shared
+	 memory.
+
 config BR2_PACKAGE_NTP_NTPDATE
 	bool "ntpdate"
 	help
diff --git a/package/ntp/ntp.mk b/package/ntp/ntp.mk
index 8d3a6f3..8481bc8 100644
--- a/package/ntp/ntp.mk
+++ b/package/ntp/ntp.mk
@@ -42,6 +42,12 @@ else
 NTP_CONF_OPTS += --disable-ATOM
 endif
 
+ifeq ($(BR2_PACKAGE_NTP_NTP_SHM_CLK),y)
+	NTP_CONF_OPTS += --enable-SHM
+else
+	NTP_CONF_OPTS += --disable-SHM
+endif
+
 NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTP_KEYGEN) += util/ntp-keygen
 NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTP_WAIT) += scripts/ntp-wait/ntp-wait
 NTP_INSTALL_FILES_$(BR2_PACKAGE_NTP_NTPDATE) += ntpdate/ntpdate
-- 
1.9.1

[Buildroot] [PATCH] ntp: Adding support for SHM clocks

[Thomas Petazzoni]

Hello,

On Thu, 14 Jul 2016 16:08:02 -0500, Matt Weber wrote:
> From: ynadupur <yugendra.sai.babu.nadupuru@rockwellcollins.com>

This From: was obviously not properly formatted, as we want a full name.

> Description:

No need for "Description:" in the commit log.

> 
>     In order for gpsd to work with the new version of ntpd, an enable option
>     must be added to the configure step of ntp that allows for support of
>     SHM Clocks to be attached through shared memory.

The commit log shouldn't be indented.

> 
> Signed-off-by:[YUGENDRA SAI BABU NADUPURU]<yugendra.sai.babu.nadupuru@rockwellcollins.com>

This was also not properly formatted.

> +config BR2_PACKAGE_NTP_NTP_SHM_CLK
> +	bool "SHM clock support"
> +	help
> +	 Compile ntp with support for a SHM clock attached through shared
> +	 memory.

Indentation for the help text is one tab + two spaces, not one tab +
one space.

> +ifeq ($(BR2_PACKAGE_NTP_NTP_SHM_CLK),y)
> +	NTP_CONF_OPTS += --enable-SHM

We don't indent such lines.

Committed with all those minor issues fixed.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com