[Buildroot] [PATCH 1/2 v3] odroid-scripts: New Package.

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Hello,

On Sun, 24 Jul 2016 15:26:24 +0200, daggs wrote:

> > The changelog should not be part of the commit log.
> >   
> > > 
> > > Signed-off-by: Dagg Stompler <daggs@gmx.com>
> > > ---  
> > 
> > It should be here.  
> 
> I always seems to forget were to place it.... :-/

It's pretty simple:

"""
foo: new package

Blabla what this new package is all about. Blabla.

Signed-off-by: John Doe
---
Changes since v2:
 ...
"""

Everything that is *above* the "---" sign gets kept in the Git history
as the commit log. Everything that is *below" the "---" sign is ignored
when the patch is applied.

Since the changelog is describing what was changed between iterations
of the patch, we don't want the changelog to be committed forever in
the Git history, so it should be below the "---" sign.

When doing a commit, you can simply introduce a "---" manually below
your Signed-off-by and write your changelog here.


> this resulted im my serial usb stop working, e.g. I didn't know where I was in the boot nor couldn't log in into the system.
> 
> without both of the changes, the system boots ok.

OK, makes sense. Thanks for explaining.

> > Other than that, looks good. Can you respin a new version?  
> 
> maybe later today.

Sure, or another day, there's no hurry.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com