Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2 v4] odroid-mali: New Package.
Date: Sun, 24 Jul 2016 15:34:48 +0200	[thread overview]
Message-ID: <20160724153448.2e33f760@free-electrons.com> (raw)
In-Reply-To: <trinity-433daad2-ef46-4fa5-91d7-8ad0ed76e138-1469366971377@3capp-mailcom-bs05>

Hello,

On Sun, 24 Jul 2016 15:29:31 +0200, daggs wrote:

> > >  package/Config.in                    |  1 +
> > >  package/odroid-mali/Config.in        | 21 +++++++++++++++++++++
> > >  package/odroid-mali/odroid-mali.hash |  2 ++
> > >  package/odroid-mali/odroid-mali.mk   | 36 ++++++++++++++++++++++++++++++++++++
> > >  4 files changed, 60 insertions(+)
> > >  create mode 100644 package/odroid-mali/Config.in
> > >  create mode 100644 package/odroid-mali/odroid-mali.hash
> > >  create mode 100644 package/odroid-mali/odroid-mali.mk  
> >   
> > > +	depends on BR2_PACKAGE_ODROID_SCRIPTS  
> > 
> > Why do you have this dependency?  
> 
> because afaiu, this will not work if the scripts form odroid-scripts got executed.

I guess you meant "if the scripts from odroid-scripts were *not*
executed", right ?

If that's the case, then I believe a "select
BR2_PACKAGE_ODROID_SCRIPTS" is probably better.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-07-24 13:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-24  5:56 [Buildroot] [PATCH 1/2 v3] odroid-scripts: New Package Dagg Stompler
2016-07-24  5:56 ` [Buildroot] [PATCH 2/2 v4] odroid-mali: " Dagg Stompler
2016-07-24 12:44   ` Thomas Petazzoni
2016-07-24 13:29     ` daggs
2016-07-24 13:34       ` Thomas Petazzoni [this message]
2016-07-24 12:40 ` [Buildroot] [PATCH 1/2 v3] odroid-scripts: " Thomas Petazzoni
2016-07-24 13:26   ` daggs
2016-07-24 13:33     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160724153448.2e33f760@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox