From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] toolchain: add hidden symbol for PIE support
Date: Sun, 24 Jul 2016 21:47:40 +0200 [thread overview]
Message-ID: <20160724214740.10a2d059@free-electrons.com> (raw)
In-Reply-To: <ad24a697-55f9-aa38-4c26-dd81f9345e97@gmail.com>
Hello,
On Sun, 24 Jul 2016 17:06:17 +0200, Romain Naour wrote:
> > config BR2_TOOLCHAIN_USES_UCLIBC
> > bool
> > + select BR2_TOOLCHAIN_SUPPORTS_PIE if !BR2_arc && !BR2_m68k && !BR2_STATIC_LIBS
>
> It seems that we also need to black list ARM + uClibc + static linking config [1]
Isn't it blacklisted above? Waldemar's code will select
BR2_TOOLCHAIN_SUPPORTS_PIE only if we are not on ARC *and* we are not
on m68k *and* we are not static linking.
So if you're static linking, !BR2_arc && !BR2_m68k && !BR2_STATIC_LIBS
is false, and BR2_TOOLCHAIN_SUPPORTS_PIE is not selected.
> Also, what about a test in the toolchain helper to check PIE support is really
> available ?
Would be nice, but I'm not sure it's that easy: in practice a simple
executable will build with -fPIE on ARC, but more complicated piece of
code will not.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-07-24 19:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 14:35 [Buildroot] [PATCH v2] toolchain: add hidden symbol for PIE support Waldemar Brodkorb
2016-07-24 15:06 ` Romain Naour
2016-07-24 19:47 ` Thomas Petazzoni [this message]
2016-07-24 19:48 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160724214740.10a2d059@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox