From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] toolchain: add hidden symbol for PIE support
Date: Sun, 24 Jul 2016 21:48:24 +0200 [thread overview]
Message-ID: <20160724214824.57bf1db6@free-electrons.com> (raw)
In-Reply-To: <20160711143513.GA6072@waldemar-brodkorb.de>
Hello,
On Mon, 11 Jul 2016 16:35:14 +0200, Waldemar Brodkorb wrote:
> +ifneq ($(BR2_TOOLCHAIN_SUPPORTS_PIE),y)
I've changed to positive logic instead:
ifeq ($(BR2_TOOLCHAIN_SUPPORTS_PIE),)
> + USERCOMPILE="$(TARGET_CFLAGS) $(if $(BR2_TOOLCHAIN_SUPPORTS_PIE),-fPIE,)" \
> + USERLINK="$(TARGET_LDFLAGS) $(if $(BR2_TOOLCHAIN_SUPPORTS_PIE),-fPIE,)" \
The final comma was not needed.
Applied with those two changes. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-07-24 19:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 14:35 [Buildroot] [PATCH v2] toolchain: add hidden symbol for PIE support Waldemar Brodkorb
2016-07-24 15:06 ` Romain Naour
2016-07-24 19:47 ` Thomas Petazzoni
2016-07-24 19:48 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160724214824.57bf1db6@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox