From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] swupdate: allowed luajit to enable HAVE_LUA
Date: Mon, 25 Jul 2016 09:31:15 +0200 [thread overview]
Message-ID: <20160725093115.0d47ba9b@free-electrons.com> (raw)
In-Reply-To: <20160724232739.14132-2-jordan@yelloz.me>
Hello,
On Sun, 24 Jul 2016 16:27:36 -0700, Jordan Yelloz wrote:
> diff --git a/package/swupdate/swupdate.mk b/package/swupdate/swupdate.mk
> index 313a54febd87..7a0fcaea5741 100644
> --- a/package/swupdate/swupdate.mk
> +++ b/package/swupdate/swupdate.mk
> @@ -42,6 +42,9 @@ endif
> ifeq ($(BR2_PACKAGE_LUA),y)
> SWUPDATE_DEPENDENCIES += lua host-pkgconf
> SWUPDATE_MAKE_ENV += HAVE_LUA=y
> +else ifeq ($(BR2_PACKAGE_LUAJIT),y)
> +SWUPDATE_DEPENDENCIES += luajit host-pkgconf
> +SWUPDATE_MAKE_ENV += HAVE_LUA=y
If both luajit and classic lua are supported, then could you instead
use:
ifeq ($(BR2_PACKAGE_HAS_LUAINTERPRETER),y)
SWUPDATE_DEPENDENCIES += luainterpreter host-pkgconf
SWUPDATE_MAKE_ENV += HAVE_LUA=y
luainterpreter is a virtual package that automatically depends either
on lua or luajit, depending on which of the two is enabled in the
configuration.
Could you test this solution, and send an updated version of your patch?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-07-25 7:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-24 23:27 [Buildroot] [PATCH 0/4] swupdate: allow configuring with LuaJIT Jordan Yelloz
2016-07-24 23:27 ` [Buildroot] [PATCH 1/4] swupdate: allowed luajit to enable HAVE_LUA Jordan Yelloz
2016-07-25 7:31 ` Thomas Petazzoni [this message]
2016-07-25 16:46 ` Jordan Yelloz
2016-10-25 11:56 ` Thomas Petazzoni
2016-07-24 23:27 ` [Buildroot] [PATCH 2/4] swupdate: updated lua check for libconfig Jordan Yelloz
2016-07-29 16:15 ` Jörg Krause
2016-10-25 19:36 ` Thomas Petazzoni
2016-07-24 23:27 ` [Buildroot] [PATCH 3/4] swupdate: improved help text for Lua support Jordan Yelloz
2016-07-25 7:32 ` Thomas Petazzoni
2016-07-25 16:36 ` Jordan Yelloz
2016-07-29 16:14 ` Jörg Krause
2016-07-29 20:28 ` Jordan Yelloz
2016-10-25 19:43 ` Thomas Petazzoni
2016-07-24 23:27 ` [Buildroot] [PATCH 4/4] swupdate: added a warning for LuaJIT/Lua 5.1 Jordan Yelloz
2016-07-29 16:20 ` Jörg Krause
2016-07-29 16:32 ` Jordan Yelloz
2016-07-29 16:38 ` Jörg Krause
2016-10-25 19:43 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725093115.0d47ba9b@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox