Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] swupdate: added a warning for LuaJIT/Lua 5.1
Date: Tue, 25 Oct 2016 21:43:55 +0200	[thread overview]
Message-ID: <20161025214355.21a8d0d7@free-electrons.com> (raw)
In-Reply-To: <1469809234.3805.10.camel@embedded.rocks>

Hello,

On Fri, 29 Jul 2016 18:20:34 +0200, J?rg Krause wrote:

> > +if BR2_PACKAGE_LUA_5_1 || BR2_PACKAGE_LUAJIT
> > +comment "swupdate cannot use CONFIG_HANDLER_IN_LUA with Lua API <
> > 5.2."
> > +comment "Lua parsers and pre/post-install hooks should still
> > work.????"
> > +endif
> > +  
> 
> I would prefer to put this as a note in the help text.

Agreed. And it's actually in the help text now, thanks to PATCH 3/4 of
this series. See
https://git.buildroot.org/buildroot/commit/?id=02549bd9182f9d333dc47682d51c277786001467.

So I'll mark this PATCH 4/4 as Rejected.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      parent reply	other threads:[~2016-10-25 19:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-24 23:27 [Buildroot] [PATCH 0/4] swupdate: allow configuring with LuaJIT Jordan Yelloz
2016-07-24 23:27 ` [Buildroot] [PATCH 1/4] swupdate: allowed luajit to enable HAVE_LUA Jordan Yelloz
2016-07-25  7:31   ` Thomas Petazzoni
2016-07-25 16:46     ` Jordan Yelloz
2016-10-25 11:56   ` Thomas Petazzoni
2016-07-24 23:27 ` [Buildroot] [PATCH 2/4] swupdate: updated lua check for libconfig Jordan Yelloz
2016-07-29 16:15   ` Jörg Krause
2016-10-25 19:36   ` Thomas Petazzoni
2016-07-24 23:27 ` [Buildroot] [PATCH 3/4] swupdate: improved help text for Lua support Jordan Yelloz
2016-07-25  7:32   ` Thomas Petazzoni
2016-07-25 16:36     ` Jordan Yelloz
2016-07-29 16:14       ` Jörg Krause
2016-07-29 20:28         ` Jordan Yelloz
2016-10-25 19:43   ` Thomas Petazzoni
2016-07-24 23:27 ` [Buildroot] [PATCH 4/4] swupdate: added a warning for LuaJIT/Lua 5.1 Jordan Yelloz
2016-07-29 16:20   ` Jörg Krause
2016-07-29 16:32     ` Jordan Yelloz
2016-07-29 16:38       ` Jörg Krause
2016-10-25 19:43     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161025214355.21a8d0d7@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox