[Buildroot] [PATCH 1/3 v4] odroid-scripts: New Package.

[Buildroot] [PATCH 1/3 v4] odroid-scripts: New Package.

[Dagg Stompler]

Signed-off-by: Dagg Stompler <daggs@gmx.com>
---
v3 -> v4:
 - seperate setting of odroid-scripts from odroidc2 def config (Thomas Petazzoni).
 - fix udev bug so systemd will be supported too (Thomas Petazzoni).
 - fix udev rule install

v2 -> v3:
 - update repo rev to a252de04562dcf8d8a4918a544b45a9e3d46d2fb.
 - update hash

v1 -> v2:
 - fix hash type in hash file.

 package/Config.in                          |  1 +
 package/odroid-scripts/Config.in           |  7 +++++++
 package/odroid-scripts/S50odroidc2_fb      | 20 +++++++++++++++++++
 package/odroid-scripts/odroid-scripts.hash |  2 ++
 package/odroid-scripts/odroid-scripts.mk   | 32 ++++++++++++++++++++++++++++++
 5 files changed, 62 insertions(+)
 create mode 100644 package/odroid-scripts/Config.in
 create mode 100644 package/odroid-scripts/S50odroidc2_fb
 create mode 100644 package/odroid-scripts/odroid-scripts.hash
 create mode 100644 package/odroid-scripts/odroid-scripts.mk

diff --git a/package/Config.in b/package/Config.in
index 72c0be3..4529371 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1690,6 +1690,7 @@ menu "System tools"
 	source "package/ncdu/Config.in"
 	source "package/numactl/Config.in"
 	source "package/nut/Config.in"
+	source "package/odroid-scripts/Config.in"
 	source "package/openvmtools/Config.in"
 	source "package/polkit/Config.in"
 	source "package/powerpc-utils/Config.in"
diff --git a/package/odroid-scripts/Config.in b/package/odroid-scripts/Config.in
new file mode 100644
index 0000000..48544b6
--- /dev/null
+++ b/package/odroid-scripts/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_ODROID_SCRIPTS
+	bool "odroid-scripts"
+	depends on BR2_aarch64 || BR2_arm
+	help
+	  Install the scripts for the odroidc2 based systems.
+
+	  https://github.com/mdrjr/c2_bootini
diff --git a/package/odroid-scripts/S50odroidc2_fb b/package/odroid-scripts/S50odroidc2_fb
new file mode 100644
index 0000000..2aae59d
--- /dev/null
+++ b/package/odroid-scripts/S50odroidc2_fb
@@ -0,0 +1,20 @@
+#!/bin/sh
+#
+# Set up frame buffer
+#
+
+case "$1" in
+    start)
+        echo "Setting up display..."
+        /usr/sbin/odroidc2_init_fb.sh
+        ;;
+    stop)
+        ;;
+    restart|reload)
+        ;;
+    *)
+        echo "Usage: $0 {start|stop|restart}"
+        exit 1
+esac
+
+exit $?
diff --git a/package/odroid-scripts/odroid-scripts.hash b/package/odroid-scripts/odroid-scripts.hash
new file mode 100644
index 0000000..8fd4b2c
--- /dev/null
+++ b/package/odroid-scripts/odroid-scripts.hash
@@ -0,0 +1,2 @@
+#  Locally computed hash
+sha256 779e8beccf8c66d51e495a4cc0e6eccf72c295499a1ecdc0740aa4459de786a0 odroid-scripts-a252de04562dcf8d8a4918a544b45a9e3d46d2fb.tar.gz
diff --git a/package/odroid-scripts/odroid-scripts.mk b/package/odroid-scripts/odroid-scripts.mk
new file mode 100644
index 0000000..34a4501
--- /dev/null
+++ b/package/odroid-scripts/odroid-scripts.mk
@@ -0,0 +1,32 @@
+################################################################################
+#
+# odroid-scripts
+#
+################################################################################
+
+ODROID_SCRIPTS_VERSION = a252de04562dcf8d8a4918a544b45a9e3d46d2fb
+ODROID_SCRIPTS_SITE = $(call github,mdrjr,c2_bootini,$(ODROID_SCRIPTS_VERSION))
+ODROID_SCRIPTS_LICENSE = unclear
+
+ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
+	define ODROID_SCRIPTS_INSTALL_UDEV_RULES
+		$(INSTALL) -D -m 0644 $(@D)/10-odroid.rules $(TARGET_DIR)/etc/udev/rules.d/10-odroid.rules
+	endef
+endif
+
+define ODROID_SCRIPTS_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/c2_init.sh $(TARGET_DIR)/usr/sbin/odroidc2_init_fb.sh
+	$(ODROID_SCRIPTS_INSTALL_UDEV_RULES)
+endef
+
+define ODROID_SCRIPTS_INSTALL_INIT_SYSTEMD
+	$(INSTALL) -D -m 0644 $(@D)/amlogic.service $(TARGET_DIR)/usr/lib/systemd/system/odroidc2_fb.service
+	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
+	ln -fs ../../../../usr/lib/systemd/system/odroidc2_fb.service $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/odroidc2_fb.service
+endef
+
+define ODROID_SCRIPTS_INSTALL_INIT_SYSV
+	$(INSTALL) -D -m 0755 package/odroid-scripts/S50odroidc2_fb $(TARGET_DIR)/etc/init.d/S50odroidc2_fb
+endef
+
+$(eval $(generic-package))
-- 
2.9.2

[Buildroot] [PATCH 2/3] odroid: select odroid-scripts for odroidc2 defconfig

[Dagg Stompler]

Signed-off-by: Dagg Stompler <daggs@gmx.com>
---
 configs/odroidc2_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/odroidc2_defconfig b/configs/odroidc2_defconfig
index 43c2787..45ede62 100644
--- a/configs/odroidc2_defconfig
+++ b/configs/odroidc2_defconfig
@@ -6,6 +6,7 @@ BR2_TARGET_GENERIC_HOSTNAME="odroidc2"
 BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_EXT2_4=y
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/hardkernel/odroidc2/post-image.sh"
+BR2_PACKAGE_ODROID_SCRIPTS=y
 
 # Kernel
 BR2_KERNEL_HEADERS_VERSION=y
-- 
2.9.2

[Buildroot] [PATCH 2/3] odroid: select odroid-scripts for odroidc2 defconfig

[Thomas Petazzoni]

Hello,

On Sun, 24 Jul 2016 19:35:05 +0300, Dagg Stompler wrote:
> Signed-off-by: Dagg Stompler <daggs@gmx.com>
> ---
>  configs/odroidc2_defconfig | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 3/3 v5] odroid-mali: New Package

[Dagg Stompler]

Signed-off-by: Dagg Stompler <daggs@gmx.com>
---
v4 -> v5:
 - fix license (Thomas Petazzoni).
 - select odroid-scripts if this pkg is selected instead of depends (Thomas Petazzoni).
 - fix lib install path to include /usr and remove it from the call (Thomas Petazzoni).
 - replace install of multiple files with the proper cp command (Thomas Petazzoni).
 - use the proper cp command for headers and libs (Thomas Petazzoni).

v3 -> v4:
 - update repo rev to 46fe49f37e3506c6205ad8c50980eca9bfff11e3.
 - update hash
 - 32 and 64 bit flavors can now use the same repo rev.

v2 -> v3:
 - fix pkgconfig installation.

v1 -> v2:
 - added hash for 32 bits revision.
 - fix file permissions for S50odroidc2_fb and odroidc2_init_fb.sh

 package/Config.in                    |  1 +
 package/odroid-mali/Config.in        | 21 +++++++++++++++++++++
 package/odroid-mali/odroid-mali.hash |  2 ++
 package/odroid-mali/odroid-mali.mk   | 36 ++++++++++++++++++++++++++++++++++++
 4 files changed, 60 insertions(+)
 create mode 100644 package/odroid-mali/Config.in
 create mode 100644 package/odroid-mali/odroid-mali.hash
 create mode 100644 package/odroid-mali/odroid-mali.mk

diff --git a/package/Config.in b/package/Config.in
index 4529371..3c2515f 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -414,6 +414,7 @@ endmenu
 	source "package/nvidia-driver/Config.in"
 	source "package/nvidia-tegra23/Config.in"
 	source "package/nvme/Config.in"
+	source "package/odroid-mali/Config.in"
 	source "package/ofono/Config.in"
 	source "package/ola/Config.in"
 	source "package/on2-8170-modules/Config.in"
diff --git a/package/odroid-mali/Config.in b/package/odroid-mali/Config.in
new file mode 100644
index 0000000..a648f03
--- /dev/null
+++ b/package/odroid-mali/Config.in
@@ -0,0 +1,21 @@
+config BR2_PACKAGE_ODROID_MALI
+	bool "odroid-mali"
+	select BR2_PACKAGE_HAS_LIBEGL
+	select BR2_PACKAGE_HAS_LIBGLES
+	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
+	select BR2_PACKAGE_FBSET
+	select BR2_PACKAGE_ODROID_SCRIPTS
+	depends on BR2_TOOLCHAIN_USES_GLIBC
+	depends on BR2_aarch64 || BR2_arm
+	help
+	  Install the ARM Mali drivers for odroidc2 based systems.
+
+	  https://github.com/mdrjr/c2_mali
+
+if BR2_PACKAGE_ODROID_MALI
+config BR2_PACKAGE_PROVIDES_LIBEGL
+	default "odroid-mali"
+
+config BR2_PACKAGE_PROVIDES_LIBGLES
+	default "odroid-mali"
+endif
diff --git a/package/odroid-mali/odroid-mali.hash b/package/odroid-mali/odroid-mali.hash
new file mode 100644
index 0000000..4d24824
--- /dev/null
+++ b/package/odroid-mali/odroid-mali.hash
@@ -0,0 +1,2 @@
+# Locally computed hash
+sha256 29d98ed4b8694b860d9289787c416faa847b0de26d36580a53add1752b4c2e9a  odroid-mali-46fe49f37e3506c6205ad8c50980eca9bfff11e3.tar.gz
diff --git a/package/odroid-mali/odroid-mali.mk b/package/odroid-mali/odroid-mali.mk
new file mode 100644
index 0000000..c13e445
--- /dev/null
+++ b/package/odroid-mali/odroid-mali.mk
@@ -0,0 +1,36 @@
+################################################################################
+#
+# odroid-mali
+#
+################################################################################
+
+ODROID_MALI_VERSION = 46fe49f37e3506c6205ad8c50980eca9bfff11e3
+ODROID_MALI_SITE = $(call github,mdrjr,c2_mali,$(ODROID_MALI_VERSION))
+ODROID_MALI_LICENSE = Hardkernel EULA
+ODROID_MALI_LICENSE_FILES = README.md
+
+ODROID_MALI_INSTALL_STAGING = YES
+ODROID_MALI_PROVIDES = libegl libgles
+
+ifeq ($(BR2_aarch64),y)
+ODROID_MALI_LIBS_INSTALL_ARCH=mali_libs
+else
+ODROID_MALI_LIBS_INSTALL_ARCH=32bit_libs
+endif
+
+define ODROID_MALI_INSTALL_LIBS
+	cp -dpfr $(@D)/fbdev/$(ODROID_MALI_LIBS_INSTALL_ARCH)/lib* $(1)/usr/lib/
+endef
+
+define ODROID_MALI_INSTALL_STAGING_CMDS
+	$(call ODROID_MALI_INSTALL_LIBS,$(STAGING_DIR))
+	$(INSTALL) -d $(STAGING_DIR)/usr/lib/pkgconfig
+	cp -dpfr $(@D)/pkgconfig/*.pc $(STAGING_DIR)/usr/lib/pkgconfig/
+	cp -dpfr $(@D)/fbdev/mali_headers/* $(STAGING_DIR)/usr/include
+endef
+
+define ODROID_MALI_INSTALL_TARGET_CMDS
+	$(call ODROID_MALI_INSTALL_LIBS,$(TARGET_DIR))
+endef
+
+$(eval $(generic-package))
-- 
2.9.2

[Buildroot] [PATCH 3/3 v5] odroid-mali: New Package

[Thomas Petazzoni]

Hello,

On Sun, 24 Jul 2016 19:35:06 +0300, Dagg Stompler wrote:
> diff --git a/package/odroid-mali/Config.in b/package/odroid-mali/Config.in
> new file mode 100644
> index 0000000..a648f03
> --- /dev/null
> +++ b/package/odroid-mali/Config.in
> @@ -0,0 +1,21 @@
> +config BR2_PACKAGE_ODROID_MALI
> +	bool "odroid-mali"
> +	select BR2_PACKAGE_HAS_LIBEGL
> +	select BR2_PACKAGE_HAS_LIBGLES
> +	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> +	select BR2_PACKAGE_FBSET

fbset is not used by odroid-mali, it's used by odroid-scripts, so this
dependency should be in odroid-scripts. So I've dropped those two lines
from here. Could you send a patch that adds the dependency to
odroid-scripts?

> +	select BR2_PACKAGE_ODROID_SCRIPTS

I've added a comment that indicates it's a runtime dependency.

> +	depends on BR2_TOOLCHAIN_USES_GLIBC

I've added a Config.in comment that helps the user to know that
odroid-mali needs glibc.

> +	depends on BR2_aarch64 || BR2_arm

On ARM, the prebuilt libraries use the EABIhf ABI, so I've changed
BR2_arm to BR2_ARM_EABIHF.

It's worth mentioning that for AArch64, this repo contains the OpenGL
libraries for X11. If you have the opportunity to test them, it would
be nice to add support for them.

> +ifeq ($(BR2_aarch64),y)
> +ODROID_MALI_LIBS_INSTALL_ARCH=mali_libs

I've changed this to:

ODROID_MALI_INSTALL_ARCH = mali_libs

I.e, simplified the name of the variable, and added spaces around the
equal sign.

Applied with those changes. Thanks! 

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 3/3 v5] odroid-mali: New Package

[daggs]

Greetings
>
> Hello,
> 
> On Sun, 24 Jul 2016 19:35:06 +0300, Dagg Stompler wrote:
> > diff --git a/package/odroid-mali/Config.in b/package/odroid-mali/Config.in
> > new file mode 100644
> > index 0000000..a648f03
> > --- /dev/null
> > +++ b/package/odroid-mali/Config.in
> > @@ -0,0 +1,21 @@
> > +config BR2_PACKAGE_ODROID_MALI
> > +	bool "odroid-mali"
> > +	select BR2_PACKAGE_HAS_LIBEGL
> > +	select BR2_PACKAGE_HAS_LIBGLES
> > +	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> > +	select BR2_PACKAGE_FBSET
> 
> fbset is not used by odroid-mali, it's used by odroid-scripts, so this
> dependency should be in odroid-scripts. So I've dropped those two lines
> from here. Could you send a patch that adds the dependency to
> odroid-scripts?

you are correct, will send a new patch.

> 
> > +	select BR2_PACKAGE_ODROID_SCRIPTS
> 
> I've added a comment that indicates it's a runtime dependency.
> 
> > +	depends on BR2_TOOLCHAIN_USES_GLIBC
> 
> I've added a Config.in comment that helps the user to know that
> odroid-mali needs glibc.
> 
> > +	depends on BR2_aarch64 || BR2_arm
> 
> On ARM, the prebuilt libraries use the EABIhf ABI, so I've changed
> BR2_arm to BR2_ARM_EABIHF.
> 
> It's worth mentioning that for AArch64, this repo contains the OpenGL
> libraries for X11. If you have the opportunity to test them, it would
> be nice to add support for them.

I wanted to test it with kodi but 16 doesn't support aarch64.
there is a DDX driver for X which I intend to add as soon as I understand how to build it.

> 
> > +ifeq ($(BR2_aarch64),y)
> > +ODROID_MALI_LIBS_INSTALL_ARCH=mali_libs
> 
> I've changed this to:
> 
> ODROID_MALI_INSTALL_ARCH = mali_libs
> 
> I.e, simplified the name of the variable, and added spaces around the
> equal sign.
> 
> Applied with those changes. Thanks! 
> 
> Thomas

Dagg

[Buildroot] [PATCH 3/3 v5] odroid-mali: New Package

[Thomas Petazzoni]

Hello,

On Mon, 25 Jul 2016 19:59:33 +0200, daggs wrote:

> > fbset is not used by odroid-mali, it's used by odroid-scripts, so this
> > dependency should be in odroid-scripts. So I've dropped those two lines
> > from here. Could you send a patch that adds the dependency to
> > odroid-scripts?  
> 
> you are correct, will send a new patch.

Great, thanks!

> > It's worth mentioning that for AArch64, this repo contains the OpenGL
> > libraries for X11. If you have the opportunity to test them, it would
> > be nice to add support for them.  
> 
> I wanted to test it with kodi but 16 doesn't support aarch64.
> there is a DDX driver for X which I intend to add as soon as I understand how to build it.

Good, thanks! Note that Bernd has a branch with Kodi 17, if you want to
test it.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 3/3 v5] odroid-mali: New Package

[daggs]

Greetings,
> Hello,
> 
> On Mon, 25 Jul 2016 19:59:33 +0200, daggs wrote:
> 
> > > fbset is not used by odroid-mali, it's used by odroid-scripts, so this
> > > dependency should be in odroid-scripts. So I've dropped those two lines
> > > from here. Could you send a patch that adds the dependency to
> > > odroid-scripts?  
> > 
> > you are correct, will send a new patch.
> 
> Great, thanks!
> 
> > > It's worth mentioning that for AArch64, this repo contains the OpenGL
> > > libraries for X11. If you have the opportunity to test them, it would
> > > be nice to add support for them.  
> > 
> > I wanted to test it with kodi but 16 doesn't support aarch64.
> > there is a DDX driver for X which I intend to add as soon as I understand how to build it.
> 
> Good, thanks! Note that Bernd has a branch with Kodi 17, if you want to
> test it.

as it is still in RC/Beta, I'd rather not, will wait for the official release.

> 
> Best regards,
> 
> Thomas

Dagg.

[Buildroot] [PATCH 1/3 v4] odroid-scripts: New Package.

[Thomas Petazzoni]

Hello,

On Sun, 24 Jul 2016 19:35:04 +0300, Dagg Stompler wrote:
> Signed-off-by: Dagg Stompler <daggs@gmx.com>

Thanks, I've applied with a few minor changes, see below.

> diff --git a/package/Config.in b/package/Config.in
> index 72c0be3..4529371 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1690,6 +1690,7 @@ menu "System tools"
>  	source "package/ncdu/Config.in"
>  	source "package/numactl/Config.in"
>  	source "package/nut/Config.in"
> +	source "package/odroid-scripts/Config.in"

I've moved to "Hardware handling" instead of "System tools".

> diff --git a/package/odroid-scripts/odroid-scripts.mk b/package/odroid-scripts/odroid-scripts.mk
> new file mode 100644
> index 0000000..34a4501
> --- /dev/null
> +++ b/package/odroid-scripts/odroid-scripts.mk
> @@ -0,0 +1,32 @@
> +################################################################################
> +#
> +# odroid-scripts
> +#
> +################################################################################
> +
> +ODROID_SCRIPTS_VERSION = a252de04562dcf8d8a4918a544b45a9e3d46d2fb
> +ODROID_SCRIPTS_SITE = $(call github,mdrjr,c2_bootini,$(ODROID_SCRIPTS_VERSION))
> +ODROID_SCRIPTS_LICENSE = unclear
> +
> +ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
> +	define ODROID_SCRIPTS_INSTALL_UDEV_RULES

We typically do not indent such lines.

> +		$(INSTALL) -D -m 0644 $(@D)/10-odroid.rules $(TARGET_DIR)/etc/udev/rules.d/10-odroid.rules

I've split this line.

> +	endef
> +endif
> +
> +define ODROID_SCRIPTS_INSTALL_TARGET_CMDS
> +	$(INSTALL) -D -m 0755 $(@D)/c2_init.sh $(TARGET_DIR)/usr/sbin/odroidc2_init_fb.sh
> +	$(ODROID_SCRIPTS_INSTALL_UDEV_RULES)
> +endef
> +
> +define ODROID_SCRIPTS_INSTALL_INIT_SYSTEMD
> +	$(INSTALL) -D -m 0644 $(@D)/amlogic.service $(TARGET_DIR)/usr/lib/systemd/system/odroidc2_fb.service
> +	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
> +	ln -fs ../../../../usr/lib/systemd/system/odroidc2_fb.service $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/odroidc2_fb.service

Those long lines as well.

> +endef
> +
> +define ODROID_SCRIPTS_INSTALL_INIT_SYSV
> +	$(INSTALL) -D -m 0755 package/odroid-scripts/S50odroidc2_fb $(TARGET_DIR)/etc/init.d/S50odroidc2_fb

And this one as well.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/3 v4] odroid-scripts: New Package.

[daggs]

Greetings,

> Hello,
> 
> On Sun, 24 Jul 2016 19:35:04 +0300, Dagg Stompler wrote:
> > Signed-off-by: Dagg Stompler <daggs@gmx.com>
> 
> Thanks, I've applied with a few minor changes, see below.
> 
> > diff --git a/package/Config.in b/package/Config.in
> > index 72c0be3..4529371 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -1690,6 +1690,7 @@ menu "System tools"
> >  	source "package/ncdu/Config.in"
> >  	source "package/numactl/Config.in"
> >  	source "package/nut/Config.in"
> > +	source "package/odroid-scripts/Config.in"
> 
> I've moved to "Hardware handling" instead of "System tools".

it was placed originally in Hardware handling, not sure how it ended up at System tools.

> 
> > diff --git a/package/odroid-scripts/odroid-scripts.mk b/package/odroid-scripts/odroid-scripts.mk
> > new file mode 100644
> > index 0000000..34a4501
> > --- /dev/null
> > +++ b/package/odroid-scripts/odroid-scripts.mk
> > @@ -0,0 +1,32 @@
> > +################################################################################
> > +#
> > +# odroid-scripts
> > +#
> > +################################################################################
> > +
> > +ODROID_SCRIPTS_VERSION = a252de04562dcf8d8a4918a544b45a9e3d46d2fb
> > +ODROID_SCRIPTS_SITE = $(call github,mdrjr,c2_bootini,$(ODROID_SCRIPTS_VERSION))
> > +ODROID_SCRIPTS_LICENSE = unclear
> > +
> > +ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
> > +	define ODROID_SCRIPTS_INSTALL_UDEV_RULES
> 
> We typically do not indent such lines.
> 
> > +		$(INSTALL) -D -m 0644 $(@D)/10-odroid.rules $(TARGET_DIR)/etc/udev/rules.d/10-odroid.rules
> 
> I've split this line.
> 
> > +	endef
> > +endif
> > +
> > +define ODROID_SCRIPTS_INSTALL_TARGET_CMDS
> > +	$(INSTALL) -D -m 0755 $(@D)/c2_init.sh $(TARGET_DIR)/usr/sbin/odroidc2_init_fb.sh
> > +	$(ODROID_SCRIPTS_INSTALL_UDEV_RULES)
> > +endef
> > +
> > +define ODROID_SCRIPTS_INSTALL_INIT_SYSTEMD
> > +	$(INSTALL) -D -m 0644 $(@D)/amlogic.service $(TARGET_DIR)/usr/lib/systemd/system/odroidc2_fb.service
> > +	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
> > +	ln -fs ../../../../usr/lib/systemd/system/odroidc2_fb.service $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/odroidc2_fb.service
> 
> Those long lines as well.
> 
> > +endef
> > +
> > +define ODROID_SCRIPTS_INSTALL_INIT_SYSV
> > +	$(INSTALL) -D -m 0755 package/odroid-scripts/S50odroidc2_fb $(TARGET_DIR)/etc/init.d/S50odroidc2_fb
> 
> And this one as well.
> 
> Thanks!
> 
> Thomas

ok, thanks for the help.

Dagg.