[Buildroot] [PATCH] binutils: fix bfin problem

[Buildroot] [PATCH] binutils: fix bfin problem

[Waldemar Brodkorb]

Fix for LINKER BUG: .rofixup section size mismatch problems.

Bug was already reported by Stuart Henderson to binutils upstream:
https://sourceware.org/bugzilla/show_bug.cgi?id=13391

Fixes:
http://autobuild.buildroot.net/results/d5999ae91a1f4dee3d01a0bbc3d8a4c5939ad175/
http://autobuild.buildroot.net/results/17232204249aeb04150ac43a2424aa26a6b6c807/

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 package/binutils/2.26.1/0905-bfin-rofixup-bug.patch | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 package/binutils/2.26.1/0905-bfin-rofixup-bug.patch

diff --git a/package/binutils/2.26.1/0905-bfin-rofixup-bug.patch b/package/binutils/2.26.1/0905-bfin-rofixup-bug.patch
new file mode 100644
index 0000000..da9d586
--- /dev/null
+++ b/package/binutils/2.26.1/0905-bfin-rofixup-bug.patch
@@ -0,0 +1,21 @@
+Fixes: LINKER BUG: .rofixup section size mismatch
+
+Workaround from adi-toolchain commit:
+af414ec1fb628ddb1562f062f3db49823ca14ca2
+[#6798] binutils-2.21/bfd: temp workaround for rofixup mismatch errors.
+
+Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
+
+diff -Nur binutils-2.26.1.orig/bfd/elf32-bfin.c binutils-2.26.1/bfd/elf32-bfin.c
+--- binutils-2.26.1.orig/bfd/elf32-bfin.c	2015-11-13 09:27:40.000000000 +0100
++++ binutils-2.26.1/bfd/elf32-bfin.c	2016-07-31 00:50:48.357995132 +0200
+@@ -4879,7 +4879,8 @@
+ 
+ 	case R_BFIN_FUNCDESC:
+ 	  picrel->fd++;
+-	  picrel->relocsfd++;
++	  if (bfd_get_section_flags (abfd, sec) & SEC_ALLOC)
++	    picrel->relocsfd++;
+ 	  break;
+ 
+         /* This relocation describes the C++ object vtable hierarchy.
-- 
2.1.4

[Buildroot] [PATCH] binutils: fix bfin problem

[Thomas Petazzoni]

Hello,

On Sun, 31 Jul 2016 10:26:20 +0200, Waldemar Brodkorb wrote:
> Fix for LINKER BUG: .rofixup section size mismatch problems.
> 
> Bug was already reported by Stuart Henderson to binutils upstream:
> https://sourceware.org/bugzilla/show_bug.cgi?id=13391

The bug dates back from 2011, and nobody cared. Does this mean that we
will have to carry this "temporary workaround" forever in Buildroot?

I've applied your patch, but I must say I'm not too happy to see this
kind of things being added :-/

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] binutils: fix bfin problem

[Waldemar Brodkorb]

Hi Thomas,
Thomas Petazzoni wrote,

> Hello,
> 
> On Sun, 31 Jul 2016 10:26:20 +0200, Waldemar Brodkorb wrote:
> > Fix for LINKER BUG: .rofixup section size mismatch problems.
> > 
> > Bug was already reported by Stuart Henderson to binutils upstream:
> > https://sourceware.org/bugzilla/show_bug.cgi?id=13391
> 
> The bug dates back from 2011, and nobody cared. Does this mean that we
> will have to carry this "temporary workaround" forever in Buildroot?
> 
> I've applied your patch, but I must say I'm not too happy to see this
> kind of things being added :-/
> 
> Thanks,

I am subscribed to binutils/gcc mailinglists and managed to already
get some simple bugfixes added. But the times to get fixes in, might
take some time. 

best regards
 Waldemar

[Buildroot] [PATCH] binutils: fix bfin problem

[Thomas Petazzoni]

Hello,

On Fri, 5 Aug 2016 21:22:37 +0200, Waldemar Brodkorb wrote:

> I am subscribed to binutils/gcc mailinglists and managed to already
> get some simple bugfixes added. But the times to get fixes in, might
> take some time. 

I am not worried at all if things take time. Even if it takes 6 or 12
months, that's fine.

What worries me if it *never* gets fixed, because nobody works on it.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com