* [Buildroot] [PATCH 1/1] package/libsidplay2: broken with gcc6
@ 2016-08-09 19:44 Bernd Kuhls
2016-08-09 19:51 ` Yann E. MORIN
2016-08-09 19:52 ` Khem Raj
0 siblings, 2 replies; 6+ messages in thread
From: Bernd Kuhls @ 2016-08-09 19:44 UTC (permalink / raw)
To: buildroot
Also propagate reverse dependency to kodi-audiodecoder-sidplay.
Fixes
http://autobuild.buildroot.net/results/4f5/4f57a7a37da0ce6d14a368272d982b4874a54927/
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/kodi-audiodecoder-sidplay/Config.in | 1 +
package/libsidplay2/Config.in | 2 ++
2 files changed, 3 insertions(+)
diff --git a/package/kodi-audiodecoder-sidplay/Config.in b/package/kodi-audiodecoder-sidplay/Config.in
index ae99afa..db47a9c 100644
--- a/package/kodi-audiodecoder-sidplay/Config.in
+++ b/package/kodi-audiodecoder-sidplay/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_KODI_AUDIODECODER_SIDPLAY
bool "kodi-audiodecoder-sidplay"
+ depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_6 # libsidplay2
select BR2_PACKAGE_KODI_PLATFORM
select BR2_PACKAGE_LIBSIDPLAY2
help
diff --git a/package/libsidplay2/Config.in b/package/libsidplay2/Config.in
index 5698367..34fa7f7 100644
--- a/package/libsidplay2/Config.in
+++ b/package/libsidplay2/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_LIBSIDPLAY2
bool "libsidplay2"
depends on BR2_INSTALL_LIBSTDCPP
+ depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_6
help
Sidplay 2 is the second in the Sidplay series originally developed by
Michael Schwendt. This version is written by Simon White and is cycle
@@ -10,4 +11,5 @@ config BR2_PACKAGE_LIBSIDPLAY2
http://sourceforge.net/projects/sidplay2
comment "libsidplay2 needs a toolchain w/ C++"
+ depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_6
depends on !BR2_INSTALL_LIBSTDCPP
--
2.8.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/libsidplay2: broken with gcc6
2016-08-09 19:44 [Buildroot] [PATCH 1/1] package/libsidplay2: broken with gcc6 Bernd Kuhls
@ 2016-08-09 19:51 ` Yann E. MORIN
2016-08-09 19:52 ` Khem Raj
1 sibling, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2016-08-09 19:51 UTC (permalink / raw)
To: buildroot
Bernd, All,
On 2016-08-09 21:44 +0200, Bernd Kuhls spake thusly:
> Also propagate reverse dependency to kodi-audiodecoder-sidplay.
>
> Fixes
> http://autobuild.buildroot.net/results/4f5/4f57a7a37da0ce6d14a368272d982b4874a54927/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/kodi-audiodecoder-sidplay/Config.in | 1 +
> package/libsidplay2/Config.in | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/package/kodi-audiodecoder-sidplay/Config.in b/package/kodi-audiodecoder-sidplay/Config.in
> index ae99afa..db47a9c 100644
> --- a/package/kodi-audiodecoder-sidplay/Config.in
> +++ b/package/kodi-audiodecoder-sidplay/Config.in
> @@ -1,5 +1,6 @@
> config BR2_PACKAGE_KODI_AUDIODECODER_SIDPLAY
> bool "kodi-audiodecoder-sidplay"
> + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_6 # libsidplay2
> select BR2_PACKAGE_KODI_PLATFORM
> select BR2_PACKAGE_LIBSIDPLAY2
> help
You need to add a comment there:
comment "kodi-audiodecoder-sidplay needs a toolchain w/ gcc < 6"
depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_6
> diff --git a/package/libsidplay2/Config.in b/package/libsidplay2/Config.in
> index 5698367..34fa7f7 100644
> --- a/package/libsidplay2/Config.in
> +++ b/package/libsidplay2/Config.in
> @@ -1,6 +1,7 @@
> config BR2_PACKAGE_LIBSIDPLAY2
> bool "libsidplay2"
> depends on BR2_INSTALL_LIBSTDCPP
> + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_6
> help
> Sidplay 2 is the second in the Sidplay series originally developed by
> Michael Schwendt. This version is written by Simon White and is cycle
> @@ -10,4 +11,5 @@ config BR2_PACKAGE_LIBSIDPLAY2
> http://sourceforge.net/projects/sidplay2
>
> comment "libsidplay2 needs a toolchain w/ C++"
> + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_6
> depends on !BR2_INSTALL_LIBSTDCPP
I guess this dependency should have been:
comment "libsidplay2 needs a toolchain w/ gcc <6, C++"
depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_6 \
|| !BR2_INSTALL_LIBSTDCPP
Becasue this is not an architecture feature: the user can actually
change something (i.i. either the gcc version or choose another
toolchain).
Regards,
Yann E. MORIN.
> --
> 2.8.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] package/libsidplay2: broken with gcc6
2016-08-09 19:44 [Buildroot] [PATCH 1/1] package/libsidplay2: broken with gcc6 Bernd Kuhls
2016-08-09 19:51 ` Yann E. MORIN
@ 2016-08-09 19:52 ` Khem Raj
2016-08-09 20:04 ` Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Khem Raj @ 2016-08-09 19:52 UTC (permalink / raw)
To: buildroot
> On Aug 9, 2016, at 12:44 PM, Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
>
> Also propagate reverse dependency to kodi-audiodecoder-sidplay.
>
> Fixes
> http://autobuild.buildroot.net/results/4f5/4f57a7a37da0ce6d14a368272d982b4874a54927/
This could also be fixed in code instead to statically typecast to int8_t.
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/kodi-audiodecoder-sidplay/Config.in | 1 +
> package/libsidplay2/Config.in | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/package/kodi-audiodecoder-sidplay/Config.in b/package/kodi-audiodecoder-sidplay/Config.in
> index ae99afa..db47a9c 100644
> --- a/package/kodi-audiodecoder-sidplay/Config.in
> +++ b/package/kodi-audiodecoder-sidplay/Config.in
> @@ -1,5 +1,6 @@
> config BR2_PACKAGE_KODI_AUDIODECODER_SIDPLAY
> bool "kodi-audiodecoder-sidplay"
> + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_6 # libsidplay2
> select BR2_PACKAGE_KODI_PLATFORM
> select BR2_PACKAGE_LIBSIDPLAY2
> help
> diff --git a/package/libsidplay2/Config.in b/package/libsidplay2/Config.in
> index 5698367..34fa7f7 100644
> --- a/package/libsidplay2/Config.in
> +++ b/package/libsidplay2/Config.in
> @@ -1,6 +1,7 @@
> config BR2_PACKAGE_LIBSIDPLAY2
> bool "libsidplay2"
> depends on BR2_INSTALL_LIBSTDCPP
> + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_6
> help
> Sidplay 2 is the second in the Sidplay series originally developed by
> Michael Schwendt. This version is written by Simon White and is cycle
> @@ -10,4 +11,5 @@ config BR2_PACKAGE_LIBSIDPLAY2
> http://sourceforge.net/projects/sidplay2
>
> comment "libsidplay2 needs a toolchain w/ C++"
> + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_6
> depends on !BR2_INSTALL_LIBSTDCPP
> --
> 2.8.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 204 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160809/d0ab9b67/attachment.asc>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/libsidplay2: broken with gcc6
2016-08-09 19:52 ` Khem Raj
@ 2016-08-09 20:04 ` Thomas Petazzoni
2016-08-09 20:15 ` Bernd Kuhls
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2016-08-09 20:04 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 9 Aug 2016 12:52:29 -0700, Khem Raj wrote:
> > On Aug 9, 2016, at 12:44 PM, Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> >
> > Also propagate reverse dependency to kodi-audiodecoder-sidplay.
> >
> > Fixes
> > http://autobuild.buildroot.net/results/4f5/4f57a7a37da0ce6d14a368272d982b4874a54927/
>
> This could also be fixed in code instead to statically typecast to int8_t.
I would also very much prefer to see the code being fixed, rather than
this weird !AT_LEAST_GCC_6 dependency being added.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/libsidplay2: broken with gcc6
2016-08-09 20:04 ` Thomas Petazzoni
@ 2016-08-09 20:15 ` Bernd Kuhls
2016-08-09 20:57 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Bernd Kuhls @ 2016-08-09 20:15 UTC (permalink / raw)
To: buildroot
Am Tue, 09 Aug 2016 22:04:19 +0200 schrieb Thomas Petazzoni:
> Hello,
>
> On Tue, 9 Aug 2016 12:52:29 -0700, Khem Raj wrote:
>> This could also be fixed in code instead to statically typecast to int8_t.
>
> I would also very much prefer to see the code being fixed, rather than
> this weird !AT_LEAST_GCC_6 dependency being added.
Hi Thomas,
ok, but I am unable to provide such a patch because I
do not know what to code to fix the C stuff ;)
Regards, Bernd
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/libsidplay2: broken with gcc6
2016-08-09 20:15 ` Bernd Kuhls
@ 2016-08-09 20:57 ` Khem Raj
0 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2016-08-09 20:57 UTC (permalink / raw)
To: buildroot
> On Aug 9, 2016, at 1:15 PM, Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
>
> Am Tue, 09 Aug 2016 22:04:19 +0200 schrieb Thomas Petazzoni:
>
>> Hello,
>>
>> On Tue, 9 Aug 2016 12:52:29 -0700, Khem Raj wrote:
>
>>> This could also be fixed in code instead to statically typecast to int8_t.
>>
>> I would also very much prefer to see the code being fixed, rather than
>> this weird !AT_LEAST_GCC_6 dependency being added.
>
> Hi Thomas,
>
> ok, but I am unable to provide such a patch because I
> do not know what to code to fix the C stuff ;)
>
perhaps changing https://sourceforge.net/p/sidplay2/code/HEAD/tree/trunk/libsidplay/src/xsid/xsid.cpp#l118
to be a char array instead of uint8_t would help ?
> Regards, Bernd
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 204 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160809/d99fee2f/attachment.asc>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-09 20:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-09 19:44 [Buildroot] [PATCH 1/1] package/libsidplay2: broken with gcc6 Bernd Kuhls
2016-08-09 19:51 ` Yann E. MORIN
2016-08-09 19:52 ` Khem Raj
2016-08-09 20:04 ` Thomas Petazzoni
2016-08-09 20:15 ` Bernd Kuhls
2016-08-09 20:57 ` Khem Raj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox