* [Buildroot] [PATCH] barebox: fix ARCH value for arm64
@ 2016-08-12 11:11 Raphael Poggi
2016-08-12 12:32 ` Baruch Siach
0 siblings, 1 reply; 5+ messages in thread
From: Raphael Poggi @ 2016-08-12 11:11 UTC (permalink / raw)
To: buildroot
Signed-off-by: Raphael Poggi <poggi.raph@gmail.com>
---
boot/barebox/barebox.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/boot/barebox/barebox.mk b/boot/barebox/barebox.mk
index 832297e..b02751d 100644
--- a/boot/barebox/barebox.mk
+++ b/boot/barebox/barebox.mk
@@ -61,6 +61,8 @@ else ifeq ($$(KERNEL_ARCH),x86_64)
$(1)_ARCH = x86
else ifeq ($$(KERNEL_ARCH),powerpc)
$(1)_ARCH = ppc
+else ifeq ($$(KERNEL_ARCH), arm64)
+$(1)_ARCH = arm
else
$(1)_ARCH = $$(KERNEL_ARCH)
endif
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] barebox: fix ARCH value for arm64
2016-08-12 11:11 [Buildroot] [PATCH] barebox: fix ARCH value for arm64 Raphael Poggi
@ 2016-08-12 12:32 ` Baruch Siach
2016-08-12 12:52 ` Raphaël Poggi
0 siblings, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2016-08-12 12:32 UTC (permalink / raw)
To: buildroot
Hi Raphael,
On Fri, Aug 12, 2016 at 01:11:26PM +0200, Raphael Poggi wrote:
> Signed-off-by: Raphael Poggi <poggi.raph@gmail.com>
> ---
> boot/barebox/barebox.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/boot/barebox/barebox.mk b/boot/barebox/barebox.mk
> index 832297e..b02751d 100644
> --- a/boot/barebox/barebox.mk
> +++ b/boot/barebox/barebox.mk
> @@ -61,6 +61,8 @@ else ifeq ($$(KERNEL_ARCH),x86_64)
> $(1)_ARCH = x86
> else ifeq ($$(KERNEL_ARCH),powerpc)
> $(1)_ARCH = ppc
> +else ifeq ($$(KERNEL_ARCH), arm64)
Redundant space before "arm64".
Also, this is only applicable to version v2016.08.0 that adds initial support
for aarch64
(http://lists.infradead.org/pipermail/barebox/2016-August/027849.html). A user
may set BR2_TARGET_BAREBOX_CUSTOM_VERSION to v2016.08.0+, so this may be
applicable to Buildroot master.
baruch
> +$(1)_ARCH = arm
> else
> $(1)_ARCH = $$(KERNEL_ARCH)
> endif
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] barebox: fix ARCH value for arm64
2016-08-12 12:32 ` Baruch Siach
@ 2016-08-12 12:52 ` Raphaël Poggi
2016-08-12 14:12 ` Baruch Siach
0 siblings, 1 reply; 5+ messages in thread
From: Raphaël Poggi @ 2016-08-12 12:52 UTC (permalink / raw)
To: buildroot
Hi,
2016-08-12 14:32 GMT+02:00 Baruch Siach <baruch@tkos.co.il>:
> Hi Raphael,
>
> On Fri, Aug 12, 2016 at 01:11:26PM +0200, Raphael Poggi wrote:
>> Signed-off-by: Raphael Poggi <poggi.raph@gmail.com>
>> ---
>> boot/barebox/barebox.mk | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/boot/barebox/barebox.mk b/boot/barebox/barebox.mk
>> index 832297e..b02751d 100644
>> --- a/boot/barebox/barebox.mk
>> +++ b/boot/barebox/barebox.mk
>> @@ -61,6 +61,8 @@ else ifeq ($$(KERNEL_ARCH),x86_64)
>> $(1)_ARCH = x86
>> else ifeq ($$(KERNEL_ARCH),powerpc)
>> $(1)_ARCH = ppc
>> +else ifeq ($$(KERNEL_ARCH), arm64)
>
> Redundant space before "arm64".
Oops, will fix it.
>
> Also, this is only applicable to version v2016.08.0 that adds initial support
> for aarch64
> (http://lists.infradead.org/pipermail/barebox/2016-August/027849.html). A user
> may set BR2_TARGET_BAREBOX_CUSTOM_VERSION to v2016.08.0+, so this may be
> applicable to Buildroot master.
You mean, test ($$(KERNEL_ARCH), arm64) and also the barebox version ?
Rapha?l
>
> baruch
>
>> +$(1)_ARCH = arm
>> else
>> $(1)_ARCH = $$(KERNEL_ARCH)
>> endif
>
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] barebox: fix ARCH value for arm64
2016-08-12 12:52 ` Raphaël Poggi
@ 2016-08-12 14:12 ` Baruch Siach
2016-08-12 14:29 ` Raphaël Poggi
0 siblings, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2016-08-12 14:12 UTC (permalink / raw)
To: buildroot
Hi Rapha?l,
On Fri, Aug 12, 2016 at 02:52:25PM +0200, Rapha?l Poggi wrote:
> 2016-08-12 14:32 GMT+02:00 Baruch Siach <baruch@tkos.co.il>:
> > On Fri, Aug 12, 2016 at 01:11:26PM +0200, Raphael Poggi wrote:
> >> Signed-off-by: Raphael Poggi <poggi.raph@gmail.com>
[...]
> >> +else ifeq ($$(KERNEL_ARCH), arm64)
> >
> > Redundant space before "arm64".
>
> Oops, will fix it.
>
> > Also, this is only applicable to version v2016.08.0 that adds initial
> > support for aarch64
> > (http://lists.infradead.org/pipermail/barebox/2016-August/027849.html). A user
> > may set BR2_TARGET_BAREBOX_CUSTOM_VERSION to v2016.08.0+, so this may be
> > applicable to Buildroot master.
>
> You mean, test ($$(KERNEL_ARCH), arm64) and also the barebox version ?
No. This patch doesn't break older Barebox versions, AFAICS. I was only
wondering whether it is master stuff, or -next, since we are now post -rc1. I
tend to think this patch is safe for master.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] barebox: fix ARCH value for arm64
2016-08-12 14:12 ` Baruch Siach
@ 2016-08-12 14:29 ` Raphaël Poggi
0 siblings, 0 replies; 5+ messages in thread
From: Raphaël Poggi @ 2016-08-12 14:29 UTC (permalink / raw)
To: buildroot
Hi,
2016-08-12 16:12 GMT+02:00 Baruch Siach <baruch@tkos.co.il>:
> Hi Rapha?l,
>
> On Fri, Aug 12, 2016 at 02:52:25PM +0200, Rapha?l Poggi wrote:
>> 2016-08-12 14:32 GMT+02:00 Baruch Siach <baruch@tkos.co.il>:
>> > On Fri, Aug 12, 2016 at 01:11:26PM +0200, Raphael Poggi wrote:
>> >> Signed-off-by: Raphael Poggi <poggi.raph@gmail.com>
>
> [...]
>
>> >> +else ifeq ($$(KERNEL_ARCH), arm64)
>> >
>> > Redundant space before "arm64".
>>
>> Oops, will fix it.
>>
>> > Also, this is only applicable to version v2016.08.0 that adds initial
>> > support for aarch64
>> > (http://lists.infradead.org/pipermail/barebox/2016-August/027849.html). A user
>> > may set BR2_TARGET_BAREBOX_CUSTOM_VERSION to v2016.08.0+, so this may be
>> > applicable to Buildroot master.
>>
>> You mean, test ($$(KERNEL_ARCH), arm64) and also the barebox version ?
>
> No. This patch doesn't break older Barebox versions, AFAICS. I was only
> wondering whether it is master stuff, or -next, since we are now post -rc1. I
> tend to think this patch is safe for master.
Ok, I understand. I will send v2 to fix the redundant space.
Rapha?l
>
> baruch
>
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-12 14:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-12 11:11 [Buildroot] [PATCH] barebox: fix ARCH value for arm64 Raphael Poggi
2016-08-12 12:32 ` Baruch Siach
2016-08-12 12:52 ` Raphaël Poggi
2016-08-12 14:12 ` Baruch Siach
2016-08-12 14:29 ` Raphaël Poggi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox