[Buildroot] [PATCH 1/1] package/simh: new package

[Buildroot] [PATCH 1/1] package/simh: new package

[Lothar Felten]

This package provides the simh multi-system emulator.

Signed-off-by: Lothar Felten <lothar.felten@gmail.com>
---
 package/Config.in      |  1 +
 package/simh/Config.in |  6 ++++++
 package/simh/simh.hash |  2 ++
 package/simh/simh.mk   | 21 +++++++++++++++++++++
 4 files changed, 30 insertions(+)
 create mode 100644 package/simh/Config.in
 create mode 100644 package/simh/simh.hash
 create mode 100644 package/simh/simh.mk

diff --git a/package/Config.in b/package/Config.in
index 645fa29..993b446 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -219,6 +219,7 @@ menu "Games"
 	source "package/opentyrian-data/Config.in"
 	source "package/prboom/Config.in"
 	source "package/rubix/Config.in"
+	source "package/simh/Config.in"
 	source "package/sl/Config.in"
 	source "package/stella/Config.in"
 	source "package/supertuxkart/Config.in"
diff --git a/package/simh/Config.in b/package/simh/Config.in
new file mode 100644
index 0000000..bcf6a3d
--- /dev/null
+++ b/package/simh/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_SIMH
+	bool "simh"
+	help
+	  SIMH is a highly portable, multi-system simulator.
+
+	  http://simh.trailing-edge.com
diff --git a/package/simh/simh.hash b/package/simh/simh.hash
new file mode 100644
index 0000000..b9fd211
--- /dev/null
+++ b/package/simh/simh.hash
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256 fd960602a3996b387066e9458e22d3bea940e88378afddc6ee81f33bf854efb9 simh-e93b55b4887dfcf1d0dd6ff86f94470e42a10702.tar.gz
diff --git a/package/simh/simh.mk b/package/simh/simh.mk
new file mode 100644
index 0000000..f650c69
--- /dev/null
+++ b/package/simh/simh.mk
@@ -0,0 +1,21 @@
+################################################################################
+#
+# simh
+#
+################################################################################
+
+SIMH_VERSION = e93b55b4887dfcf1d0dd6ff86f94470e42a10702
+SIMH_SITE = https://github.com/simh/simh
+SIMH_SITE_METHOD = git
+SIMH_LICENSE = simh license
+SIMH_LICENSE_FILES = README
+
+define SIMH_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
+endef
+
+define SIMH_INSTALL_TARGET_CMDS
+	cp -dpf $(@D)/BIN/* $(TARGET_DIR)/usr/bin/
+endef
+
+$(eval $(generic-package))
-- 
1.9.1

[Buildroot] [PATCH 1/1] package/simh: new package

[Baruch Siach]

Hi Lothar,

On Mon, Aug 15, 2016 at 11:42:37PM +0200, Lothar Felten wrote:
> diff --git a/package/simh/Config.in b/package/simh/Config.in
> new file mode 100644
> index 0000000..bcf6a3d
> --- /dev/null
> +++ b/package/simh/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_SIMH
> +	bool "simh"
> +	help
> +	  SIMH is a highly portable, multi-system simulator.
> +
> +	  http://simh.trailing-edge.com

There are fork() calls in the code, so this package might need a BR2_USE_MMU 
dependency.

> diff --git a/package/simh/simh.mk b/package/simh/simh.mk
> new file mode 100644
> index 0000000..f650c69
> --- /dev/null
> +++ b/package/simh/simh.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# simh
> +#
> +################################################################################
> +
> +SIMH_VERSION = e93b55b4887dfcf1d0dd6ff86f94470e42a10702
> +SIMH_SITE = https://github.com/simh/simh
> +SIMH_SITE_METHOD = git

Please use the github helper. See 
http://nightly.buildroot.org/manual.html#github-download-url.

> +SIMH_LICENSE = simh license

Looking into a random source file like sim_imd.c, the license seems to be MIT. 
See https://opensource.org/licenses/MIT.

> +SIMH_LICENSE_FILES = README

I couldn't find this file in the source.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[Buildroot] [PATCH 1/1] package/simh: new package

[Lothar Felten]

Hi Baruch,

On 16.08.2016 05:50, Baruch Siach wrote:
>
> There are fork() calls in the code, so this package might need a BR2_USE_MMU
> dependency.

Ok, I'll add that

>> diff --git a/package/simh/simh.mk b/package/simh/simh.mk
>> new file mode 100644
>> index 0000000..f650c69
>> --- /dev/null
>> +++ b/package/simh/simh.mk
>> @@ -0,0 +1,21 @@
>> +################################################################################
>> +#
>> +# simh
>> +#
>> +################################################################################
>> +
>> +SIMH_VERSION = e93b55b4887dfcf1d0dd6ff86f94470e42a10702
>> +SIMH_SITE = https://github.com/simh/simh
>> +SIMH_SITE_METHOD = git
>
> Please use the github helper. See
> http://nightly.buildroot.org/manual.html#github-download-url.
>
>> +SIMH_LICENSE = simh license
>
> Looking into a random source file like sim_imd.c, the license seems to be MIT.
> See https://opensource.org/licenses/MIT.

Most files have a MIT-license/disclaimer, a few files reference GNU GPL 
(Intel-Systems/common/i8088.c), at least one file is paritally 
zlib/libpng license (sim_video.c, line 102), one file is "licensed under 
the standard SimH license" (PDP11/pdp11_kmc.c), which seems to be MIT.

There's a Word .doc file doc/simh.doc that states:

COPYRIGHT NOTICE: The following copyright notice applies to the SIMH 
source, binary, and documentation (an then: MIT license)

An older PDF version is online:
http://simh.trailing-edge.com/pdf/simh_doc.pdf

Should I point to the simh.doc file?

Lothar

[Buildroot] [PATCH 1/1] package/simh: new package

[Yann E. MORIN]

Lothar, All,

On 2016-08-15 23:42 +0200, Lothar Felten spake thusly:
> This package provides the simh multi-system emulator.

As discussed on IRC, there are too many issues with this package.

For example, it does not support cross-compilation at all; its Makefile
is so borked that it looks for build system libs and headers; it also
searches the build system for necessary programs.

I can't see an easy solution to use that package as-is to make it
behave properly (if at all). It does not seem it would be overly complex
to rewrite a buildsystem for it from scratch, using one of the usual
buildsystems: autotools or cmake for example.

Until then, and according to our discussion on IRC I've marked this
patch as rejected in our patchwork.

Thanks!

Regards,
Yann E. MORIN.

> Signed-off-by: Lothar Felten <lothar.felten@gmail.com>
> ---
>  package/Config.in      |  1 +
>  package/simh/Config.in |  6 ++++++
>  package/simh/simh.hash |  2 ++
>  package/simh/simh.mk   | 21 +++++++++++++++++++++
>  4 files changed, 30 insertions(+)
>  create mode 100644 package/simh/Config.in
>  create mode 100644 package/simh/simh.hash
>  create mode 100644 package/simh/simh.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 645fa29..993b446 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -219,6 +219,7 @@ menu "Games"
>  	source "package/opentyrian-data/Config.in"
>  	source "package/prboom/Config.in"
>  	source "package/rubix/Config.in"
> +	source "package/simh/Config.in"
>  	source "package/sl/Config.in"
>  	source "package/stella/Config.in"
>  	source "package/supertuxkart/Config.in"
> diff --git a/package/simh/Config.in b/package/simh/Config.in
> new file mode 100644
> index 0000000..bcf6a3d
> --- /dev/null
> +++ b/package/simh/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_SIMH
> +	bool "simh"
> +	help
> +	  SIMH is a highly portable, multi-system simulator.
> +
> +	  http://simh.trailing-edge.com
> diff --git a/package/simh/simh.hash b/package/simh/simh.hash
> new file mode 100644
> index 0000000..b9fd211
> --- /dev/null
> +++ b/package/simh/simh.hash
> @@ -0,0 +1,2 @@
> +# Locally computed:
> +sha256 fd960602a3996b387066e9458e22d3bea940e88378afddc6ee81f33bf854efb9 simh-e93b55b4887dfcf1d0dd6ff86f94470e42a10702.tar.gz
> diff --git a/package/simh/simh.mk b/package/simh/simh.mk
> new file mode 100644
> index 0000000..f650c69
> --- /dev/null
> +++ b/package/simh/simh.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# simh
> +#
> +################################################################################
> +
> +SIMH_VERSION = e93b55b4887dfcf1d0dd6ff86f94470e42a10702
> +SIMH_SITE = https://github.com/simh/simh
> +SIMH_SITE_METHOD = git
> +SIMH_LICENSE = simh license
> +SIMH_LICENSE_FILES = README
> +
> +define SIMH_BUILD_CMDS
> +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
> +endef
> +
> +define SIMH_INSTALL_TARGET_CMDS
> +	cp -dpf $(@D)/BIN/* $(TARGET_DIR)/usr/bin/
> +endef
> +
> +$(eval $(generic-package))
> -- 
> 1.9.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] package/simh: new package

[Baruch Siach]

Hi Lothar,

As Yann marked this patch as rejected, this discussion is moot. But I'll 
respond below for future reference.

On Tue, Aug 16, 2016 at 10:31:10AM +0200, Lothar Felten wrote:
> On 16.08.2016 05:50, Baruch Siach wrote:
> > Looking into a random source file like sim_imd.c, the license seems to be 
> > MIT. See https://opensource.org/licenses/MIT.
> 
> Most files have a MIT-license/disclaimer, a few files reference GNU GPL
> (Intel-Systems/common/i8088.c), at least one file is paritally zlib/libpng
> license (sim_video.c, line 102), one file is "licensed under the standard
> SimH license" (PDP11/pdp11_kmc.c), which seems to be MIT.

In this case <PKG>_LICENSE should list all these licenses.

> There's a Word .doc file doc/simh.doc that states:
> 
> COPYRIGHT NOTICE: The following copyright notice applies to the SIMH source,
> binary, and documentation (an then: MIT license)
> 
> An older PDF version is online:
> http://simh.trailing-edge.com/pdf/simh_doc.pdf
> 
> Should I point to the simh.doc file?

I don't think so. Not sure how our legal info infra handles binary document 
formats. Instead you may put source files that contain respective licenses 
text in <PKG>_LICENSE_FILES.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[Buildroot] [PATCH 1/1] package/simh: new package

[Yann E. MORIN]

Baruch, All,

On 2016-08-16 17:29 +0300, Baruch Siach spake thusly:
> As Yann marked this patch as rejected, this discussion is moot. But I'll 
> respond below for future reference.
> 
> On Tue, Aug 16, 2016 at 10:31:10AM +0200, Lothar Felten wrote:
> > On 16.08.2016 05:50, Baruch Siach wrote:
> > > Looking into a random source file like sim_imd.c, the license seems to be 
> > > MIT. See https://opensource.org/licenses/MIT.
> > 
> > Most files have a MIT-license/disclaimer, a few files reference GNU GPL
> > (Intel-Systems/common/i8088.c), at least one file is paritally zlib/libpng
> > license (sim_video.c, line 102), one file is "licensed under the standard
> > SimH license" (PDP11/pdp11_kmc.c), which seems to be MIT.
> 
> In this case <PKG>_LICENSE should list all these licenses.

Yes.

> > There's a Word .doc file doc/simh.doc that states:
> > 
> > COPYRIGHT NOTICE: The following copyright notice applies to the SIMH source,
> > binary, and documentation (an then: MIT license)
> > 
> > An older PDF version is online:
> > http://simh.trailing-edge.com/pdf/simh_doc.pdf
> > 
> > Should I point to the simh.doc file?
> 
> I don't think so. Not sure how our legal info infra handles binary document 
> formats.

FOO_LICENSE_FILES are just copied; we don't do anything with them. So
it's fine to list a .doc in there.

> Instead you may put source files that contain respective licenses 
> text in <PKG>_LICENSE_FILES.

Only for those licenses that do not have a separate license file, or are
not listed in that .doc file.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] package/simh: new package

[Thomas Petazzoni]

Hello,

On Tue, 16 Aug 2016 21:42:36 +0200, Yann E. MORIN wrote:

> > I don't think so. Not sure how our legal info infra handles binary document 
> > formats.  
> 
> FOO_LICENSE_FILES are just copied; we don't do anything with them. So
> it's fine to list a .doc in there.

Not quite true: we generate a big .txt file with the concatenation of
the license text of all packages, see licenses.txt and
host-licenses.txt.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] package/simh: new package

[Yann E. MORIN]

Thomas, Lothar, All,

On 2016-08-18 21:27 +0200, Thomas Petazzoni spake thusly:
> On Tue, 16 Aug 2016 21:42:36 +0200, Yann E. MORIN wrote:
> 
> > > I don't think so. Not sure how our legal info infra handles binary document 
> > > formats.  
> > 
> > FOO_LICENSE_FILES are just copied; we don't do anything with them. So
> > it's fine to list a .doc in there.
> 
> Not quite true: we generate a big .txt file with the concatenation of
> the license text of all packages, see licenses.txt and
> host-licenses.txt.

Indeed, I had forgotten about that...

Then, it that case, I think it would be better not to list the doc file
in SIMH_LICENSE_FILES at all.

Still, we'd want it to be copied, so maybe that could be done with a
post legal-info hook, something like (untested):

    define SIMH_LEGAL_INFO_DOC_FILE
        $(INSTALL) -m 0644 -D $(@D)/path/to/license.doc \
            $(LICENSE_FILES_DIR_TARGET)/simh-$(SIMH_VERSION)/license.doc
    endef
    SIMH_POST_LEGAL_INFO_HOOKS += SIMH_LEGAL_INFO_DOC_FILE

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'