Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] squeezelite: needs NPTL
@ 2016-08-18  6:27 Waldemar Brodkorb
  2016-08-18  6:41 ` Baruch Siach
  2016-08-18 21:55 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Waldemar Brodkorb @ 2016-08-18  6:27 UTC (permalink / raw)
  To: buildroot

It uses PTHREAD_PRIO_INHERIT, which isn't available in Linuxthreads.

Fixes:
  http://autobuild.buildroot.net/results/455/455465c332d291929c1612d18a9e7448d9c76e73/

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 package/squeezelite/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/squeezelite/Config.in b/package/squeezelite/Config.in
index 79d2947..154daaa 100644
--- a/package/squeezelite/Config.in
+++ b/package/squeezelite/Config.in
@@ -1,7 +1,7 @@
 config BR2_PACKAGE_SQUEEZELITE
 	bool "squeezelite"
 	depends on BR2_USE_WCHAR # flac
-	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # alsa-lib
 	depends on BR2_USE_MMU # mpg123
 	depends on !BR2_STATIC_LIBS # dlopen
 	select BR2_PACKAGE_ALSA_LIB
@@ -36,7 +36,7 @@ config BR2_PACKAGE_SQUEEZELITE_VISEXPORT
 
 endif
 
-comment "squeezelite needs a toolchain w/ wchar, threads, dynamic library"
+comment "squeezelite needs a toolchain w/ wchar, NPTL, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS \
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS_NPTL \
 		|| BR2_STATIC_LIBS
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] squeezelite: needs NPTL
  2016-08-18  6:27 [Buildroot] [PATCH] squeezelite: needs NPTL Waldemar Brodkorb
@ 2016-08-18  6:41 ` Baruch Siach
  2016-08-18 21:55 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Baruch Siach @ 2016-08-18  6:41 UTC (permalink / raw)
  To: buildroot

Hi Waldemar,

On Thu, Aug 18, 2016 at 08:27:04AM +0200, Waldemar Brodkorb wrote:
> It uses PTHREAD_PRIO_INHERIT, which isn't available in Linuxthreads.
> 
> Fixes:
>   http://autobuild.buildroot.net/results/455/455465c332d291929c1612d18a9e7448d9c76e73/
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
>  package/squeezelite/Config.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/squeezelite/Config.in b/package/squeezelite/Config.in
> index 79d2947..154daaa 100644
> --- a/package/squeezelite/Config.in
> +++ b/package/squeezelite/Config.in
> @@ -1,7 +1,7 @@
>  config BR2_PACKAGE_SQUEEZELITE
>  	bool "squeezelite"
>  	depends on BR2_USE_WCHAR # flac
> -	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
> +	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # alsa-lib

The 'alsa-lib' comment should be dropped, then. NPTL (or threading for that 
matter) is a dependency of squeezelite itself.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] squeezelite: needs NPTL
  2016-08-18  6:27 [Buildroot] [PATCH] squeezelite: needs NPTL Waldemar Brodkorb
  2016-08-18  6:41 ` Baruch Siach
@ 2016-08-18 21:55 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2016-08-18 21:55 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu, 18 Aug 2016 08:27:04 +0200, Waldemar Brodkorb wrote:
> It uses PTHREAD_PRIO_INHERIT, which isn't available in Linuxthreads.
> 
> Fixes:
>   http://autobuild.buildroot.net/results/455/455465c332d291929c1612d18a9e7448d9c76e73/
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
>  package/squeezelite/Config.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied to master, after fixing the issue pointed by Baruch (the NPTL
dependency is not about alsa-lib).

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-08-18 21:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-18  6:27 [Buildroot] [PATCH] squeezelite: needs NPTL Waldemar Brodkorb
2016-08-18  6:41 ` Baruch Siach
2016-08-18 21:55 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox