[Buildroot] [PATCH] pcre: fix compile error for m68k coldfire

[Buildroot] [PATCH] pcre: fix compile error for m68k coldfire

[Waldemar Brodkorb]

Some very big functions can not be compiled successfully for
m68k coldfire, when -msep-data is used.

Fixes:
  http://autobuild.buildroot.net/results/d31/d311955ada1ffcd7f69e82965c8fe33eabe488cd/

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 package/pcre/pcre.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/pcre/pcre.mk b/package/pcre/pcre.mk
index a10950d..6352cc8 100644
--- a/package/pcre/pcre.mk
+++ b/package/pcre/pcre.mk
@@ -26,5 +26,11 @@ PCRE_CONF_OPTS += $(if $(BR2_PACKAGE_PCRE_32),--enable-pcre32,--disable-pcre32)
 PCRE_CONF_OPTS += $(if $(BR2_PACKAGE_PCRE_UTF),--enable-utf,--disable-utf)
 PCRE_CONF_OPTS += $(if $(BR2_PACKAGE_PCRE_UCP),--enable-unicode-properties,--disable-unicode-properties)
 
+# fixes gcc error: value -yyyyy out of range
+ifeq ($(BR2_m68k_cf),y)
+PCRE_CFLAGS = $(filter-out -msep-data,$(TARGET_CFLAGS))
+PCRE_CONF_ENV += CFLAGS="$(PCRE_CFLAGS)"
+endif
+
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
-- 
2.1.4

[Buildroot] [PATCH] pcre: fix compile error for m68k coldfire

[Thomas Petazzoni]

Hello,

On Thu, 18 Aug 2016 08:25:35 +0200, Waldemar Brodkorb wrote:

> +# fixes gcc error: value -yyyyy out of range
> +ifeq ($(BR2_m68k_cf),y)
> +PCRE_CFLAGS = $(filter-out -msep-data,$(TARGET_CFLAGS))
> +PCRE_CONF_ENV += CFLAGS="$(PCRE_CFLAGS)"
> +endif

We discussed this on IRC, but since not everyone is on IRC, and Google
is also not archiving the IRC discussions, I believe it's good if I
give a summary of our discussion here.

Basically, I don't like the solution that this patch implements. The
reason why -msep-data is passed is because the user has selected
BR2_BINFMT_FLAT_SEP_DATA as the FLAT format, instead of the default
BR2_BINFMT_FLAT_ONE. BR2_BINFMT_FLAT_SEP_DATA is useful to separate
code from data, which is needed when you want to do XIP (code stays in
flash, but data needs to be loaded in RAM, so they have to be
separated).

By dropping -msep-data, you are basically producing a non-XIP capable
binary, while the user has explicitly requested
BR2_BINFMT_FLAT_SEP_DATA. So silently dropping -msep-data is IMO not
acceptable.

So we have several options here:

 1/ Mark pcre as not available for BR2_BINFMT_FLAT_SEP_DATA. But pcre
    has gazillions of reverse dependencies, and I expect the issue of
    -msep-data to show up on many many packages, as soon as they have a
    fairly large binary size.

 2/ Actually fix up the problem, but I'm not sure it's even doable.

 3/ Decide that we don't support BR2_BINFMT_FLAT_SEP_DATA at all on
    m68k. On master, BR2_BINFMT_FLAT_ONE was not available for m68k due
    to kernel issues, but they have been resolved, and
    BR2_BINFMT_FLAT_ONE is now enabled on m68k in the next branch. So I
    would suggest to also enable BR2_BINFMT_FLAT_ONE on m68k in master,
    disallow the selection of BR2_BINFMT_FLAT_SEP_DATA. If in the
    future someone is interested by -msep-data on m68k, this person can
    always restart the work and see how to fix the issues.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH] pcre: fix compile error for m68k coldfire

[Waldemar Brodkorb]

Hi Thomas,
Thomas Petazzoni wrote,

> So we have several options here:
> 
>  1/ Mark pcre as not available for BR2_BINFMT_FLAT_SEP_DATA. But pcre
>     has gazillions of reverse dependencies, and I expect the issue of
>     -msep-data to show up on many many packages, as soon as they have a
>     fairly large binary size.
> 
>  2/ Actually fix up the problem, but I'm not sure it's even doable.
> 
>  3/ Decide that we don't support BR2_BINFMT_FLAT_SEP_DATA at all on
>     m68k. On master, BR2_BINFMT_FLAT_ONE was not available for m68k due
>     to kernel issues, but they have been resolved, and
>     BR2_BINFMT_FLAT_ONE is now enabled on m68k in the next branch. So I
>     would suggest to also enable BR2_BINFMT_FLAT_ONE on m68k in master,
>     disallow the selection of BR2_BINFMT_FLAT_SEP_DATA. If in the
>     future someone is interested by -msep-data on m68k, this person can
>     always restart the work and see how to fix the issues.

I vote for 3)

thanks for the nice summary,
 Waldemar

[Buildroot] [PATCH] pcre: fix compile error for m68k coldfire

[Peter Korsgaard]

>>>>> "Waldemar" == Waldemar Brodkorb <wbx@openadk.org> writes:

Hi,

 >> 3/ Decide that we don't support BR2_BINFMT_FLAT_SEP_DATA at all on
 >> m68k. On master, BR2_BINFMT_FLAT_ONE was not available for m68k due
 >> to kernel issues, but they have been resolved, and
 >> BR2_BINFMT_FLAT_ONE is now enabled on m68k in the next branch. So I
 >> would suggest to also enable BR2_BINFMT_FLAT_ONE on m68k in master,
 >> disallow the selection of BR2_BINFMT_FLAT_SEP_DATA. If in the
 >> future someone is interested by -msep-data on m68k, this person can
 >> always restart the work and see how to fix the issues.

 > I vote for 3)

Yeah, me too.

-- 
Bye, Peter Korsgaard