Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/x11r7/xdriver_xf86-video-intel: use -O2 build optimisation level
@ 2016-08-17 18:40 Bernd Kuhls
  2016-08-17 19:54 ` Gustavo Zacarias
  2016-08-20 13:01 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Bernd Kuhls @ 2016-08-17 18:40 UTC (permalink / raw)
  To: buildroot

Reported by Gustavo:
http://lists.busybox.net/pipermail/buildroot/2016-August/169959.html

The fix was suggested on the Gentoo bugtracker:
https://bugs.gentoo.org/show_bug.cgi?id=582910#c4

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/x11r7/xdriver_xf86-video-intel/xdriver_xf86-video-intel.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/x11r7/xdriver_xf86-video-intel/xdriver_xf86-video-intel.mk b/package/x11r7/xdriver_xf86-video-intel/xdriver_xf86-video-intel.mk
index 64e9269..bfe0527 100644
--- a/package/x11r7/xdriver_xf86-video-intel/xdriver_xf86-video-intel.mk
+++ b/package/x11r7/xdriver_xf86-video-intel/xdriver_xf86-video-intel.mk
@@ -10,9 +10,11 @@ XDRIVER_XF86_VIDEO_INTEL_LICENSE = MIT
 XDRIVER_XF86_VIDEO_INTEL_LICENSE_FILES = COPYING
 XDRIVER_XF86_VIDEO_INTEL_AUTORECONF = YES
 
-# this fixes a getline-related compilation error in src/sna/kgem.c
+# -D_GNU_SOURCE fixes a getline-related compile error in src/sna/kgem.c
+# We force -O2 regardless of the optimization level chosen by the user,
+# as compiling this package is known to be broken with -Os.
 XDRIVER_XF86_VIDEO_INTEL_CONF_ENV = \
-	CFLAGS="$(TARGET_CFLAGS) -D_GNU_SOURCE"
+	CFLAGS="$(TARGET_CFLAGS) -D_GNU_SOURCE -O2"
 
 XDRIVER_XF86_VIDEO_INTEL_CONF_OPTS = \
 	--disable-xvmc \
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/x11r7/xdriver_xf86-video-intel: use -O2 build optimisation level
  2016-08-17 18:40 [Buildroot] [PATCH 1/1] package/x11r7/xdriver_xf86-video-intel: use -O2 build optimisation level Bernd Kuhls
@ 2016-08-17 19:54 ` Gustavo Zacarias
  2016-08-20 13:01 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Gustavo Zacarias @ 2016-08-17 19:54 UTC (permalink / raw)
  To: buildroot

On 2016-08-17 15:40, Bernd Kuhls wrote:

> Reported by Gustavo:
> http://lists.busybox.net/pipermail/buildroot/2016-August/169959.html
> 
> The fix was suggested on the Gentoo bugtracker:
> https://bugs.gentoo.org/show_bug.cgi?id=582910#c4
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Tested-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/x11r7/xdriver_xf86-video-intel: use -O2 build optimisation level
  2016-08-17 18:40 [Buildroot] [PATCH 1/1] package/x11r7/xdriver_xf86-video-intel: use -O2 build optimisation level Bernd Kuhls
  2016-08-17 19:54 ` Gustavo Zacarias
@ 2016-08-20 13:01 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2016-08-20 13:01 UTC (permalink / raw)
  To: buildroot

Hello,

On Wed, 17 Aug 2016 20:40:09 +0200, Bernd Kuhls wrote:
> Reported by Gustavo:
> http://lists.busybox.net/pipermail/buildroot/2016-August/169959.html
> 
> The fix was suggested on the Gentoo bugtracker:
> https://bugs.gentoo.org/show_bug.cgi?id=582910#c4
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/x11r7/xdriver_xf86-video-intel/xdriver_xf86-video-intel.mk | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-08-20 13:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-17 18:40 [Buildroot] [PATCH 1/1] package/x11r7/xdriver_xf86-video-intel: use -O2 build optimisation level Bernd Kuhls
2016-08-17 19:54 ` Gustavo Zacarias
2016-08-20 13:01 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox