From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next v2 1/2] valgrind: let the valgrind configure script detect TLS availability
Date: Wed, 31 Aug 2016 21:46:18 +0200 [thread overview]
Message-ID: <20160831214618.3ea0ef87@free-electrons.com> (raw)
In-Reply-To: <1472592808-18270-1-git-send-email-thomas.petazzoni@free-electrons.com>
Hello,
On Tue, 30 Aug 2016 23:33:27 +0200, Thomas Petazzoni wrote:
> Back in 2005, in commit
> a2c326396a43ecbc8d02c3d815d4010a7ba2e004 ("update valgrind to the latest
> and greatest"), an explicit --disable-tls option was added. More
> recently, in commit 31a3f4bd54e12b8d6de286ab8fb6d9651990e2f5 ("valgrind:
> enable tls support") changed this to be conditional on
> BR2_GCC_ENABLE_TLS.
>
> However, the configure script of valgrind is perfectly capable of
> detecting TLS support, even in a cross-compilation case: it tries to
> compile a program that uses __thread and sees if it works.
>
> Since we're about to modify how BR2_GCC_ENABLE_TLS is handled, we'd
> better remove its usage from packages, and valgrind is the only package
> using this config option.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> Changes since v1:
> - Added Arnout Reviewed-by.
> ---
> package/valgrind/valgrind.mk | 6 ------
> 1 file changed, 6 deletions(-)
I've applied both patches to next.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-08-31 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 21:33 [Buildroot] [PATCH/next v2 1/2] valgrind: let the valgrind configure script detect TLS availability Thomas Petazzoni
2016-08-30 21:33 ` [Buildroot] [PATCH/next v2 2/2] gcc: remove BR2_GCC_ENABLE_TLS option Thomas Petazzoni
2016-08-30 22:58 ` Arnout Vandecappelle
2016-08-31 7:11 ` Thomas Petazzoni
2016-08-31 19:46 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831214618.3ea0ef87@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox