Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] Error with OVERRIDE_SRCDIR in 2016.08
@ 2016-09-05  8:39 Jeff Gray
  2016-09-05  9:37 ` Yann E. MORIN
  0 siblings, 1 reply; 4+ messages in thread
From: Jeff Gray @ 2016-09-05  8:39 UTC (permalink / raw)
  To: buildroot

I'm having a problem after upgrading from 2016.05 to 2016.08. I have a
number of local applications that I install from BR2_EXTERNAL. This used to
work fine in 2016.05, but now I get messages like this when making
buildroot (showing one example and using the macro for clarity):
$(BR2_EXTERNAL)/package/svp/gpio/gpio.mk:18: *** GPIO_SITE cannot be empty
when GPIO_SOURCE is not.  Stop.

I have placed the package files at $(BR2_EXTERNAL)/package/svp/gpio/ and
the source files at $(BR2_EXTERNAL)/src/gpio

My gpio.mk file is:
--------------
GPIO_VERSION = 1.0
GPIO_OVERRIDE_SRCDIR = $(BR2_EXTERNAL)/src/gpio/
define GPIO_BUILD_CMDS
$(MAKE) CC="$(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS)" -C $(@D)
endef
define GPIO_INSTALL_TARGET_CMDS
$(INSTALL) -m 0755 -D $(@D)/gpio $(TARGET_DIR)/usr/bin/gpio
endef
$(eval $(generic-package))
---------------

I have a $(BR2_EXTERNAL)/Config.in that contains lines like this:
source "$BR2_EXTERNAL/package/svp/gpio/Config.in"
... and a $(BR2_EXTERNAL)/external.mk that contains this:
include $(sort $(wildcard $(BR2_EXTERNAL)/package/svp/*/*.mk))

Can anyone think of a cause for the error message? Has the way this sort of
project is configured changed? I looked through the manual and couldn't see
anything. I checked that the output/.br-external is the same for both
versions.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160905/9550d759/attachment.html>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Buildroot] Error with OVERRIDE_SRCDIR in 2016.08
  2016-09-05  8:39 [Buildroot] Error with OVERRIDE_SRCDIR in 2016.08 Jeff Gray
@ 2016-09-05  9:37 ` Yann E. MORIN
  2016-09-05  9:48   ` Yann E. MORIN
  0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2016-09-05  9:37 UTC (permalink / raw)
  To: buildroot

Jeff, All,

On 2016-09-05 18:39 +1000, Jeff Gray spake thusly:
> I'm having a problem after upgrading from 2016.05 to 2016.08. I have a
> number of local applications that I install from BR2_EXTERNAL. This used to
> work fine in 2016.05, but now I get messages like this when making
> buildroot (showing one example and using the macro for clarity):
> $(BR2_EXTERNAL)/package/svp/gpio/gpio.mk:18: *** GPIO_SITE cannot be empty
> when GPIO_SOURCE is not.  Stop.

Well, there you missed a little tiny thing from the manual:

  * LIBFOO_SOURCE may contain the name of the tarball of the package, which
    Buildroot will use to download the tarball from LIBFOO_SITE. If
    HOST_LIBFOO_SOURCE is not specified, it defaults to LIBFOO_SOURCE. If
    none are specified, then the value is assumed to be
    libfoo-$(LIBFOO_VERSION).tar.gz.

Notice the part about "If none are specified, then the value is assumed
to be libfoo-$(LIBFOO_VERSION).tar.gz" ? ;-)

So in your case, you must define GPIO_SOURCE to empty:

    GPIO_SOURCE =

Regards,
Yann E. MORIN.

> I have placed the package files at $(BR2_EXTERNAL)/package/svp/gpio/ and
> the source files at $(BR2_EXTERNAL)/src/gpio
> 
> My gpio.mk file is:
> --------------
> GPIO_VERSION = 1.0
> GPIO_OVERRIDE_SRCDIR = $(BR2_EXTERNAL)/src/gpio/
> define GPIO_BUILD_CMDS
> $(MAKE) CC="$(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS)" -C $(@D)
> endef
> define GPIO_INSTALL_TARGET_CMDS
> $(INSTALL) -m 0755 -D $(@D)/gpio $(TARGET_DIR)/usr/bin/gpio
> endef
> $(eval $(generic-package))
> ---------------
> 
> I have a $(BR2_EXTERNAL)/Config.in that contains lines like this:
> source "$BR2_EXTERNAL/package/svp/gpio/Config.in"
> ... and a $(BR2_EXTERNAL)/external.mk that contains this:
> include $(sort $(wildcard $(BR2_EXTERNAL)/package/svp/*/*.mk))
> 
> Can anyone think of a cause for the error message? Has the way this sort of
> project is configured changed? I looked through the manual and couldn't see
> anything. I checked that the output/.br-external is the same for both
> versions.

> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot


-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Buildroot] Error with OVERRIDE_SRCDIR in 2016.08
  2016-09-05  9:37 ` Yann E. MORIN
@ 2016-09-05  9:48   ` Yann E. MORIN
  2016-09-06  3:37     ` Jeff Gray
  0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2016-09-05  9:48 UTC (permalink / raw)
  To: buildroot

Jeff, All,

On 2016-09-05 11:37 +0200, Yann E. MORIN spake thusly:
> On 2016-09-05 18:39 +1000, Jeff Gray spake thusly:
> > I'm having a problem after upgrading from 2016.05 to 2016.08. I have a
> > number of local applications that I install from BR2_EXTERNAL. This used to
> > work fine in 2016.05, but now I get messages like this when making
> > buildroot (showing one example and using the macro for clarity):
> > $(BR2_EXTERNAL)/package/svp/gpio/gpio.mk:18: *** GPIO_SITE cannot be empty
> > when GPIO_SOURCE is not.  Stop.
> 
> Well, there you missed a little tiny thing from the manual:
> 
>   * LIBFOO_SOURCE may contain the name of the tarball of the package, which
>     Buildroot will use to download the tarball from LIBFOO_SITE. If
>     HOST_LIBFOO_SOURCE is not specified, it defaults to LIBFOO_SOURCE. If
>     none are specified, then the value is assumed to be
>     libfoo-$(LIBFOO_VERSION).tar.gz.
> 
> Notice the part about "If none are specified, then the value is assumed
> to be libfoo-$(LIBFOO_VERSION).tar.gz" ? ;-)
> 
> So in your case, you must define GPIO_SOURCE to empty:
> 
>     GPIO_SOURCE =

In retrospect, you should probably not be using _OVERRIDE_SRCDIR in this
case, but

    GPIO_VERSION = whatever-it-does-not-matter
    GPIO_SITE_METHOD = local
    GPIO_SITE = $(BR2_EXTERNAL)/src/gpio/

Regards,
Yann E. MORIN.

> > I have placed the package files at $(BR2_EXTERNAL)/package/svp/gpio/ and
> > the source files at $(BR2_EXTERNAL)/src/gpio
> > 
> > My gpio.mk file is:
> > --------------
> > GPIO_VERSION = 1.0
> > GPIO_OVERRIDE_SRCDIR = $(BR2_EXTERNAL)/src/gpio/
> > define GPIO_BUILD_CMDS
> > $(MAKE) CC="$(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS)" -C $(@D)
> > endef
> > define GPIO_INSTALL_TARGET_CMDS
> > $(INSTALL) -m 0755 -D $(@D)/gpio $(TARGET_DIR)/usr/bin/gpio
> > endef
> > $(eval $(generic-package))
> > ---------------
> > 
> > I have a $(BR2_EXTERNAL)/Config.in that contains lines like this:
> > source "$BR2_EXTERNAL/package/svp/gpio/Config.in"
> > ... and a $(BR2_EXTERNAL)/external.mk that contains this:
> > include $(sort $(wildcard $(BR2_EXTERNAL)/package/svp/*/*.mk))
> > 
> > Can anyone think of a cause for the error message? Has the way this sort of
> > project is configured changed? I looked through the manual and couldn't see
> > anything. I checked that the output/.br-external is the same for both
> > versions.
> 
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
> 
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Buildroot] Error with OVERRIDE_SRCDIR in 2016.08
  2016-09-05  9:48   ` Yann E. MORIN
@ 2016-09-06  3:37     ` Jeff Gray
  0 siblings, 0 replies; 4+ messages in thread
From: Jeff Gray @ 2016-09-06  3:37 UTC (permalink / raw)
  To: buildroot

Thank you, that works well. I like the SITE_METHOD as that also means I
don't have -custom on the output directory names.

I did not know about your first idea of using _SOURCE=<empty> and could not
find it in the manual. It might be worth adding a comment about this in the
manual or making it clearer if it is already there.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160906/76279ef3/attachment-0001.html>

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-06  3:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-05  8:39 [Buildroot] Error with OVERRIDE_SRCDIR in 2016.08 Jeff Gray
2016-09-05  9:37 ` Yann E. MORIN
2016-09-05  9:48   ` Yann E. MORIN
2016-09-06  3:37     ` Jeff Gray

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox