* [Buildroot] [PATCH 1/2] package/ffmpeg: opencv2 support is broken if BR2_ARM_ENABLE_VFP is enabled @ 2016-09-05 14:51 Bernd Kuhls 2016-09-05 14:51 ` [Buildroot] [PATCH 2/2] package/ffmpeg: add optional support for opencv3 Bernd Kuhls 2016-09-05 20:05 ` [Buildroot] [PATCH 1/2] package/ffmpeg: opencv2 support is broken if BR2_ARM_ENABLE_VFP is enabled Thomas Petazzoni 0 siblings, 2 replies; 7+ messages in thread From: Bernd Kuhls @ 2016-09-05 14:51 UTC (permalink / raw) To: buildroot Fixes http://autobuild.buildroot.net/results/c32/c32a21240a9933796ee850349a62ff3c2314f25c/ http://autobuild.buildroot.net/results/22a/22a9769d83d2a398bb6b264d342b2077c41c9cc5/ Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- package/ffmpeg/ffmpeg.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk index a90d437..74f783c 100644 --- a/package/ffmpeg/ffmpeg.mk +++ b/package/ffmpeg/ffmpeg.mk @@ -250,7 +250,8 @@ endif # To avoid a circular dependency only use opencv if opencv itself does # not depend on ffmpeg. -ifeq ($(BR2_PACKAGE_OPENCV_LIB_IMGPROC)x$(BR2_PACKAGE_OPENCV_WITH_FFMPEG),yx) +# opencv2 is broken if BR2_ARM_ENABLE_VFP is enabled +ifeq ($(BR2_PACKAGE_OPENCV_LIB_IMGPROC)x$(BR2_PACKAGE_OPENCV_WITH_FFMPEG)x$(BR2_ARM_ENABLE_VFP),yxx) FFMPEG_CONF_OPTS += --enable-libopencv FFMPEG_DEPENDENCIES += opencv else -- 2.9.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/2] package/ffmpeg: add optional support for opencv3 2016-09-05 14:51 [Buildroot] [PATCH 1/2] package/ffmpeg: opencv2 support is broken if BR2_ARM_ENABLE_VFP is enabled Bernd Kuhls @ 2016-09-05 14:51 ` Bernd Kuhls 2016-09-06 19:39 ` Thomas Petazzoni 2016-09-05 20:05 ` [Buildroot] [PATCH 1/2] package/ffmpeg: opencv2 support is broken if BR2_ARM_ENABLE_VFP is enabled Thomas Petazzoni 1 sibling, 1 reply; 7+ messages in thread From: Bernd Kuhls @ 2016-09-05 14:51 UTC (permalink / raw) To: buildroot Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- package/ffmpeg/ffmpeg.mk | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk index 74f783c..e42cceb 100644 --- a/package/ffmpeg/ffmpeg.mk +++ b/package/ffmpeg/ffmpeg.mk @@ -254,6 +254,9 @@ endif ifeq ($(BR2_PACKAGE_OPENCV_LIB_IMGPROC)x$(BR2_PACKAGE_OPENCV_WITH_FFMPEG)x$(BR2_ARM_ENABLE_VFP),yxx) FFMPEG_CONF_OPTS += --enable-libopencv FFMPEG_DEPENDENCIES += opencv +else ifeq ($(BR2_PACKAGE_OPENCV3_LIB_IMGPROC)x$(BR2_PACKAGE_OPENCV3_WITH_FFMPEG),yx) +FFMPEG_CONF_OPTS += --enable-libopencv +FFMPEG_DEPENDENCIES += opencv3 else FFMPEG_CONF_OPTS += --disable-libopencv endif -- 2.9.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/2] package/ffmpeg: add optional support for opencv3 2016-09-05 14:51 ` [Buildroot] [PATCH 2/2] package/ffmpeg: add optional support for opencv3 Bernd Kuhls @ 2016-09-06 19:39 ` Thomas Petazzoni 0 siblings, 0 replies; 7+ messages in thread From: Thomas Petazzoni @ 2016-09-06 19:39 UTC (permalink / raw) To: buildroot Hello, On Mon, 5 Sep 2016 16:51:20 +0200, Bernd Kuhls wrote: > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > package/ffmpeg/ffmpeg.mk | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk > index 74f783c..e42cceb 100644 > --- a/package/ffmpeg/ffmpeg.mk > +++ b/package/ffmpeg/ffmpeg.mk > @@ -254,6 +254,9 @@ endif > ifeq ($(BR2_PACKAGE_OPENCV_LIB_IMGPROC)x$(BR2_PACKAGE_OPENCV_WITH_FFMPEG)x$(BR2_ARM_ENABLE_VFP),yxx) Due to this line, this patch didn't apply as-is. But I fixed it up, and applied to master. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] package/ffmpeg: opencv2 support is broken if BR2_ARM_ENABLE_VFP is enabled 2016-09-05 14:51 [Buildroot] [PATCH 1/2] package/ffmpeg: opencv2 support is broken if BR2_ARM_ENABLE_VFP is enabled Bernd Kuhls 2016-09-05 14:51 ` [Buildroot] [PATCH 2/2] package/ffmpeg: add optional support for opencv3 Bernd Kuhls @ 2016-09-05 20:05 ` Thomas Petazzoni 2016-09-05 20:20 ` Bernd Kuhls 2016-09-05 22:22 ` Arnout Vandecappelle 1 sibling, 2 replies; 7+ messages in thread From: Thomas Petazzoni @ 2016-09-05 20:05 UTC (permalink / raw) To: buildroot Hello, On Mon, 5 Sep 2016 16:51:19 +0200, Bernd Kuhls wrote: > Fixes > http://autobuild.buildroot.net/results/c32/c32a21240a9933796ee850349a62ff3c2314f25c/ > http://autobuild.buildroot.net/results/22a/22a9769d83d2a398bb6b264d342b2077c41c9cc5/ > > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > package/ffmpeg/ffmpeg.mk | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk > index a90d437..74f783c 100644 > --- a/package/ffmpeg/ffmpeg.mk > +++ b/package/ffmpeg/ffmpeg.mk > @@ -250,7 +250,8 @@ endif > > # To avoid a circular dependency only use opencv if opencv itself does > # not depend on ffmpeg. > -ifeq ($(BR2_PACKAGE_OPENCV_LIB_IMGPROC)x$(BR2_PACKAGE_OPENCV_WITH_FFMPEG),yx) > +# opencv2 is broken if BR2_ARM_ENABLE_VFP is enabled > +ifeq ($(BR2_PACKAGE_OPENCV_LIB_IMGPROC)x$(BR2_PACKAGE_OPENCV_WITH_FFMPEG)x$(BR2_ARM_ENABLE_VFP),yxx) I'm not really happy with this fix. When you're using OpenCV/FFmpeg on ARM, you definitely want to be able to use the VFP. So I'd prefer to see the problem fixed rather than having this combination disabled. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] package/ffmpeg: opencv2 support is broken if BR2_ARM_ENABLE_VFP is enabled 2016-09-05 20:05 ` [Buildroot] [PATCH 1/2] package/ffmpeg: opencv2 support is broken if BR2_ARM_ENABLE_VFP is enabled Thomas Petazzoni @ 2016-09-05 20:20 ` Bernd Kuhls 2016-09-05 22:22 ` Arnout Vandecappelle 1 sibling, 0 replies; 7+ messages in thread From: Bernd Kuhls @ 2016-09-05 20:20 UTC (permalink / raw) To: buildroot Am Mon, 05 Sep 2016 22:05:40 +0200 schrieb Thomas Petazzoni: > Hello, > > On Mon, 5 Sep 2016 16:51:19 +0200, Bernd Kuhls wrote: >> Fixes >> http://autobuild.buildroot.net/results/c32/ c32a21240a9933796ee850349a62ff3c2314f25c/ >> http://autobuild.buildroot.net/ results/22a/22a9769d83d2a398bb6b264d342b2077c41c9cc5/ >> >> Signed-off-by: Bernd Kuhls >> <bernd.kuhls@t-online.de> >> --- >> package/ffmpeg/ffmpeg.mk | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk index >> a90d437..74f783c 100644 --- a/package/ffmpeg/ffmpeg.mk +++ >> b/package/ffmpeg/ffmpeg.mk @@ -250,7 +250,8 @@ endif >> >> # To avoid a circular dependency only use opencv if opencv itself does >> # not depend on ffmpeg. >> -ifeq >> ($(BR2_PACKAGE_OPENCV_LIB_IMGPROC)x $(BR2_PACKAGE_OPENCV_WITH_FFMPEG),yx) >> +# opencv2 is broken if BR2_ARM_ENABLE_VFP is enabled +ifeq >> ($(BR2_PACKAGE_OPENCV_LIB_IMGPROC)x$(BR2_PACKAGE_OPENCV_WITH_FFMPEG)x $(BR2_ARM_ENABLE_VFP),yxx) > > I'm not really happy with this fix. When you're using OpenCV/FFmpeg on > ARM, you definitely want to be able to use the VFP. So I'd prefer to see > the problem fixed rather than having this combination disabled. > > Thomas Hi Thomas, my coding skill are insufficient to fix the problem so I marked my patch as rejected. I tried to compare the ARM_ROUND_DBL function in both opencv2 and opencv3 but the structure of the includes has changed so I was unable to spot the fix which provides working vfp support in opencv3. Regards, Bernd ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] package/ffmpeg: opencv2 support is broken if BR2_ARM_ENABLE_VFP is enabled 2016-09-05 20:05 ` [Buildroot] [PATCH 1/2] package/ffmpeg: opencv2 support is broken if BR2_ARM_ENABLE_VFP is enabled Thomas Petazzoni 2016-09-05 20:20 ` Bernd Kuhls @ 2016-09-05 22:22 ` Arnout Vandecappelle 2016-09-05 22:32 ` Arnout Vandecappelle 1 sibling, 1 reply; 7+ messages in thread From: Arnout Vandecappelle @ 2016-09-05 22:22 UTC (permalink / raw) To: buildroot On 05-09-16 22:05, Thomas Petazzoni wrote: > Hello, > > On Mon, 5 Sep 2016 16:51:19 +0200, Bernd Kuhls wrote: >> Fixes >> http://autobuild.buildroot.net/results/c32/c32a21240a9933796ee850349a62ff3c2314f25c/ >> http://autobuild.buildroot.net/results/22a/22a9769d83d2a398bb6b264d342b2077c41c9cc5/ >> >> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> >> --- >> package/ffmpeg/ffmpeg.mk | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk >> index a90d437..74f783c 100644 >> --- a/package/ffmpeg/ffmpeg.mk >> +++ b/package/ffmpeg/ffmpeg.mk >> @@ -250,7 +250,8 @@ endif >> >> # To avoid a circular dependency only use opencv if opencv itself does >> # not depend on ffmpeg. >> -ifeq ($(BR2_PACKAGE_OPENCV_LIB_IMGPROC)x$(BR2_PACKAGE_OPENCV_WITH_FFMPEG),yx) >> +# opencv2 is broken if BR2_ARM_ENABLE_VFP is enabled >> +ifeq ($(BR2_PACKAGE_OPENCV_LIB_IMGPROC)x$(BR2_PACKAGE_OPENCV_WITH_FFMPEG)x$(BR2_ARM_ENABLE_VFP),yxx) > > I'm not really happy with this fix. When you're using OpenCV/FFmpeg on > ARM, you definitely want to be able to use the VFP. So I'd prefer to > see the problem fixed rather than having this combination disabled. Well, since there is now the possibility to use opencv3 instead, which has fixed the issue, I think this isn't much of a problem, no? Regards, Arnout > > Thomas > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] package/ffmpeg: opencv2 support is broken if BR2_ARM_ENABLE_VFP is enabled 2016-09-05 22:22 ` Arnout Vandecappelle @ 2016-09-05 22:32 ` Arnout Vandecappelle 0 siblings, 0 replies; 7+ messages in thread From: Arnout Vandecappelle @ 2016-09-05 22:32 UTC (permalink / raw) To: buildroot On 06-09-16 00:22, Arnout Vandecappelle wrote: > > > On 05-09-16 22:05, Thomas Petazzoni wrote: >> Hello, >> >> On Mon, 5 Sep 2016 16:51:19 +0200, Bernd Kuhls wrote: >>> Fixes >>> http://autobuild.buildroot.net/results/c32/c32a21240a9933796ee850349a62ff3c2314f25c/ >>> http://autobuild.buildroot.net/results/22a/22a9769d83d2a398bb6b264d342b2077c41c9cc5/ >>> >>> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> >>> --- >>> package/ffmpeg/ffmpeg.mk | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk >>> index a90d437..74f783c 100644 >>> --- a/package/ffmpeg/ffmpeg.mk >>> +++ b/package/ffmpeg/ffmpeg.mk >>> @@ -250,7 +250,8 @@ endif >>> >>> # To avoid a circular dependency only use opencv if opencv itself does >>> # not depend on ffmpeg. >>> -ifeq ($(BR2_PACKAGE_OPENCV_LIB_IMGPROC)x$(BR2_PACKAGE_OPENCV_WITH_FFMPEG),yx) >>> +# opencv2 is broken if BR2_ARM_ENABLE_VFP is enabled >>> +ifeq ($(BR2_PACKAGE_OPENCV_LIB_IMGPROC)x$(BR2_PACKAGE_OPENCV_WITH_FFMPEG)x$(BR2_ARM_ENABLE_VFP),yxx) >> >> I'm not really happy with this fix. When you're using OpenCV/FFmpeg on >> ARM, you definitely want to be able to use the VFP. So I'd prefer to >> see the problem fixed rather than having this combination disabled. > > Well, since there is now the possibility to use opencv3 instead, which has > fixed the issue, I think this isn't much of a problem, no? But actually, isn't it just a matter of replacing asm with __asm__? ffmpeg compiles with -std=c99 so asm doesn't exist. I don't have time to try it now, time to go to sleep ;-) Regards, Arnout -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-09-06 19:39 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-09-05 14:51 [Buildroot] [PATCH 1/2] package/ffmpeg: opencv2 support is broken if BR2_ARM_ENABLE_VFP is enabled Bernd Kuhls 2016-09-05 14:51 ` [Buildroot] [PATCH 2/2] package/ffmpeg: add optional support for opencv3 Bernd Kuhls 2016-09-06 19:39 ` Thomas Petazzoni 2016-09-05 20:05 ` [Buildroot] [PATCH 1/2] package/ffmpeg: opencv2 support is broken if BR2_ARM_ENABLE_VFP is enabled Thomas Petazzoni 2016-09-05 20:20 ` Bernd Kuhls 2016-09-05 22:22 ` Arnout Vandecappelle 2016-09-05 22:32 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox