Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 1/2] buildroot-test: enable toolchains based on hostarch
@ 2016-04-01  0:02 Matt Weber
  2016-04-01  0:02 ` [Buildroot] [PATCH v2 2/2] buildroot-test: failure reason regex update Matt Weber
  2016-04-21 21:05 ` [Buildroot] [PATCH v2 1/2] buildroot-test: enable toolchains based on hostarch Thomas Petazzoni
  0 siblings, 2 replies; 12+ messages in thread
From: Matt Weber @ 2016-04-01  0:02 UTC (permalink / raw)
  To: buildroot

- updated toolchain csv to include hostarch
- fixed logic in autobuild-run to correctly select any, x86_64 vs x86

Signed-off-by: Matt Weber <matt@thewebers.ws>

--
Changes for v2
- Updated toolchain csv file to have internal configs
  listed as any type (Suggested by Thomas)
- Updated autobuild-run script to account for 'any' hostarch
  type as well as x86_64 being capable of running x86 toolchains
  (Sgggested by Thomas)
---
 scripts/autobuild-run                        | 25 +++++++++++--
 web/toolchains/configs/toolchain-configs.csv | 56 ++++++++++++++--------------
 2 files changed, 49 insertions(+), 32 deletions(-)

diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index ca5bdfc..1fbf482 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -259,17 +259,34 @@ def get_toolchain_configs():
     configs = []
 
     (_, _, _, _, hostarch) = os.uname()
-    if hostarch == 'i686' or hostarch == 'x86_64':
+    # ~2015 distros report x86 when on a 32bit install
+    if hostarch == 'i686' or hostarch == 'i386' or hostarch == 'x86':
         hostarch = 'x86'
 
     for row in csv.reader(l):
         config = {}
         config["url"] = row[0]
         config["hostarch"] = row[1]
-        # Ignore toolchains that are not built for the appropriate
-        # host architecture
-        if hostarch != config["hostarch"]:
+        keep = False
+
+        # Keep all toolchain configs that work regardless of the host
+        # architecture
+        if config['hostarch'] == "any":
+            keep = True
+
+        # Keep all toolchain configs that can work on the current host
+        # architecture
+        if hostarch == config["hostarch"]:
+            keep = True
+
+        # Assume that x86 32 bits toolchains work on x86_64 build
+        # machines
+        if hostarch == 'x86_64' and config["hostarch"] == "x86":
+            keep = True
+
+        if not keep:
             continue
+
         config["libc"] = row[2]
         with urlopen_closing(config["url"]) as r:
             config["contents"] = decode_byte_list(r.readlines())
diff --git a/web/toolchains/configs/toolchain-configs.csv b/web/toolchains/configs/toolchain-configs.csv
index 56fbdf7..6872b69 100644
--- a/web/toolchains/configs/toolchain-configs.csv
+++ b/web/toolchains/configs/toolchain-configs.csv
@@ -2,34 +2,34 @@ http://autobuild.buildroot.org/toolchains/configs/armv5-ctng-linux-gnueabi.confi
 http://autobuild.buildroot.org/toolchains/configs/armv7-ctng-linux-gnueabihf.config,x86,glibc
 http://autobuild.buildroot.org/toolchains/configs/bfin-linux-uclibc.config,x86,uclibc
 http://autobuild.buildroot.org/toolchains/configs/bfin-uclinux.config,x86,uclibc
-http://autobuild.buildroot.org/toolchains/configs/br-aarch64-glibc.config,x86,glibc
-http://autobuild.buildroot.org/toolchains/configs/br-arc-full-internal.config,x86,uclibc
-http://autobuild.buildroot.org/toolchains/configs/br-arcle-hs38.config,x86,uclibc
-http://autobuild.buildroot.org/toolchains/configs/br-arm-basic.config,x86,uclibc
-http://autobuild.buildroot.org/toolchains/configs/br-arm-cortex-a9-glibc.config,x86,glibc
-http://autobuild.buildroot.org/toolchains/configs/br-arm-cortex-a9-musl.config,x86,musl
-http://autobuild.buildroot.org/toolchains/configs/br-arm-full.config,x86,uclibc
-http://autobuild.buildroot.org/toolchains/configs/br-arm-full-nothread.config,x86,uclibc
-http://autobuild.buildroot.org/toolchains/configs/br-arm-full-static.config,x86,uclibc
-http://autobuild.buildroot.org/toolchains/configs/br-arm-internal-full.config,x86,uclibc
-http://autobuild.buildroot.org/toolchains/configs/br-i386-pentium4-full.config,x86,uclibc
-http://autobuild.buildroot.org/toolchains/configs/br-microblazeel-full.config,x86,glibc
-http://autobuild.buildroot.org/toolchains/configs/br-microblazeel-full-internal.config,x86,glibc
-http://autobuild.buildroot.org/toolchains/configs/br-mips64-n64-full.config,x86,uclibc
-http://autobuild.buildroot.org/toolchains/configs/br-mips32r6-el-hf-glibc.config,x86,glibc
-http://autobuild.buildroot.org/toolchains/configs/br-mips64r6-el-hf-glibc.config,x86,glibc
-http://autobuild.buildroot.org/toolchains/configs/br-mipsel-o32-full.config,x86,uclibc
-http://autobuild.buildroot.org/toolchains/configs/br-nios2-glibc.config,x86,glibc
-http://autobuild.buildroot.org/toolchains/configs/br-powerpc-603e-basic-cpp.config,x86,uclibc
-http://autobuild.buildroot.org/toolchains/configs/br-powerpc-e500mc-full.config,x86,uclibc
-http://autobuild.buildroot.org/toolchains/configs/br-powerpc-internal-full.config,x86,uclibc
-http://autobuild.buildroot.org/toolchains/configs/br-sh4-full.config,x86,uclibc
-http://autobuild.buildroot.org/toolchains/configs/br-sparc-glibc.config,x86,glibc
-http://autobuild.buildroot.org/toolchains/configs/br-sparc64-glibc.config,x86,glibc
-http://autobuild.buildroot.org/toolchains/configs/br-x86-64-core2-full.config,x86,uclibc
-http://autobuild.buildroot.org/toolchains/configs/br-x86-64-musl.config,x86,musl
-http://autobuild.buildroot.org/toolchains/configs/br-xtensa-full.config,x86,uclibc
-http://autobuild.buildroot.org/toolchains/configs/br-xtensa-full-internal.config,x86,uclibc
+http://autobuild.buildroot.org/toolchains/configs/br-aarch64-glibc.config,x86_64,glibc
+http://autobuild.buildroot.org/toolchains/configs/br-arc-full-internal.config,any,uclibc
+http://autobuild.buildroot.org/toolchains/configs/br-arcle-hs38.config,x86_64,uclibc
+http://autobuild.buildroot.org/toolchains/configs/br-arm-basic.config,x86_64,uclibc
+http://autobuild.buildroot.org/toolchains/configs/br-arm-cortex-a9-glibc.config,x86_64,glibc
+http://autobuild.buildroot.org/toolchains/configs/br-arm-cortex-a9-musl.config,x86_64,musl
+http://autobuild.buildroot.org/toolchains/configs/br-arm-full.config,x86_64,uclibc
+http://autobuild.buildroot.org/toolchains/configs/br-arm-full-nothread.config,x86_64,uclibc
+http://autobuild.buildroot.org/toolchains/configs/br-arm-full-static.config,x86_64,uclibc
+http://autobuild.buildroot.org/toolchains/configs/br-arm-internal-full.config,any,uclibc
+http://autobuild.buildroot.org/toolchains/configs/br-i386-pentium4-full.config,x86_64,uclibc
+http://autobuild.buildroot.org/toolchains/configs/br-microblazeel-full.config,x86_64,glibc
+http://autobuild.buildroot.org/toolchains/configs/br-microblazeel-full-internal.config,any,glibc
+http://autobuild.buildroot.org/toolchains/configs/br-mips64-n64-full.config,x86_64,uclibc
+http://autobuild.buildroot.org/toolchains/configs/br-mips32r6-el-hf-glibc.config,x86_64,glibc
+http://autobuild.buildroot.org/toolchains/configs/br-mips64r6-el-hf-glibc.config,x86_64,glibc
+http://autobuild.buildroot.org/toolchains/configs/br-mipsel-o32-full.config,x86_64,uclibc
+http://autobuild.buildroot.org/toolchains/configs/br-nios2-glibc.config,x86_64,glibc
+http://autobuild.buildroot.org/toolchains/configs/br-powerpc-603e-basic-cpp.config,x86_64,uclibc
+http://autobuild.buildroot.org/toolchains/configs/br-powerpc-e500mc-full.config,x86_64,uclibc
+http://autobuild.buildroot.org/toolchains/configs/br-powerpc-internal-full.config,any,uclibc
+http://autobuild.buildroot.org/toolchains/configs/br-sh4-full.config,x86_64,uclibc
+http://autobuild.buildroot.org/toolchains/configs/br-sparc-glibc.config,x86_64,glibc
+http://autobuild.buildroot.org/toolchains/configs/br-sparc64-glibc.config,x86_64,glibc
+http://autobuild.buildroot.org/toolchains/configs/br-x86-64-core2-full.config,x86_64,uclibc
+http://autobuild.buildroot.org/toolchains/configs/br-x86-64-musl.config,x86_64,musl
+http://autobuild.buildroot.org/toolchains/configs/br-xtensa-full.config,x86_64,uclibc
+http://autobuild.buildroot.org/toolchains/configs/br-xtensa-full-internal.config,any,uclibc
 http://autobuild.buildroot.org/toolchains/configs/i686-ctng-linux-gnu.config,x86,glibc
 http://autobuild.buildroot.org/toolchains/configs/linaro-aarch64.config,x86,glibc
 http://autobuild.buildroot.org/toolchains/configs/linaro-arm.config,x86,glibc
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH v2 2/2] buildroot-test: failure reason regex update
  2016-04-01  0:02 [Buildroot] [PATCH v2 1/2] buildroot-test: enable toolchains based on hostarch Matt Weber
@ 2016-04-01  0:02 ` Matt Weber
  2016-04-01  1:55   ` Thomas Petazzoni
  2016-09-06 20:04   ` Thomas Petazzoni
  2016-04-21 21:05 ` [Buildroot] [PATCH v2 1/2] buildroot-test: enable toolchains based on hostarch Thomas Petazzoni
  1 sibling, 2 replies; 12+ messages in thread
From: Matt Weber @ 2016-04-01  0:02 UTC (permalink / raw)
  To: buildroot

- Sub-make required one additional line tailed
- Both autobuild-run  regex to truncate end log
  and import which sets the failure reason on
  the report are updated

Signed-off-by: Matt Weber <matt@thewebers.ws>

--
Changes for v2:
- Added back in : as previous test masked
  that is was ok to leave in (Suggested by Thomas)
---
 scripts/autobuild-run | 4 ++--
 web/import.inc.php    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index 1fbf482..f9743a8 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -665,10 +665,10 @@ def send_results(result, **kwargs):
     def get_failure_reason():
         # Output is a tuple (package, version), or None.
         lastlines = decode_bytes(subprocess.Popen(
-            ["tail", "-n", "3", os.path.join(outputdir, "logfile")],
+            ["tail", "-n", "4", os.path.join(outputdir, "logfile")],
             stdout=subprocess.PIPE).communicate()[0]).splitlines()
 
-        regexp = re.compile(r'make: \*\*\* .*/(?:build|toolchain)/([^/]*)/')
+        regexp = re.compile(r'make.*: \*\*\* .*/(?:build|toolchain)/([^/]*)/')
         for line in lastlines:
             m = regexp.search(line)
             if m:
diff --git a/web/import.inc.php b/web/import.inc.php
index 243a1f3..e169f6f 100644
--- a/web/import.inc.php
+++ b/web/import.inc.php
@@ -102,7 +102,7 @@ function import_result($buildid, $filename)
       $reason = "none";
     else {
 	$tmp = Array();
-	exec("tail -3 " . $thisbuildfinaldir . "build-end.log | grep -v '\[_all\]' | grep 'make.*: \*\*\*' | sed 's,.*\[\([^\]*\)\] Error.*,\\1,' | sed 's,.*/build/\([^/]*\)/.*,\\1,'", $tmp);
+	exec("tail -4 " . $thisbuildfinaldir . "build-end.log | grep -v '\[_all\]' | grep 'make.*: \*\*\*' | sed 's,.*\[\([^\]*\)\] Error.*,\\1,' | sed 's,.*/build/\([^/]*\)/.*,\\1,'", $tmp);
 	if (trim($tmp[0]))
 	  $reason = $tmp[0];
 	else
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH v2 2/2] buildroot-test: failure reason regex update
  2016-04-01  0:02 ` [Buildroot] [PATCH v2 2/2] buildroot-test: failure reason regex update Matt Weber
@ 2016-04-01  1:55   ` Thomas Petazzoni
  2016-04-01  2:37     ` Matthew Weber
  2016-09-06 20:04   ` Thomas Petazzoni
  1 sibling, 1 reply; 12+ messages in thread
From: Thomas Petazzoni @ 2016-04-01  1:55 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu, 31 Mar 2016 19:02:52 -0500, Matt Weber wrote:
> - Sub-make required one additional line tailed

Really? Did you look at my previous review, where I showed the
different examples I could find, and showed that 3 lines were enough?

It's not like I care particularly whether we're tailing 3 or 4 lines,
it's more that I want to understand why in your scenario you would need
4 lines.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH v2 2/2] buildroot-test: failure reason regex update
  2016-04-01  1:55   ` Thomas Petazzoni
@ 2016-04-01  2:37     ` Matthew Weber
  2016-04-01  3:58       ` Thomas Petazzoni
  0 siblings, 1 reply; 12+ messages in thread
From: Matthew Weber @ 2016-04-01  2:37 UTC (permalink / raw)
  To: buildroot

Thomas,
On Mar 31, 2016 8:55 PM, "Thomas Petazzoni" <
thomas.petazzoni@free-electrons.com> wrote:
>
> Hello,
>
> On Thu, 31 Mar 2016 19:02:52 -0500, Matt Weber wrote:
> > - Sub-make required one additional line tailed
>
> Really? Did you look at my previous review, where I showed the
> different examples I could find, and showed that 3 lines were enough?

I did and I haven't figured out why yet

>
> It's not like I care particularly whether we're tailing 3 or 4 lines,
> it's more that I want to understand why in your scenario you would need
> 4 lines.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160331/6bbbc407/attachment.html>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH v2 2/2] buildroot-test: failure reason regex update
  2016-04-01  2:37     ` Matthew Weber
@ 2016-04-01  3:58       ` Thomas Petazzoni
  2016-04-01  4:04         ` Matthew Weber
  0 siblings, 1 reply; 12+ messages in thread
From: Thomas Petazzoni @ 2016-04-01  3:58 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu, 31 Mar 2016 21:37:30 -0500, Matthew Weber wrote:

> > Really? Did you look at my previous review, where I showed the
> > different examples I could find, and showed that 3 lines were enough?
> 
> I did and I haven't figured out why yet

Well, can you show the last 10 lines of your build logs, which require
4 lines for the script to detect the failure reason?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH v2 2/2] buildroot-test: failure reason regex update
  2016-04-01  3:58       ` Thomas Petazzoni
@ 2016-04-01  4:04         ` Matthew Weber
  2016-04-01  4:21           ` Thomas Petazzoni
  0 siblings, 1 reply; 12+ messages in thread
From: Matthew Weber @ 2016-04-01  4:04 UTC (permalink / raw)
  To: buildroot

On Thu, Mar 31, 2016 at 10:58 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Thu, 31 Mar 2016 21:37:30 -0500, Matthew Weber wrote:
>
>> > Really? Did you look at my previous review, where I showed the
>> > different examples I could find, and showed that 3 lines were enough?
>>
>> I did and I haven't figured out why yet
>
> Well, can you show the last 10 lines of your build logs, which require
> 4 lines for the script to detect the failure reason?
>

    ^
futility/cmd_gbb_utility.c: In function 'do_gbb_utility':
futility/cmd_gbb_utility.c:558:5: warning: format '%lli' expects
argument of type 'long long int', but argument 3 has type 'off_t {aka
long int}' [-Wformat=]
     "ERROR: can't malloc %" PRIi64 " bytes: %s\n",
     ^
    CC            futility/ryu_root_header.o
    CC            firmware/stub/vboot_api_stub_static_sf.o
    GEN           gen/futility_static_cmds.c
    CC            cgpt/cgpt_create.o
    CC            cgpt/cgpt_add.o
    CC            cgpt/cgpt_boot.o
    CC            cgpt/cgpt_show.o
    CC            cgpt/cgpt_repair.o
    CC            cgpt/cgpt_prioritize.o
    CC            cgpt/cgpt_common.o
make[2]: *** No rule to make target
'/opt/buildroot_testing/buildroot-test/instance-0/output/build/host-vboot-utils-bbdd62f9b030db7ad8eef789aaf58a7ff9a25656/build/host/arch/i686/lib/crossystem_arch.o',
needed by '/opt/buildroot_testing/buildroot-test/instance-0/output/build/host-vboot-utils-bbdd62f9b030db7ad8eef789aaf58a7ff9a25656/build/libvboot_util.a'.
Stop.
make[2]: *** Waiting for unfinished jobs....
    CC            futility/dump_kernel_config_lib.o
package/pkg-generic.mk:195: recipe for target
'/opt/buildroot_testing/buildroot-test/instance-0/output/build/host-vboot-utils-bbdd62f9b030db7ad8eef789aaf58a7ff9a25656/.stamp_built'
failed
make[1]: *** [/opt/buildroot_testing/buildroot-test/instance-0/output/build/host-vboot-utils-bbdd62f9b030db7ad8eef789aaf58a7ff9a25656/.stamp_built]
Error 2
Makefile:36: recipe for target '_all' failed
make: *** [_all] Error 2
make: Leaving directory
'/opt/buildroot_testing/buildroot-test/instance-0/buildroot'


-- 
Thanks,
Matt

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH v2 2/2] buildroot-test: failure reason regex update
  2016-04-01  4:04         ` Matthew Weber
@ 2016-04-01  4:21           ` Thomas Petazzoni
  0 siblings, 0 replies; 12+ messages in thread
From: Thomas Petazzoni @ 2016-04-01  4:21 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu, 31 Mar 2016 23:04:57 -0500, Matthew Weber wrote:

> make[1]: *** [/opt/buildroot_testing/buildroot-test/instance-0/output/build/host-vboot-utils-bbdd62f9b030db7ad8eef789aaf58a7ff9a25656/.stamp_built] Error 2
> Makefile:36: recipe for target '_all' failed
> make: *** [_all] Error 2
> make: Leaving directory '/opt/buildroot_testing/buildroot-test/instance-0/buildroot'

Weird, this is this last line that I don't see here:

make[1]: *** [/home/thomas/projets/outputs/toto/build/makedevs-buildroot-2016.05-git/.stamp_built] Error 127
Makefile:16: recipe for target '_all' failed
make: *** [_all] Error 2

But on the other hand,
http://autobuild.buildroot.org/results/b55/b5539c22ee35a36ae3fe4967040ea04b11889a4c/build-end.log
has this last line, but doesn't have the "recipe for target ... failed"
line.

Oh well, I guess I'm just going to take your patch as-is. Maybe some
make guru like Arnout will have a good explanation for those
differences, but it's not important enough to spend too much time on
this.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH v2 1/2] buildroot-test: enable toolchains based on hostarch
  2016-04-01  0:02 [Buildroot] [PATCH v2 1/2] buildroot-test: enable toolchains based on hostarch Matt Weber
  2016-04-01  0:02 ` [Buildroot] [PATCH v2 2/2] buildroot-test: failure reason regex update Matt Weber
@ 2016-04-21 21:05 ` Thomas Petazzoni
  1 sibling, 0 replies; 12+ messages in thread
From: Thomas Petazzoni @ 2016-04-21 21:05 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu, 31 Mar 2016 19:02:51 -0500, Matt Weber wrote:
> - updated toolchain csv to include hostarch
> - fixed logic in autobuild-run to correctly select any, x86_64 vs x86
> 
> Signed-off-by: Matt Weber <matt@thewebers.ws>
> 
> --
> Changes for v2
> - Updated toolchain csv file to have internal configs
>   listed as any type (Suggested by Thomas)
> - Updated autobuild-run script to account for 'any' hostarch
>   type as well as x86_64 being capable of running x86 toolchains
>   (Sgggested by Thomas)
> ---
>  scripts/autobuild-run                        | 25 +++++++++++--
>  web/toolchains/configs/toolchain-configs.csv | 56 ++++++++++++++--------------
>  2 files changed, 49 insertions(+), 32 deletions(-)

Applied to buildroot-test, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH v2 2/2] buildroot-test: failure reason regex update
  2016-04-01  0:02 ` [Buildroot] [PATCH v2 2/2] buildroot-test: failure reason regex update Matt Weber
  2016-04-01  1:55   ` Thomas Petazzoni
@ 2016-09-06 20:04   ` Thomas Petazzoni
  2016-09-06 21:20     ` Yann E. MORIN
  2016-09-07  7:17     ` Thomas Petazzoni
  1 sibling, 2 replies; 12+ messages in thread
From: Thomas Petazzoni @ 2016-09-06 20:04 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu, 31 Mar 2016 19:02:52 -0500, Matt Weber wrote:
> - Sub-make required one additional line tailed
> - Both autobuild-run  regex to truncate end log
>   and import which sets the failure reason on
>   the report are updated
> 
> Signed-off-by: Matt Weber <matt@thewebers.ws>
> 
> --
> Changes for v2:
> - Added back in : as previous test masked
>   that is was ok to leave in (Suggested by Thomas)
> ---
>  scripts/autobuild-run | 4 ++--
>  web/import.inc.php    | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

Applied to buildroot-test, and deployed on autobuild.b.o. Of course,
it's up to the people using autobuild-run to update it on their side.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH v2 2/2] buildroot-test: failure reason regex update
  2016-09-06 20:04   ` Thomas Petazzoni
@ 2016-09-06 21:20     ` Yann E. MORIN
  2016-09-07  7:17     ` Thomas Petazzoni
  1 sibling, 0 replies; 12+ messages in thread
From: Yann E. MORIN @ 2016-09-06 21:20 UTC (permalink / raw)
  To: buildroot

Thomas, Matt,

On 2016-09-06 22:04 +0200, Thomas Petazzoni spake thusly:
> On Thu, 31 Mar 2016 19:02:52 -0500, Matt Weber wrote:
> > - Sub-make required one additional line tailed
> > - Both autobuild-run  regex to truncate end log
> >   and import which sets the failure reason on
> >   the report are updated
> > 
> > Signed-off-by: Matt Weber <matt@thewebers.ws>
> > 
> > --
> > Changes for v2:
> > - Added back in : as previous test masked
> >   that is was ok to leave in (Suggested by Thomas)
> > ---
> >  scripts/autobuild-run | 4 ++--
> >  web/import.inc.php    | 2 +-
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> Applied to buildroot-test, and deployed on autobuild.b.o. Of course,
> it's up to the people using autobuild-run to update it on their side.

Done! ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH v2 2/2] buildroot-test: failure reason regex update
  2016-09-06 20:04   ` Thomas Petazzoni
  2016-09-06 21:20     ` Yann E. MORIN
@ 2016-09-07  7:17     ` Thomas Petazzoni
  2016-09-07  8:59       ` Yann E. MORIN
  1 sibling, 1 reply; 12+ messages in thread
From: Thomas Petazzoni @ 2016-09-07  7:17 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue, 6 Sep 2016 22:04:59 +0200, Thomas Petazzoni wrote:
> Hello,
> 
> On Thu, 31 Mar 2016 19:02:52 -0500, Matt Weber wrote:
> > - Sub-make required one additional line tailed
> > - Both autobuild-run  regex to truncate end log
> >   and import which sets the failure reason on
> >   the report are updated
> > 
> > Signed-off-by: Matt Weber <matt@thewebers.ws>
> > 
> > --
> > Changes for v2:
> > - Added back in : as previous test masked
> >   that is was ok to leave in (Suggested by Thomas)
> > ---
> >  scripts/autobuild-run | 4 ++--
> >  web/import.inc.php    | 2 +-
> >  2 files changed, 3 insertions(+), 3 deletions(-)  
> 
> Applied to buildroot-test, and deployed on autobuild.b.o. Of course,
> it's up to the people using autobuild-run to update it on their side.

And I just reverted this commit, as it broke the autobuilders. For a
large number of builds, the failure reason was no longer identified
properly, and the script was concluding that the failure reason was
"all" or "all-recursive" or "lib", i.e the name of a make target, and
not the name of the package.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Buildroot] [PATCH v2 2/2] buildroot-test: failure reason regex update
  2016-09-07  7:17     ` Thomas Petazzoni
@ 2016-09-07  8:59       ` Yann E. MORIN
  0 siblings, 0 replies; 12+ messages in thread
From: Yann E. MORIN @ 2016-09-07  8:59 UTC (permalink / raw)
  To: buildroot

Thomas, All,

On 2016-09-07 09:17 +0200, Thomas Petazzoni spake thusly:
> On Tue, 6 Sep 2016 22:04:59 +0200, Thomas Petazzoni wrote:
> > Hello,
> > 
> > On Thu, 31 Mar 2016 19:02:52 -0500, Matt Weber wrote:
> > > - Sub-make required one additional line tailed
> > > - Both autobuild-run  regex to truncate end log
> > >   and import which sets the failure reason on
> > >   the report are updated
> > > 
> > > Signed-off-by: Matt Weber <matt@thewebers.ws>
> > > 
> > > --
> > > Changes for v2:
> > > - Added back in : as previous test masked
> > >   that is was ok to leave in (Suggested by Thomas)
> > > ---
> > >  scripts/autobuild-run | 4 ++--
> > >  web/import.inc.php    | 2 +-
> > >  2 files changed, 3 insertions(+), 3 deletions(-)  
> > 
> > Applied to buildroot-test, and deployed on autobuild.b.o. Of course,
> > it's up to the people using autobuild-run to update it on their side.
> 
> And I just reverted this commit, as it broke the autobuilders. For a
> large number of builds, the failure reason was no longer identified
> properly, and the script was concluding that the failure reason was
> "all" or "all-recursive" or "lib", i.e the name of a make target, and
> not the name of the package.

OK, updated and restarted. ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2016-09-07  8:59 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-01  0:02 [Buildroot] [PATCH v2 1/2] buildroot-test: enable toolchains based on hostarch Matt Weber
2016-04-01  0:02 ` [Buildroot] [PATCH v2 2/2] buildroot-test: failure reason regex update Matt Weber
2016-04-01  1:55   ` Thomas Petazzoni
2016-04-01  2:37     ` Matthew Weber
2016-04-01  3:58       ` Thomas Petazzoni
2016-04-01  4:04         ` Matthew Weber
2016-04-01  4:21           ` Thomas Petazzoni
2016-09-06 20:04   ` Thomas Petazzoni
2016-09-06 21:20     ` Yann E. MORIN
2016-09-07  7:17     ` Thomas Petazzoni
2016-09-07  8:59       ` Yann E. MORIN
2016-04-21 21:05 ` [Buildroot] [PATCH v2 1/2] buildroot-test: enable toolchains based on hostarch Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox