From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] core: distclean is a noconfig target
Date: Sun, 11 Sep 2016 15:46:27 +0200 [thread overview]
Message-ID: <20160911134627.GL5740@free.fr> (raw)
In-Reply-To: <20160911153404.06d0d424@free-electrons.com>
Thomas, All,
On 2016-09-11 15:34 +0200, Thomas Petazzoni spake thusly:
> On Sun, 11 Sep 2016 14:56:38 +0200, Yann E. MORIN wrote:
> > @@ -86,7 +86,7 @@ export BR2_VERSION_FULL := $(BR2_VERSION)$(shell $(TOPDIR)/support/scripts/setlo
> > noconfig_targets := menuconfig nconfig gconfig xconfig config oldconfig randconfig \
> > defconfig %_defconfig allyesconfig allnoconfig silentoldconfig release \
> > randpackageconfig allyespackageconfig allnopackageconfig \
> > - print-version olddefconfig
> > + print-version olddefconfig distclean
>
> The distclean target uses the DL_DIR variable, which is derived from
> BR2_DL_DIR, which can come from either the environment... or the
> configuration file. So, the BR2_DL_DIR from the configuration will be
> ignored. I'm not sure what the consequence is, but it's worth thinking
> about this.
Well, if either is set on not the default, then it is currently not
removed.
With this change, however, it is no longer removed, indeed.
But, why are we even having this removal conditional? We can just
unconditionally remove $(TOPDIR)/dl and be done with that, no?
> Also, what is the rationale for having just "distclean" and not "clean"
> in noconfig_targets ? The fact that "distclean" remove the
> configuration, and as such "helps" in solving configuration issues ?
Exactly.
Otherwise one has to manually remove the .config file, which is not
very nice...
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2016-09-11 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-11 12:56 [Buildroot] [PATCH] core: distclean is a noconfig target Yann E. MORIN
2016-09-11 13:34 ` Thomas Petazzoni
2016-09-11 13:46 ` Yann E. MORIN [this message]
2016-09-11 20:44 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160911134627.GL5740@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox