From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] core: distclean is a noconfig target
Date: Sun, 11 Sep 2016 15:34:04 +0200 [thread overview]
Message-ID: <20160911153404.06d0d424@free-electrons.com> (raw)
In-Reply-To: <1473598598-5546-1-git-send-email-yann.morin.1998@free.fr>
Hello,
On Sun, 11 Sep 2016 14:56:38 +0200, Yann E. MORIN wrote:
> When the .config contains invalid configuration *(e.g. two providers for
> a same virtual pacakge), it is not possible to run "make distclean"
pacakge -> package
> @@ -86,7 +86,7 @@ export BR2_VERSION_FULL := $(BR2_VERSION)$(shell $(TOPDIR)/support/scripts/setlo
> noconfig_targets := menuconfig nconfig gconfig xconfig config oldconfig randconfig \
> defconfig %_defconfig allyesconfig allnoconfig silentoldconfig release \
> randpackageconfig allyespackageconfig allnopackageconfig \
> - print-version olddefconfig
> + print-version olddefconfig distclean
The distclean target uses the DL_DIR variable, which is derived from
BR2_DL_DIR, which can come from either the environment... or the
configuration file. So, the BR2_DL_DIR from the configuration will be
ignored. I'm not sure what the consequence is, but it's worth thinking
about this.
Also, what is the rationale for having just "distclean" and not "clean"
in noconfig_targets ? The fact that "distclean" remove the
configuration, and as such "helps" in solving configuration issues ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-09-11 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-11 12:56 [Buildroot] [PATCH] core: distclean is a noconfig target Yann E. MORIN
2016-09-11 13:34 ` Thomas Petazzoni [this message]
2016-09-11 13:46 ` Yann E. MORIN
2016-09-11 20:44 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160911153404.06d0d424@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox