[Buildroot] [PATCH] package/php-ssh2: fix kconfig circular deps after libssh2 fix

[Buildroot] [PATCH] package/php-ssh2: fix kconfig circular deps after libssh2 fix

[Yann E. MORIN]

After we simplified the libssh2 dependencies, the new dependencies were
not propagated to the php-ssh2 package, causing circular dependencies:

    package/openssl/Config.in:1:error: recursive dependency detected!
    package/openssl/Config.in:1:    symbol BR2_PACKAGE_OPENSSL is selected by BR2_PACKAGE_LIBSSH2
    package/libssh2/Config.in:1:    symbol BR2_PACKAGE_LIBSSH2 is selected by BR2_PACKAGE_PHP_SSH2
    package/php-ssh2/Config.in:1:   symbol BR2_PACKAGE_PHP_SSH2 depends on BR2_PACKAGE_OPENSSL

Just drop the now-useless dependency inherited from libssh2: libssh2 now
has no dependency.

Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Arnout Vandecappelle <arnout@mind.be>
---
 package/php-ssh2/Config.in | 2 --
 1 file changed, 2 deletions(-)

diff --git a/package/php-ssh2/Config.in b/package/php-ssh2/Config.in
index c795dd5..b457900 100644
--- a/package/php-ssh2/Config.in
+++ b/package/php-ssh2/Config.in
@@ -1,8 +1,6 @@
 config BR2_PACKAGE_PHP_SSH2
 	bool "php-ssh2"
 	depends on BR2_PACKAGE_PHP
-	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS \
-		&& !BR2_PACKAGE_OPENSSL # libssh2, libgcrypt
 	select BR2_PACKAGE_LIBSSH2
 	help
 	  PHP bindings for the libssh2 library.
-- 
2.7.4

[Buildroot] [PATCH] package/php-ssh2: fix kconfig circular deps after libssh2 fix

[Arnout Vandecappelle]

On 11-09-16 23:49, Yann E. MORIN wrote:
> After we simplified the libssh2 dependencies, the new dependencies were
> not propagated to the php-ssh2 package, causing circular dependencies:
> 
>     package/openssl/Config.in:1:error: recursive dependency detected!
>     package/openssl/Config.in:1:    symbol BR2_PACKAGE_OPENSSL is selected by BR2_PACKAGE_LIBSSH2
>     package/libssh2/Config.in:1:    symbol BR2_PACKAGE_LIBSSH2 is selected by BR2_PACKAGE_PHP_SSH2
>     package/php-ssh2/Config.in:1:   symbol BR2_PACKAGE_PHP_SSH2 depends on BR2_PACKAGE_OPENSSL
> 
> Just drop the now-useless dependency inherited from libssh2: libssh2 now
> has no dependency.
> 
> Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Arnout Vandecappelle <arnout@mind.be>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Thanks for the speedy fix!

 Regards,
 Arnout

> ---
>  package/php-ssh2/Config.in | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/package/php-ssh2/Config.in b/package/php-ssh2/Config.in
> index c795dd5..b457900 100644
> --- a/package/php-ssh2/Config.in
> +++ b/package/php-ssh2/Config.in
> @@ -1,8 +1,6 @@
>  config BR2_PACKAGE_PHP_SSH2
>  	bool "php-ssh2"
>  	depends on BR2_PACKAGE_PHP
> -	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS \
> -		&& !BR2_PACKAGE_OPENSSL # libssh2, libgcrypt
>  	select BR2_PACKAGE_LIBSSH2
>  	help
>  	  PHP bindings for the libssh2 library.
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH] package/php-ssh2: fix kconfig circular deps after libssh2 fix

[Thomas Petazzoni]

Hello,

On Sun, 11 Sep 2016 23:49:19 +0200, Yann E. MORIN wrote:
> After we simplified the libssh2 dependencies, the new dependencies were
> not propagated to the php-ssh2 package, causing circular dependencies:
> 
>     package/openssl/Config.in:1:error: recursive dependency detected!
>     package/openssl/Config.in:1:    symbol BR2_PACKAGE_OPENSSL is selected by BR2_PACKAGE_LIBSSH2
>     package/libssh2/Config.in:1:    symbol BR2_PACKAGE_LIBSSH2 is selected by BR2_PACKAGE_PHP_SSH2
>     package/php-ssh2/Config.in:1:   symbol BR2_PACKAGE_PHP_SSH2 depends on BR2_PACKAGE_OPENSSL
> 
> Just drop the now-useless dependency inherited from libssh2: libssh2 now
> has no dependency.
> 
> Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> ---
>  package/php-ssh2/Config.in | 2 --
>  1 file changed, 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com