* [Buildroot] [PATCH] breakpad: enable for uClibc
@ 2016-09-15 0:46 gustavo.zacarias at free-electrons.com
2016-09-16 17:01 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: gustavo.zacarias at free-electrons.com @ 2016-09-15 0:46 UTC (permalink / raw)
To: buildroot
From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
There's nothing holding it off for uClibc-based toolchains so enable it.
Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
---
Config.in | 3 ++-
package/google-breakpad/Config.in | 8 +++++---
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/Config.in b/Config.in
index e614c8f..f3b6649 100644
--- a/Config.in
+++ b/Config.in
@@ -553,7 +553,8 @@ config BR2_GOOGLE_BREAKPAD_ENABLE
bool "Enable google-breakpad support"
select BR2_PACKAGE_GOOGLE_BREAKPAD
depends on BR2_INSTALL_LIBSTDCPP
- depends on BR2_TOOLCHAIN_USES_GLIBC
+ depends on BR2_USE_WCHAR
+ depends on (BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC)
depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
help
This option will enable the use of google breakpad, a library
diff --git a/package/google-breakpad/Config.in b/package/google-breakpad/Config.in
index 7b8eeb1..06895af 100644
--- a/package/google-breakpad/Config.in
+++ b/package/google-breakpad/Config.in
@@ -6,7 +6,8 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
config BR2_PACKAGE_GOOGLE_BREAKPAD
bool "google-breakpad"
depends on BR2_INSTALL_LIBSTDCPP
- depends on BR2_TOOLCHAIN_USES_GLIBC
+ depends on BR2_USE_WCHAR
+ depends on (BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC)
depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
help
Google-Breakpad is a library and tool suite that allows you
@@ -29,6 +30,7 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD
http://code.google.com/p/google-breakpad/
-comment "google-breakpad requires a glibc toolchain w/ C++ enabled"
+comment "google-breakpad requires a glibc or uClibc toolchain w/ wchar, C++ enabled"
depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
- depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_USES_GLIBC
+ depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
+ !(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC)
--
2.7.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] breakpad: enable for uClibc
2016-09-15 0:46 [Buildroot] [PATCH] breakpad: enable for uClibc gustavo.zacarias at free-electrons.com
@ 2016-09-16 17:01 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2016-09-16 17:01 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 14 Sep 2016 21:46:29 -0300, gustavo.zacarias at free-electrons.com
wrote:
> From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
>
> There's nothing holding it off for uClibc-based toolchains so enable it.
>
> Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
> ---
> Config.in | 3 ++-
> package/google-breakpad/Config.in | 8 +++++---
> 2 files changed, 7 insertions(+), 4 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-16 17:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-15 0:46 [Buildroot] [PATCH] breakpad: enable for uClibc gustavo.zacarias at free-electrons.com
2016-09-16 17:01 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox