Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] php: bump 7.0.11
Date: Sat, 17 Sep 2016 11:21:12 +0200	[thread overview]
Message-ID: <20160917112112.53a0e5cf@free-electrons.com> (raw)
In-Reply-To: <CANqewP2HZviH=vUGPu4JDrOKgpTjXx9BuVbO23PiM5u27+t5OA@mail.gmail.com>

Hello,

On Sat, 17 Sep 2016 07:36:54 +0000, Tatsuyuki Ishi wrote:
> Thank you, the following is the updated patch.

Thanks. But this patch also cannot be applied, for two reasons:

 - The changelog part of the message such as "Thank you, the
   following..." should not be part of the commit log, but instead
   should be below the "---" so that it does not get integrated in the
   Git history when the patch is applied.

 - Since you haven't used git send-email, your patch is line-wrapped
   (i.e long lines are wrapped), so it cannot be applied.

Could you rework your patch to take into account those comments?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-09-17  9:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-16  7:47 [Buildroot] [PATCH] php: bump 7.0.11 Tatsuyuki Ishi
2016-09-16 16:41 ` Thomas Petazzoni
2016-09-17  7:36   ` Tatsuyuki Ishi
2016-09-17  9:21     ` Thomas Petazzoni [this message]
2016-09-17 10:47       ` Tatsuyuki Ishi
2016-09-17 10:59         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160917112112.53a0e5cf@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox