Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] php: bump 7.0.11
Date: Fri, 16 Sep 2016 18:41:13 +0200	[thread overview]
Message-ID: <20160916184113.6fd787c1@free-electrons.com> (raw)
In-Reply-To: <CANqewP0UNjM_Ya=awwHEC+H3+h8UH=DLFv9YoTihOw_sK4Ld9g@mail.gmail.com>

Hello,

On Fri, 16 Sep 2016 07:47:06 +0000, Tatsuyuki Ishi wrote:
> See the attached patch.

Thanks for this patch. However, we prefer to have patches "inline"
rather as attached files, as it makes the review easier. We recommend
to use "git send-email" to send patches.

In addition, your patches does not apply. Your change to php.hash is:

 # From http://php.net/downloads.php
-sha256 970c322ba3e472cb0264b8ba9d4d92e87918da5d0cca53c4aba2a70545b8626d  php-7.0.9.tar.xz
+sha256 d4cccea8da1d27c11b89386f8b8e95692ad3356610d571253d00ca67d524c735  php-7.0.11.tar.xz
 sha256 44cab15d57b2fb8fa916ff9291059a34b0c3fa99298c2b08a5082f334613753a  yaml-2.0.0RC8.tgz
 sha256 bb13da909a7a7ae1f9e499166103a2d24628993238ce03a8aae3eaa492c0b736  pthreads-3.1.6.tgz
 sha256 dc09445c0395bf21d06f21af64697d95244e1a06baade88afa7e07ef75d9b180  Weakref-0.3.2.tgz

But this does not match the php.hash in current Buildroot master, which
doesn't have any reference to the yaml, pthreads or Weakref tarballs.

Could you rework your patch and send an updated version?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-09-16 16:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-16  7:47 [Buildroot] [PATCH] php: bump 7.0.11 Tatsuyuki Ishi
2016-09-16 16:41 ` Thomas Petazzoni [this message]
2016-09-17  7:36   ` Tatsuyuki Ishi
2016-09-17  9:21     ` Thomas Petazzoni
2016-09-17 10:47       ` Tatsuyuki Ishi
2016-09-17 10:59         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160916184113.6fd787c1@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox