* [Buildroot] [PATCH] php: bump 7.0.11
@ 2016-09-16 7:47 Tatsuyuki Ishi
2016-09-16 16:41 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Tatsuyuki Ishi @ 2016-09-16 7:47 UTC (permalink / raw)
To: buildroot
See the attached patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160916/ab3181d6/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-php-bump-7.0.11.patch
Type: text/x-patch
Size: 1360 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160916/ab3181d6/attachment.bin>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] php: bump 7.0.11
2016-09-16 7:47 [Buildroot] [PATCH] php: bump 7.0.11 Tatsuyuki Ishi
@ 2016-09-16 16:41 ` Thomas Petazzoni
2016-09-17 7:36 ` Tatsuyuki Ishi
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2016-09-16 16:41 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 16 Sep 2016 07:47:06 +0000, Tatsuyuki Ishi wrote:
> See the attached patch.
Thanks for this patch. However, we prefer to have patches "inline"
rather as attached files, as it makes the review easier. We recommend
to use "git send-email" to send patches.
In addition, your patches does not apply. Your change to php.hash is:
# From http://php.net/downloads.php
-sha256 970c322ba3e472cb0264b8ba9d4d92e87918da5d0cca53c4aba2a70545b8626d php-7.0.9.tar.xz
+sha256 d4cccea8da1d27c11b89386f8b8e95692ad3356610d571253d00ca67d524c735 php-7.0.11.tar.xz
sha256 44cab15d57b2fb8fa916ff9291059a34b0c3fa99298c2b08a5082f334613753a yaml-2.0.0RC8.tgz
sha256 bb13da909a7a7ae1f9e499166103a2d24628993238ce03a8aae3eaa492c0b736 pthreads-3.1.6.tgz
sha256 dc09445c0395bf21d06f21af64697d95244e1a06baade88afa7e07ef75d9b180 Weakref-0.3.2.tgz
But this does not match the php.hash in current Buildroot master, which
doesn't have any reference to the yaml, pthreads or Weakref tarballs.
Could you rework your patch and send an updated version?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] php: bump 7.0.11
2016-09-16 16:41 ` Thomas Petazzoni
@ 2016-09-17 7:36 ` Tatsuyuki Ishi
2016-09-17 9:21 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Tatsuyuki Ishi @ 2016-09-17 7:36 UTC (permalink / raw)
To: buildroot
Thank you, the following is the updated patch.
From: Tatsuyuki Ishi <ishitatsuyuki@gmail.com>
---
package/php/php.hash | 2 +-
package/php/php.mk | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/php/php.hash b/package/php/php.hash
index 6e146f8..0092095 100644
--- a/package/php/php.hash
+++ b/package/php/php.hash
@@ -1,2 +1,2 @@
# From http://php.net/downloads.php
-sha256 970c322ba3e472cb0264b8ba9d4d92e87918da5d0cca53c4aba2a70545b8626d
php-7.0.9.tar.xz
+sha256 d4cccea8da1d27c11b89386f8b8e95692ad3356610d571253d00ca67d524c735
php-7.0.11.tar.xz
diff --git a/package/php/php.mk b/package/php/php.mk
index 7df10be..083b451 100644
--- a/package/php/php.mk
+++ b/package/php/php.mk
@@ -4,7 +4,7 @@
#
###########################################################
#####################
-PHP_VERSION = 7.0.9
+PHP_VERSION = 7.0.11
PHP_SITE = http://www.php.net/distributions
PHP_SOURCE = php-$(PHP_VERSION).tar.xz
PHP_INSTALL_STAGING = YES
--
2.9.3
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160917/864f35fa/attachment.html>
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] php: bump 7.0.11
2016-09-17 7:36 ` Tatsuyuki Ishi
@ 2016-09-17 9:21 ` Thomas Petazzoni
2016-09-17 10:47 ` Tatsuyuki Ishi
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2016-09-17 9:21 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 17 Sep 2016 07:36:54 +0000, Tatsuyuki Ishi wrote:
> Thank you, the following is the updated patch.
Thanks. But this patch also cannot be applied, for two reasons:
- The changelog part of the message such as "Thank you, the
following..." should not be part of the commit log, but instead
should be below the "---" so that it does not get integrated in the
Git history when the patch is applied.
- Since you haven't used git send-email, your patch is line-wrapped
(i.e long lines are wrapped), so it cannot be applied.
Could you rework your patch to take into account those comments?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-17 10:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-16 7:47 [Buildroot] [PATCH] php: bump 7.0.11 Tatsuyuki Ishi
2016-09-16 16:41 ` Thomas Petazzoni
2016-09-17 7:36 ` Tatsuyuki Ishi
2016-09-17 9:21 ` Thomas Petazzoni
2016-09-17 10:47 ` Tatsuyuki Ishi
2016-09-17 10:59 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox