* [Buildroot] [git commit] package/python-rtslib-fb: bump version to 2.1.58 @ 2016-10-07 13:15 Thomas Petazzoni 2016-10-07 16:16 ` Christophe Vu-Brugier 0 siblings, 1 reply; 6+ messages in thread From: Thomas Petazzoni @ 2016-10-07 13:15 UTC (permalink / raw) To: buildroot commit: https://git.buildroot.net/buildroot/commit/?id=e57ea511ee8f4e944bc6343b467386fff20acd37 branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- package/python-rtslib-fb/python-rtslib-fb.hash | 5 +++-- package/python-rtslib-fb/python-rtslib-fb.mk | 7 ++++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/package/python-rtslib-fb/python-rtslib-fb.hash b/package/python-rtslib-fb/python-rtslib-fb.hash index fd06185..e4e56e7 100644 --- a/package/python-rtslib-fb/python-rtslib-fb.hash +++ b/package/python-rtslib-fb/python-rtslib-fb.hash @@ -1,2 +1,3 @@ -# locally computed -sha256 d5d81a78046b4c228d29ba88d9950e0f63858e5fcf601e3d0f8bf107fbaadc03 python-rtslib-fb-v2.1.fb57.tar.gz +# md5 from https://pypi.python.org/pypi/rtslib-fb/json, sha256 locally computed +md5 f8a2c55cea6de95968fc0dd49beeef6f rtslib-fb-2.1.58.tar.gz +sha256 5806f9903557907787abd9c8b9dffb2b312e6c5e3ff40d50d26b10c37b118d47 rtslib-fb-2.1.58.tar.gz diff --git a/package/python-rtslib-fb/python-rtslib-fb.mk b/package/python-rtslib-fb/python-rtslib-fb.mk index 85bee0b..f0864a0 100644 --- a/package/python-rtslib-fb/python-rtslib-fb.mk +++ b/package/python-rtslib-fb/python-rtslib-fb.mk @@ -4,10 +4,11 @@ # ################################################################################ -PYTHON_RTSLIB_FB_VERSION = v2.1.fb57 -PYTHON_RTSLIB_FB_SITE = $(call github,agrover,rtslib-fb,$(PYTHON_RTSLIB_FB_VERSION)) +PYTHON_RTSLIB_FB_VERSION = 2.1.58 +PYTHON_RTSLIB_FB_SOURCE = rtslib-fb-$(PYTHON_RTSLIB_FB_VERSION).tar.gz +PYTHON_RTSLIB_FB_SITE = https://pypi.python.org/packages/c8/26/ae0ff9a721d046bef78c457d8fc19287f7dbe36f98f5e190b017f0d9e9b7 PYTHON_RTSLIB_FB_LICENSE = Apache-2.0 -PYTHON_RTSLIB_FB_LICENSE_FILES = COPYING +PYTHON_RTSLIB_FB_LICENSE_FILES = setup.py PYTHON_RTSLIB_FB_SETUP_TYPE = setuptools PYTHON_RTSLIB_FB_DEPENDENCIES = python-six ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [git commit] package/python-rtslib-fb: bump version to 2.1.58 2016-10-07 13:15 [Buildroot] [git commit] package/python-rtslib-fb: bump version to 2.1.58 Thomas Petazzoni @ 2016-10-07 16:16 ` Christophe Vu-Brugier 2016-10-07 16:19 ` Christophe Vu-Brugier 2016-10-07 20:26 ` Thomas Petazzoni 0 siblings, 2 replies; 6+ messages in thread From: Christophe Vu-Brugier @ 2016-10-07 16:16 UTC (permalink / raw) To: buildroot Hi all, Sorry for commenting a patch after it has been applied. On Fri, 7 Oct 2016 15:15:19 +0200, Thomas Petazzoni wrote : > commit: https://git.buildroot.net/buildroot/commit/?id=e57ea511ee8f4e944bc6343b467386fff20acd37 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master > > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > package/python-rtslib-fb/python-rtslib-fb.hash | 5 +++-- > package/python-rtslib-fb/python-rtslib-fb.mk | 7 ++++--- > 2 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/package/python-rtslib-fb/python-rtslib-fb.hash b/package/python-rtslib-fb/python-rtslib-fb.hash > index fd06185..e4e56e7 100644 > --- a/package/python-rtslib-fb/python-rtslib-fb.hash > +++ b/package/python-rtslib-fb/python-rtslib-fb.hash > @@ -1,2 +1,3 @@ > -# locally computed > -sha256 d5d81a78046b4c228d29ba88d9950e0f63858e5fcf601e3d0f8bf107fbaadc03 python-rtslib-fb-v2.1.fb57.tar.gz > +# md5 from https://pypi.python.org/pypi/rtslib-fb/json, sha256 locally computed > +md5 f8a2c55cea6de95968fc0dd49beeef6f rtslib-fb-2.1.58.tar.gz > +sha256 5806f9903557907787abd9c8b9dffb2b312e6c5e3ff40d50d26b10c37b118d47 rtslib-fb-2.1.58.tar.gz > diff --git a/package/python-rtslib-fb/python-rtslib-fb.mk b/package/python-rtslib-fb/python-rtslib-fb.mk > index 85bee0b..f0864a0 100644 > --- a/package/python-rtslib-fb/python-rtslib-fb.mk > +++ b/package/python-rtslib-fb/python-rtslib-fb.mk > @@ -4,10 +4,11 @@ > # > ################################################################################ > > -PYTHON_RTSLIB_FB_VERSION = v2.1.fb57 > -PYTHON_RTSLIB_FB_SITE = $(call github,agrover,rtslib-fb,$(PYTHON_RTSLIB_FB_VERSION)) > +PYTHON_RTSLIB_FB_VERSION = 2.1.58 > +PYTHON_RTSLIB_FB_SOURCE = rtslib-fb-$(PYTHON_RTSLIB_FB_VERSION).tar.gz > +PYTHON_RTSLIB_FB_SITE = https://pypi.python.org/packages/c8/26/ae0ff9a721d046bef78c457d8fc19287f7dbe36f98f5e190b017f0d9e9b7 The home of rtslib-fb is still on GitHub but its maintainer, Andy Grover, has moved the repository ownership to the open-iscsi organization [1]. So the homepage of rtslib-fb, configshell-fb and targetcli-fb is now : https://github.com/open-iscsi/{rtslib,configshell,targetcli}-fb The old URL still works though. Moreover, version 2.1.58 is not the latest version since 2.1.60 was released a few days ago [2]. Note that targetcli-fb, configshell-fb and rtslib-fb are released at the same time because they are closely related (targetcli-fb imports both rtslib-fb and configshell-fb). So for Buildroot, it makes sense to upgrade rtslib-fb, configshell-fb and targetcli-fb at the same time but upgrading only one of them is a bit risky because you end up shipping versions of the packages that were not tested together by upstream developers. IIRC, I tried to bump targetcli-fb and its dependencies locally several month ago but encountered problems since targetcli-fb now depends on DBUS. I was also reluctant to upgrade rtslib-fb because it now depends on pyudev and I usually run targetcli without systemd/udev in Buildroot. I may resume work on upgrading targetcli-fb, configshell-fb and rtslib-fb though. With best regards, [1] https://lists.fedorahosted.org/archives/list/targetcli-fb-devel at lists.fedorahosted.org/thread/TSRZB37TVO3VCIB6HCHRO4PLN5TNP3QX/ [2] https://lists.fedorahosted.org/archives/list/targetcli-fb-devel at lists.fedorahosted.org/thread/U6IL4IWFCMW63RPSVQFBZCPUKS2B2T6I/ -- Christophe Vu-Brugier ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [git commit] package/python-rtslib-fb: bump version to 2.1.58 2016-10-07 16:16 ` Christophe Vu-Brugier @ 2016-10-07 16:19 ` Christophe Vu-Brugier 2016-10-07 20:26 ` Thomas Petazzoni 1 sibling, 0 replies; 6+ messages in thread From: Christophe Vu-Brugier @ 2016-10-07 16:19 UTC (permalink / raw) To: buildroot Hi, On Fri, 7 Oct 2016 18:16:27 +0200, Christophe Vu-Brugier wrote : > Moreover, version 2.1.58 is not the latest version since 2.1.60 was > released a few days ago [2]. Wrong, the latest version of rtslib-fb is 2.1.61, released on Monday, 3 October. With best regards, -- Christophe Vu-Brugier ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [git commit] package/python-rtslib-fb: bump version to 2.1.58 2016-10-07 16:16 ` Christophe Vu-Brugier 2016-10-07 16:19 ` Christophe Vu-Brugier @ 2016-10-07 20:26 ` Thomas Petazzoni 2016-10-07 21:10 ` Christophe Vu-Brugier 1 sibling, 1 reply; 6+ messages in thread From: Thomas Petazzoni @ 2016-10-07 20:26 UTC (permalink / raw) To: buildroot Hello, On Fri, 7 Oct 2016 18:16:27 +0200, Christophe Vu-Brugier wrote: > Sorry for commenting a patch after it has been applied. No problem, it's never too late to fix things up. > > -PYTHON_RTSLIB_FB_VERSION = v2.1.fb57 > > -PYTHON_RTSLIB_FB_SITE = $(call github,agrover,rtslib-fb,$(PYTHON_RTSLIB_FB_VERSION)) > > +PYTHON_RTSLIB_FB_VERSION = 2.1.58 > > +PYTHON_RTSLIB_FB_SOURCE = rtslib-fb-$(PYTHON_RTSLIB_FB_VERSION).tar.gz > > +PYTHON_RTSLIB_FB_SITE = https://pypi.python.org/packages/c8/26/ae0ff9a721d046bef78c457d8fc19287f7dbe36f98f5e190b017f0d9e9b7 > > The home of rtslib-fb is still on GitHub but its maintainer, Andy > Grover, has moved the repository ownership to the open-iscsi > organization [1]. > > So the homepage of rtslib-fb, configshell-fb and targetcli-fb is now : > > https://github.com/open-iscsi/{rtslib,configshell,targetcli}-fb > > The old URL still works though. OK. A patch updating the upstream URL in Config.in would be good. > Moreover, version 2.1.58 is not the latest version since 2.1.60 was > released a few days ago [2]. Right, but the latest version available from Pypi is 2.1.58, see https://pypi.org/project/rtslib-fb/. If you don't want a Python package to be changed to fetch from Pypi, I think a comment in the .mk file should be added. > Note that targetcli-fb, configshell-fb and rtslib-fb are released at > the same time because they are closely related (targetcli-fb imports > both rtslib-fb and configshell-fb). > > So for Buildroot, it makes sense to upgrade rtslib-fb, configshell-fb > and targetcli-fb at the same time but upgrading only one of them is a > bit risky because you end up shipping versions of the packages that > were not tested together by upstream developers. OK. I think this should be mentioned in a comment above the _VERSION field of those packages. This way, it is clearly visible when bumping the version of those packags. > IIRC, I tried to bump targetcli-fb and its dependencies locally several > month ago but encountered problems since targetcli-fb now depends > on DBUS. I was also reluctant to upgrade rtslib-fb because it now > depends on pyudev and I usually run targetcli without systemd/udev in > Buildroot. Those problems are due to upstream decisions, and we should not stop from upgrading because of such decisions. If you dislike those decisions, the solution is not to stop upgrading. The solution is to contact upstream and complain (possibly by submitting patches). Buildroot's policy is to follow what upstream decides... even if you don't like it :) > I may resume work on upgrading targetcli-fb, configshell-fb > and rtslib-fb though. OK. However, it is not clear from your e-mail if you think Bernd's patch should be reverted. Could you clarify this? Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [git commit] package/python-rtslib-fb: bump version to 2.1.58 2016-10-07 20:26 ` Thomas Petazzoni @ 2016-10-07 21:10 ` Christophe Vu-Brugier 2016-10-07 21:30 ` Thomas Petazzoni 0 siblings, 1 reply; 6+ messages in thread From: Christophe Vu-Brugier @ 2016-10-07 21:10 UTC (permalink / raw) To: buildroot Hi Thomas, On Fri, 7 Oct 2016 22:26:19 +0200, Thomas Petazzoni wrote : > On Fri, 7 Oct 2016 18:16:27 +0200, Christophe Vu-Brugier wrote: > > > Sorry for commenting a patch after it has been applied. > > No problem, it's never too late to fix things up. > > > > -PYTHON_RTSLIB_FB_VERSION = v2.1.fb57 > > > -PYTHON_RTSLIB_FB_SITE = $(call github,agrover,rtslib-fb,$(PYTHON_RTSLIB_FB_VERSION)) > > > +PYTHON_RTSLIB_FB_VERSION = 2.1.58 > > > +PYTHON_RTSLIB_FB_SOURCE = rtslib-fb-$(PYTHON_RTSLIB_FB_VERSION).tar.gz > > > +PYTHON_RTSLIB_FB_SITE = https://pypi.python.org/packages/c8/26/ae0ff9a721d046bef78c457d8fc19287f7dbe36f98f5e190b017f0d9e9b7 > > > > The home of rtslib-fb is still on GitHub but its maintainer, Andy > > Grover, has moved the repository ownership to the open-iscsi > > organization [1]. > > > > So the homepage of rtslib-fb, configshell-fb and targetcli-fb is now : > > > > https://github.com/open-iscsi/{rtslib,configshell,targetcli}-fb > > > > The old URL still works though. > > OK. A patch updating the upstream URL in Config.in would be good. OK. > > Moreover, version 2.1.58 is not the latest version since 2.1.60 was > > released a few days ago [2]. > > Right, but the latest version available from Pypi is 2.1.58, see > https://pypi.org/project/rtslib-fb/. If you don't want a Python package > to be changed to fetch from Pypi, I think a comment in the .mk file > should be added. OK. > > Note that targetcli-fb, configshell-fb and rtslib-fb are released at > > the same time because they are closely related (targetcli-fb imports > > both rtslib-fb and configshell-fb). > > > > So for Buildroot, it makes sense to upgrade rtslib-fb, configshell-fb > > and targetcli-fb at the same time but upgrading only one of them is a > > bit risky because you end up shipping versions of the packages that > > were not tested together by upstream developers. > > OK. I think this should be mentioned in a comment above the _VERSION > field of those packages. This way, it is clearly visible when bumping > the version of those packags. OK. > > IIRC, I tried to bump targetcli-fb and its dependencies locally several > > month ago but encountered problems since targetcli-fb now depends > > on DBUS. I was also reluctant to upgrade rtslib-fb because it now > > depends on pyudev and I usually run targetcli without systemd/udev in > > Buildroot. > > Those problems are due to upstream decisions, and we should not stop > from upgrading because of such decisions. If you dislike those > decisions, the solution is not to stop upgrading. The solution is to > contact upstream and complain (possibly by submitting patches). > > Buildroot's policy is to follow what upstream decides... even if you > don't like it :) I understand Buildroot's policy. The new dependencies are required by new features (user backstores rely on dbus) or brought to improve the code and its stability (pyudev). I am perfectly OK with this focus on features and stability. And as the same time, as a buildroot user, I like when my rootfs is small :) Let's call this "Embedded Schizophrenia". > > I may resume work on upgrading targetcli-fb, configshell-fb > > and rtslib-fb though. > > OK. However, it is not clear from your e-mail if you think Bernd's > patch should be reverted. Could you clarify this? Sorry, I was not clear. I think it would be better to revert Bernd's patch. I can cook up patches to: * clarify that rtslib-fb should be fetched from GitHub instead of PyPI * clarify that rtslib-fb, configshell-fb and targetcli-fb should be kept in sync. * later upgrade the three packages. Would that be OK for Bernd and you? With best regards, -- Christophe Vu-Brugier ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [git commit] package/python-rtslib-fb: bump version to 2.1.58 2016-10-07 21:10 ` Christophe Vu-Brugier @ 2016-10-07 21:30 ` Thomas Petazzoni 0 siblings, 0 replies; 6+ messages in thread From: Thomas Petazzoni @ 2016-10-07 21:30 UTC (permalink / raw) To: buildroot Hello, On Fri, 7 Oct 2016 23:10:43 +0200, Christophe Vu-Brugier wrote: > > Buildroot's policy is to follow what upstream decides... even if you > > don't like it :) > > I understand Buildroot's policy. > > The new dependencies are required by new features (user backstores rely > on dbus) or brought to improve the code and its stability (pyudev). I > am perfectly OK with this focus on features and stability. > > And as the same time, as a buildroot user, I like when my rootfs is > small :) Let's call this "Embedded Schizophrenia". Well, nothing prevents you from complaining to the upstream developers, and ask them to make those new dependencies optional. > Sorry, I was not clear. I think it would be better to revert Bernd's > patch. I can cook up patches to: > > * clarify that rtslib-fb should be fetched from GitHub instead of PyPI > * clarify that rtslib-fb, configshell-fb and targetcli-fb should be > kept in sync. > * later upgrade the three packages. > > Would that be OK for Bernd and you? Makes sense to me. I'll revert Bernd's patch. Thanks for your feedback! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-07 21:30 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-10-07 13:15 [Buildroot] [git commit] package/python-rtslib-fb: bump version to 2.1.58 Thomas Petazzoni 2016-10-07 16:16 ` Christophe Vu-Brugier 2016-10-07 16:19 ` Christophe Vu-Brugier 2016-10-07 20:26 ` Thomas Petazzoni 2016-10-07 21:10 ` Christophe Vu-Brugier 2016-10-07 21:30 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox